Declare support of sparsehash based index deprecated

Author: joto

CMakeLists.txt

@@ -170,9 +170,9 @@ set(OSMIUM_INCLUDE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/include")
 include_directories(${OSMIUM_INCLUDE_DIR})
 
 if(WITH_PROJ)
-    find_package(Osmium COMPONENTS io gdal geos proj sparsehash)
+    find_package(Osmium COMPONENTS io gdal geos proj)
 else()
-    find_package(Osmium COMPONENTS io gdal geos sparsehash)
+    find_package(Osmium COMPONENTS io gdal geos)
 endif()
 
 # The find_package put the directory where it found the libosmium includes

cmake/FindOsmium.cmake

@@ -33,7 +33,7 @@
 #      geos       - include if you want to use any of the GEOS functions
 #      gdal       - include if you want to use any of the OGR functions
 #      proj       - include if you want to use any of the Proj.4 functions
-#      sparsehash - include if you use the sparsehash index
+#      sparsehash - include if you use the sparsehash index (deprecated!)
 #      lz4        - include support for LZ4 compression of PBF files
 #
 #    You can check for success with something like this:
@@ -224,6 +224,7 @@ endif()
 #----------------------------------------------------------------------
 # Component 'sparsehash'
 if(Osmium_USE_SPARSEHASH)
+    message(WARNING "Osmium: Use of Google SparseHash is deprecated. Please switch to a different index type.")
     find_path(SPARSEHASH_INCLUDE_DIR google/sparsetable)
 
     list(APPEND OSMIUM_EXTRA_FIND_VARS SPARSEHASH_INCLUDE_DIR)

include/osmium/index/map/sparse_mem_table.hpp

@@ -38,6 +38,7 @@ DEALINGS IN THE SOFTWARE.
 #include <osmium/index/index.hpp>
 #include <osmium/index/map.hpp>
 #include <osmium/io/detail/read_write.hpp>
+#include <osmium/util/compatibility.hpp>
 
 #include <google/sparsetable>
 
@@ -63,9 +64,12 @@ namespace osmium {
              * country extracts).
              *
              * This will only work on 64 bit machines.
+             *
+             * @deprecated
+             * Use one of the other indexes instead.
              */
             template <typename TId, typename TValue>
-            class SparseMemTable : public osmium::index::map::Map<TId, TValue> {
+            class OSMIUM_DEPRECATED SparseMemTable : public osmium::index::map::Map<TId, TValue> {
 
                 TId m_grow_size;