fixup! Add wrapper around add_alias

Author: mgautierfr

libzim/libzim.pyx

@@ -395,8 +395,8 @@ cdef class _Creator:
         with nogil:
             self.c_creator.addRedirection(_path, _title, _targetPath, _hints)
 
-    def add_clone(self, str path: str, str title: str, str targetPath: str, dict hints: Dict[Hint, pyint]):
-        """Clone the (existing) entry `targetPath` into a new entry `path`.
+    def add_alias(self, str path: str, str title: str, str targetPath: str, dict hints: Dict[Hint, pyint]):
+        """Alias the (existing) entry `targetPath` as a new entry `path`.
 
             Raises
             ------
@@ -411,7 +411,7 @@ cdef class _Creator:
         cdef string _targetPath = targetPath.encode('UTF-8')
         cdef map[zim.HintKeys, uint64_t] _hints = convertToCppHints(hints)
         with nogil:
-            self.c_creator.addClone(_path, _title, _targetPath, _hints)
+            self.c_creator.addAlias(_path, _title, _targetPath, _hints)
 
     def __enter__(self):
         cdef string _path = str(self._filename).encode('UTF-8')

libzim/zim.pxd

@@ -70,7 +70,7 @@ cdef extern from "zim/writer/creator.h" namespace "zim::writer":
         void addItem(shared_ptr[WriterItem] item) nogil except +
         void addMetadata(string name, string content, string mimetype) nogil except +
         void addRedirection(string path, string title, string targetpath, map[HintKeys, uint64_t] hints) nogil except +
-        void addClone(string path, string title, string targetpath, map[HintKeys, uint64_t] hints) nogil except +
+        void addAlias(string path, string title, string targetpath, map[HintKeys, uint64_t] hints) except + nogil
         void finishZimCreation() nogil except +
         void setMainPath(string mainPath)
         void addIllustration(unsigned int size, string content) nogil except +

tests/test_libzim_creator.py

@@ -476,9 +476,9 @@ def test_creator_clone(fpath, lipsum_item):
 
     with Creator(fpath) as c:
         c.add_item(lipsum_item)
-        c.add_clone("home", "hello", HOME_PATH, {Hint.FRONT_ARTICLE: True})
+        c.add_alias("home", "hello", HOME_PATH, {Hint.FRONT_ARTICLE: True})
         with pytest.raises(RuntimeError, match="doesn't exist"):
-            c.add_clone("accueil", "bonjour", HOME_PATH+"_no_existitant", {Hint.FRONT_ARTICLE: True})
+            c.add_alias("accueil", "bonjour", HOME_PATH+"_no_existitant", {Hint.FRONT_ARTICLE: True})
 
     zim = Archive(fpath)
     assert zim.entry_count == 2