formal: fix posting summaries to the PR

Don't post empty formality check summaries to the PR.

Fix job URL.

Clean-up formatting.

Fixes: 1079ad9 ("formal: post summary to the PR")
Signed-off-by: George Sapkin <george@sapk.in>

Author: GeorgeSapkin

.github/scripts/process_formalities.js

@@ -41,11 +41,11 @@ const SUMMARY_HEADER=`
 <summary>Failed checks</summary>
 
 Issues marked with an :x: are failing checks.
-`
+`;
 
 const SUMMARY_FOOTER=`
 </details>
-`
+`;
 
 async function hideOldSummaries({ github, owner, repo, issueNumber }) {
   const result = await github.graphql(GET_COMMENTS_QUERY, { owner, repo, issueNumber });
@@ -61,17 +61,19 @@ async function hideOldSummaries({ github, owner, repo, issueNumber }) {
   }
 }
 
-function getJobUrl({ context, jobId  }) {
-  return `https://github.com/GeorgeSapkin/openwrt-packages/actions/runs/${context.runId}/job/${jobId}?pr=${context.issue.number}#${STEP_ANCHOR}`;
+function getJobUrl({ context, jobId }) {
+  return `https://github.com/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}/job/${jobId}?pr=${context.issue.number}#${STEP_ANCHOR}`;
 }
 
 function getSummaryMessage({ context, jobId, summary }) {
   return `
   ${SUMMARY_HEADER}
+
   ${summary}
+
   ${SUMMARY_FOOTER}
   For more details, see the [full job log](${getJobUrl({ context, jobId })}).
-  `
+  `;
 }
 
 async function processFormalities({ github, context, jobId, summary }) {
@@ -80,14 +82,19 @@ async function processFormalities({ github, context, jobId, summary }) {
 
   await hideOldSummaries({ github, owner, repo, issueNumber });
 
+  summary = summary.trim();
+  if (summary.length === 0) {
+    return;
+  }
+
   console.log("Posting new summary comment");
   const body = getSummaryMessage({ context, jobId, summary });
   return github.rest.issues.createComment({
     issue_number: issueNumber,
     owner,
     repo,
     body,
-  })
+  });
 }
 
 module.exports = processFormalities;