Skip to content

Commit fe021b3

Browse files
committed
Clean up the tracing info for statements in error cases.
1 parent 7398431 commit fe021b3

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

sqlalchemy_opentracing/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,9 @@ def _engine_error_handler(exception_context):
176176
span.set_tag('error', 'true')
177177
span.finish()
178178

179+
if execution_context.compiled is not None:
180+
clear_traced(execution_context.compiled.statement)
181+
179182
def _register_connection_events(conn):
180183
'''
181184
Register clean up events for our

tests/test_core.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ def test_traced_error(self):
7777
'sqlalchemy.exception': 'table users already exists',
7878
'error': 'true',
7979
})
80+
self.assertEqual(False, sqlalchemy_opentracing.get_traced(creat))
8081

8182
def test_trace_text(self):
8283
tracer = DummyTracer()

0 commit comments

Comments
 (0)