Skip to content

Commit 78eb21e

Browse files
committed
Cleanup the session events naming.
1 parent 4c79ec5 commit 78eb21e

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

sqlalchemy_opentracing/__init__.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def set_traced(obj):
3535
if isinstance(obj, Session):
3636
# Session needs to have its connection/statements
3737
# decorated as soon as a connection is acquired.
38-
_register_session_connection_event(obj)
38+
_register_session_events(obj)
3939
elif isinstance(obj, Connection):
4040
# Connection simply needs to be cleaned up
4141
# after commit/rollback.
@@ -191,7 +191,7 @@ def _register_connection_events(conn):
191191
listen(conn, 'commit', _connection_cleanup_handler)
192192
listen(conn, 'rollback', _connection_cleanup_handler)
193193

194-
def _register_session_connection_event(session):
194+
def _register_session_events(session):
195195
'''
196196
Register connection/transaction and clean up events
197197
for our session only once, as adding/removing them
@@ -208,8 +208,8 @@ def _register_session_connection_event(session):
208208

209209
# Plug post-operation clean up handlers.
210210
# The actual session commit/rollback is not traced by us.
211-
listen(session, 'after_commit', _session_before_commit_handler)
212-
listen(session, 'after_rollback', _session_rollback_handler)
211+
listen(session, 'after_commit', _session_cleanup_handler)
212+
listen(session, 'after_rollback', _session_cleanup_handler)
213213

214214
def _connection_cleanup_handler(conn):
215215
clear_traced(conn)
@@ -220,9 +220,6 @@ def _session_after_begin_handler(session, transaction, conn):
220220
if get_traced(session):
221221
_set_traced_with_session(conn, session)
222222

223-
def _session_before_commit_handler(session):
224-
clear_traced(session)
225-
226-
def _session_rollback_handler(session):
223+
def _session_cleanup_handler(session):
227224
clear_traced(session)
228225

0 commit comments

Comments
 (0)