[b/r] Add backup/restore labels to ControlPlane controller

Wire the BackupConfig reconciliation into the ControlPlane controller.
Add backup/restore labels to CA cert secrets via SecretTemplate, and
restore=false labels to internal service cert requests. Add the
ReconcileBackupConfig call, secret watch with annotation change
predicate, and RBAC for openstackbackupconfigs. Set BackupConfig spec
defaults in the CreateOrPatch mutate function.

Label custom Issuers for backup/restore directly in ca.go where the
ControlPlane controller processes them from spec.tls.*.ca.customIssuer.

Return error from GetCertSecretBackupLabels for non-NotFound errors so
the calling operator retries. Rename GetConfig parameter from gvk to
crdName.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>

Author: stuggi

api/bases/core.openstack.org_openstackcontrolplanes.yaml

@@ -4,6 +4,10 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.18.0
+  labels:
+    backup.openstack.org/category: controlplane
+    backup.openstack.org/restore: "true"
+    backup.openstack.org/restore-order: "30"
   name: openstackcontrolplanes.core.openstack.org
 spec:
   group: core.openstack.org

api/bases/core.openstack.org_openstackversions.yaml

@@ -4,6 +4,10 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.18.0
+  labels:
+    backup.openstack.org/category: controlplane
+    backup.openstack.org/restore: "true"
+    backup.openstack.org/restore-order: "20"
   name: openstackversions.core.openstack.org
 spec:
   group: core.openstack.org

api/bases/dataplane.openstack.org_openstackdataplanenodesets.yaml

@@ -4,6 +4,10 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.18.0
+  labels:
+    backup.openstack.org/category: dataplane
+    backup.openstack.org/restore: "true"
+    backup.openstack.org/restore-order: "60"
   name: openstackdataplanenodesets.dataplane.openstack.org
 spec:
   group: dataplane.openstack.org

api/bases/dataplane.openstack.org_openstackdataplaneservices.yaml

@@ -4,6 +4,10 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.18.0
+  labels:
+    backup.openstack.org/category: dataplane
+    backup.openstack.org/restore: "true"
+    backup.openstack.org/restore-order: "40"
   name: openstackdataplaneservices.dataplane.openstack.org
 spec:
   group: dataplane.openstack.org

api/core/v1beta1/openstackcontrolplane_types.go

@@ -1118,6 +1118,9 @@ type TLSCAStatus struct {
 // +kubebuilder:resource:shortName=osctlplane;osctlplanes;oscp;oscps
 // +kubebuilder:printcolumn:name="Status",type="string",JSONPath=".status.conditions[0].status",description="Status"
 // +kubebuilder:printcolumn:name="Message",type="string",JSONPath=".status.conditions[0].message",description="Message"
+// +kubebuilder:metadata:labels=backup.openstack.org/restore=true
+// +kubebuilder:metadata:labels=backup.openstack.org/category=controlplane
+// +kubebuilder:metadata:labels=backup.openstack.org/restore-order=30
 
 // OpenStackControlPlane is the Schema for the openstackcontrolplanes API
 type OpenStackControlPlane struct {

api/core/v1beta1/openstackversion_types.go

@@ -218,6 +218,9 @@ type OpenStackVersionStatus struct {
 // +kubebuilder:printcolumn:name="Target Version",type=string,JSONPath=`.spec.targetVersion`
 // +kubebuilder:printcolumn:name="Available Version",type=string,JSONPath=`.status.availableVersion`
 // +kubebuilder:printcolumn:name="Deployed Version",type=string,JSONPath=`.status.deployedVersion`
+// +kubebuilder:metadata:labels=backup.openstack.org/restore=true
+// +kubebuilder:metadata:labels=backup.openstack.org/category=controlplane
+// +kubebuilder:metadata:labels=backup.openstack.org/restore-order=20
 
 // OpenStackVersion defines the Schema for the openstackversionupdates API
 type OpenStackVersion struct {

api/dataplane/v1beta1/openstackdataplanenodeset_types.go

@@ -94,10 +94,13 @@ type OpenStackDataPlaneNodeSetSpec struct {
 // +kubebuilder:resource:shortName=osdpns;osdpnodeset;osdpnodesets
 // +kubebuilder:printcolumn:name="Status",type="string",JSONPath=".status.conditions[0].status",description="Status"
 // +kubebuilder:printcolumn:name="Message",type="string",JSONPath=".status.conditions[0].message",description="Message"
+// +kubebuilder:metadata:labels=backup.openstack.org/restore=true
+// +kubebuilder:metadata:labels=backup.openstack.org/category=dataplane
+// +kubebuilder:metadata:labels=backup.openstack.org/restore-order=60
 
 // OpenStackDataPlaneNodeSet is the Schema for the openstackdataplanenodesets API
 // OpenStackDataPlaneNodeSet name must be a valid RFC1123 as it is used in labels
-type OpenStackDataPlaneNodeSet struct {
+type OpenStackDataPlaneNodeSet struct{
 	metav1.TypeMeta   `json:",inline"`
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 

api/dataplane/v1beta1/openstackdataplaneservice_types.go

@@ -130,6 +130,9 @@ type OpenStackDataPlaneServiceStatus struct {
 // +kubebuilder:subresource:status
 // +kubebuilder:resource:shortName=osdps;osdpservice;osdpservices
 // +operator-sdk:csv:customresourcedefinitions:displayName="OpenStack Data Plane Service"
+// +kubebuilder:metadata:labels=backup.openstack.org/restore=true
+// +kubebuilder:metadata:labels=backup.openstack.org/category=dataplane
+// +kubebuilder:metadata:labels=backup.openstack.org/restore-order=40
 
 // OpenStackDataPlaneService defines the Schema for the openstackdataplaneservices API.
 // OpenStackDataPlaneService name must be a valid RFC1123 as it is used in labels

bindata/crds/crds.yaml

@@ -529,6 +529,10 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.18.0
+  labels:
+    backup.openstack.org/category: controlplane
+    backup.openstack.org/restore: "true"
+    backup.openstack.org/restore-order: "30"
   name: openstackcontrolplanes.core.openstack.org
 spec:
   group: core.openstack.org
@@ -19197,6 +19201,10 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.18.0
+  labels:
+    backup.openstack.org/category: dataplane
+    backup.openstack.org/restore: "true"
+    backup.openstack.org/restore-order: "60"
   name: openstackdataplanenodesets.dataplane.openstack.org
 spec:
   group: dataplane.openstack.org
@@ -21193,6 +21201,10 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.18.0
+  labels:
+    backup.openstack.org/category: dataplane
+    backup.openstack.org/restore: "true"
+    backup.openstack.org/restore-order: "40"
   name: openstackdataplaneservices.dataplane.openstack.org
 spec:
   group: dataplane.openstack.org
@@ -21490,6 +21502,10 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.18.0
+  labels:
+    backup.openstack.org/category: controlplane
+    backup.openstack.org/restore: "true"
+    backup.openstack.org/restore-order: "20"
   name: openstackversions.core.openstack.org
 spec:
   group: core.openstack.org

config/crd/bases/core.openstack.org_openstackcontrolplanes.yaml

@@ -4,6 +4,10 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.18.0
+  labels:
+    backup.openstack.org/category: controlplane
+    backup.openstack.org/restore: "true"
+    backup.openstack.org/restore-order: "30"
   name: openstackcontrolplanes.core.openstack.org
 spec:
   group: core.openstack.org