feat: Add service CRUD to the catalog provider#773
Open
mashawes wants to merge 2 commits into
Open
Conversation
Signed-off-by: Mohammed <mashawes@andrew.cmu.edu>
gtema
requested changes
Jun 9, 2026
| #[derive(Builder, Clone, Debug, Default, PartialEq, Validate)] | ||
| #[builder(build_fn(error = "BuilderError"))] | ||
| #[builder(setter(strip_option, into))] | ||
| pub struct Service { |
Collaborator
There was a problem hiding this comment.
in the database model we have only id/enabled/type/extra. All other fields are captured as json under extra. As such we should not try to re-expose the "name" here separately since it is anyway an optional field. Please remove "name" field from models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the catalog with service CRUD, following the same pattern as region (#723).
Closes #724
Note: this contribution was developed with AI assistance.