Skip to content

Commit 81d30ff

Browse files
Merge pull request #1023 from arvindk-softwaredev/fix/SRVKP-11391
SRVKP-11391: fix for archived PLR details page
2 parents e7290ff + 8e91e58 commit 81d30ff

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

src/components/pipelineRuns-details/PipelineRunDetailsPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const PipelineRunDetailsPage: FC<PipelineRunDetailsPageProps> = ({
4848
const { t } = useTranslation('plugin__pipelines-console-plugin');
4949
const [pipelineRun, k8sLoaded, trLoaded] = usePipelineRun(namespace, name);
5050
/* this needs decoupling */
51-
const pipelineRunLoaded = k8sLoaded && trLoaded;
51+
const pipelineRunLoaded = k8sLoaded || trLoaded;
5252

5353
const customActionMenu = useCallback((_kindObj, obj) => {
5454
const reference = getReferenceForModel(PipelineRunModel);

src/components/pipelineRuns-details/PipelineRunLogs.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ export const PipelineRunLogsWithActiveTask: FC<
292292
plrStatus !== ComputedStatus.Running &&
293293
plrStatus !== ComputedStatus.Pending &&
294294
plrStatus !== ComputedStatus.Cancelling;
295-
const [taskRuns, taskRunsLoaded, , , pendingAdmission, proxyUnavailable] =
295+
const [taskRuns, k8sLoaded, trLoaded, , pendingAdmission, proxyUnavailable] =
296296
useTaskRuns(
297297
obj?.metadata?.namespace,
298298
obj?.metadata?.name,
@@ -303,6 +303,8 @@ export const PipelineRunLogsWithActiveTask: FC<
303303
pipelineRunManagedBy: obj?.spec?.managedBy,
304304
},
305305
);
306+
/* this needs decoupling */
307+
const taskRunsLoaded = k8sLoaded || trLoaded;
306308
const { isResourceManagedByKueue } = useMultiClusterProxyService({
307309
managedBy: obj?.spec?.managedBy,
308310
});

src/components/pipelineRuns-details/PipelineRunVisualization.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const PipelineRunVisualization: FC<PipelineRunVisualizationProps> = ({
3535
},
3636
);
3737
/* this needs decoupling */
38-
const taskRunsLoaded = k8sLoaded && trLoaded;
38+
const taskRunsLoaded = k8sLoaded || trLoaded;
3939
const pipeline: PipelineKind = usePipelineFromPipelineRun(pipelineRun);
4040
if (!pipeline) {
4141
return (

0 commit comments

Comments
 (0)