Skip to content

Commit e547ea6

Browse files
committed
Comment out function overloadings to make basic functions work
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
1 parent 34cbaca commit e547ea6

1 file changed

Lines changed: 28 additions & 15 deletions

File tree

core/src/main/java/org/opensearch/sql/expression/function/PPLFuncImpTable.java

Lines changed: 28 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -547,18 +547,20 @@ public RexNode resolve(
547547
// For example, the REDUCE function requires the second argument to be cast to the
548548
// return type of the lambda function.
549549
compulsoryCast(builder, functionName, args);
550+
// TODO: How to deal with multiple overrides?
551+
if (true) return implementList.getFirst().getValue().resolve(builder, args);
550552

551553
List<RelDataType> argTypes = Arrays.stream(args).map(RexNode::getType).toList();
552554
try {
553555
for (Map.Entry<CalciteFuncSignature, FunctionImp> implement : implementList) {
554556
if (implement.getKey().match(functionName.getName(), argTypes)) {
555557
return implement.getValue().resolve(builder, args);
556558
}
557-
// // TODO: How to deal with multiple overrides?
558-
// // A temporary implementation to return once name matches
559-
// if (implement.getKey().functionName().equals(functionName.getName())){
560-
// return implement.getValue().resolve(builder, args);
561-
// }
559+
// // TODO: How to deal with multiple overrides?
560+
// // A temporary implementation to return once name matches
561+
// if (implement.getKey().functionName().equals(functionName.getName())){
562+
// return implement.getValue().resolve(builder, args);
563+
// }
562564
}
563565

564566
// If no implementation found with exact match, try to cast arguments to match the
@@ -710,12 +712,23 @@ protected void registerDivideFunction(BuiltinFunctionName functionName) {
710712

711713
void populate() {
712714
// register operators for comparison
713-
registerOperator(NOTEQUAL, PPLBuiltinOperators.NOT_EQUALS_IP, SqlStdOperatorTable.NOT_EQUALS);
714-
registerOperator(EQUAL, PPLBuiltinOperators.EQUALS_IP, SqlStdOperatorTable.EQUALS);
715-
registerOperator(GREATER, PPLBuiltinOperators.GREATER_IP, SqlStdOperatorTable.GREATER_THAN);
716-
registerOperator(GTE, PPLBuiltinOperators.GTE_IP, SqlStdOperatorTable.GREATER_THAN_OR_EQUAL);
717-
registerOperator(LESS, PPLBuiltinOperators.LESS_IP, SqlStdOperatorTable.LESS_THAN);
718-
registerOperator(LTE, PPLBuiltinOperators.LTE_IP, SqlStdOperatorTable.LESS_THAN_OR_EQUAL);
715+
// registerOperator(NOTEQUAL, PPLBuiltinOperators.NOT_EQUALS_IP,
716+
// SqlStdOperatorTable.NOT_EQUALS);
717+
// registerOperator(EQUAL, PPLBuiltinOperators.EQUALS_IP, SqlStdOperatorTable.EQUALS);
718+
// registerOperator(GREATER, PPLBuiltinOperators.GREATER_IP,
719+
// SqlStdOperatorTable.GREATER_THAN);
720+
// registerOperator(GTE, PPLBuiltinOperators.GTE_IP,
721+
// SqlStdOperatorTable.GREATER_THAN_OR_EQUAL);
722+
// registerOperator(LESS, PPLBuiltinOperators.LESS_IP, SqlStdOperatorTable.LESS_THAN);
723+
// registerOperator(LTE, PPLBuiltinOperators.LTE_IP,
724+
// SqlStdOperatorTable.LESS_THAN_OR_EQUAL);
725+
726+
registerOperator(NOTEQUAL, SqlStdOperatorTable.NOT_EQUALS);
727+
registerOperator(EQUAL, SqlStdOperatorTable.EQUALS);
728+
registerOperator(GREATER, SqlStdOperatorTable.GREATER_THAN);
729+
registerOperator(GTE, SqlStdOperatorTable.GREATER_THAN_OR_EQUAL);
730+
registerOperator(LESS, SqlStdOperatorTable.LESS_THAN);
731+
registerOperator(LTE, SqlStdOperatorTable.LESS_THAN_OR_EQUAL);
719732

720733
// Register std operator
721734
registerOperator(AND, SqlStdOperatorTable.AND);
@@ -1052,10 +1065,10 @@ void populate() {
10521065

10531066
// Register ADD (+ symbol) for string concatenation
10541067
// Replaced type checker since CONCAT also supports array concatenation
1055-
registerOperator(
1056-
ADD,
1057-
SqlStdOperatorTable.CONCAT,
1058-
PPLTypeChecker.family(SqlTypeFamily.CHARACTER, SqlTypeFamily.CHARACTER));
1068+
// registerOperator(
1069+
// ADD,
1070+
// SqlStdOperatorTable.CONCAT,
1071+
// PPLTypeChecker.family(SqlTypeFamily.CHARACTER, SqlTypeFamily.CHARACTER));
10591072
// Register ADD (+ symbol) for numeric addition
10601073
// Replace type checker since PLUS also supports binary addition
10611074
registerOperator(

0 commit comments

Comments
 (0)