Skip to content

Commit a16e54e

Browse files
committed
Do not remove sort in subqueries when converting sql to rel (1820/2027)
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
1 parent cba9f44 commit a16e54e

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

core/src/main/java/org/opensearch/sql/executor/QueryService.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,14 +387,18 @@ public SqlNode visit(SqlIdentifier id) {
387387
RelOptCluster cluster = context.relBuilder.getCluster();
388388
CalciteCatalogReader catalogReader =
389389
validator.getCatalogReader().unwrap(CalciteCatalogReader.class);
390+
// Do not remove sort in subqueries so that the orders for queries like `... | sort a | fields
391+
// b` is preserved
392+
SqlToRelConverter.Config sql2relConfig =
393+
SqlToRelConverter.config().withRemoveSortInSubQuery(false);
390394
SqlToRelConverter sql2rel =
391395
new SqlToRelConverter(
392396
viewExpander,
393397
validator,
394398
catalogReader,
395399
cluster,
396400
PplConvertletTable.INSTANCE,
397-
SqlToRelConverter.config());
401+
sql2relConfig);
398402
RelRoot validatedRelRoot = sql2rel.convertQuery(rewritten, false, true);
399403
return validatedRelRoot.rel.accept(new PplRelToSqlRelShuttle(context.rexBuilder, false));
400404
}

0 commit comments

Comments
 (0)