[Maintenance] Fix bc-fips jar hell by marking dependency as compileOnly (#5158)

* [maintenance] Fix bc-fips jar hell by marking dependency as compileOnly

Signed-off-by: Jialiang Liang <jiallian@amazon.com>

* add fix for tests

Signed-off-by: Jialiang Liang <jiallian@amazon.com>

---------

Signed-off-by: Jialiang Liang <jiallian@amazon.com>

Author: RyanL1997

datasources/build.gradle

@@ -3,8 +3,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import org.opensearch.gradle.info.FipsBuildParams
-
 plugins {
     id 'java-library'
     id "io.freefair.lombok"
@@ -28,12 +26,10 @@ dependencies {
     implementation ('com.amazonaws:aws-encryption-sdk-java:2.4.1') {
         exclude group: 'org.bouncycastle', module: 'bcprov-ext-jdk18on'
     }
-    // When building with -Pcrypto.standard=FIPS-140-3, bcFips jars are provided by OpenSearch
-    if (FipsBuildParams.isInFipsMode()) {
-        compileOnly "org.bouncycastle:bc-fips:${versions.bouncycastle_jce}"
-    } else {
-        implementation "org.bouncycastle:bc-fips:${versions.bouncycastle_jce}"
-    }
+
+    // bc-fips is provided by OpenSearch core at runtime since opensearch 3.6.0
+    compileOnly "org.bouncycastle:bc-fips:${versions.bouncycastle_jce}"
+    testImplementation "org.bouncycastle:bc-fips:${versions.bouncycastle_jce}"
 
     testImplementation group: 'junit', name: 'junit', version: '4.13.2'
     testImplementation('org.junit.jupiter:junit-jupiter:5.9.3')