Fix #5163: Return null for double overflow to Infinity in arithmetic (#5202)

* Fix #5163: Return null for double overflow to Infinity in arithmetic operations

Signed-off-by: Peng Huo <penghuo@gmail.com>

* Address review feedback for #5163: complete test coverage and use isFinite()

- Add 6 missing unit tests: divide/modulus double, add/subtract/divide/modulus float
- Add NaN tests for ExprValueUtils.fromObjectValue (Double.NaN, Float.NaN)
- Add yamlRestTest reproducing the bug's PPL query with Double.MAX_VALUE
- Use Double.isFinite()/Float.isFinite() instead of isInfinite()||isNaN()

Signed-off-by: Peng Huo <penghuo@gmail.com>

* Fix spotless formatting in ArithmeticFunctions and tests

Signed-off-by: Peng Huo <penghuo@gmail.com>

* Revert V2 ArithmeticFunctions changes; keep ExprValueUtils fix for Calcite path

Signed-off-by: Peng Huo <penghuo@gmail.com>

---------

Signed-off-by: Peng Huo <penghuo@gmail.com>

Author: penghuo

core/src/main/java/org/opensearch/sql/data/model/ExprValueUtils.java

@@ -133,7 +133,7 @@ public static ExprValue fromObjectValue(Object o) {
     } else if (o instanceof Boolean) {
       return booleanValue((Boolean) o);
     } else if (o instanceof Double d) {
-      if (Double.isNaN(d)) {
+      if (!Double.isFinite(d)) {
         return LITERAL_NULL;
       }
       return doubleValue(d);
@@ -144,7 +144,7 @@ public static ExprValue fromObjectValue(Object o) {
     } else if (o instanceof String) {
       return stringValue((String) o);
     } else if (o instanceof Float f) {
-      if (Float.isNaN(f)) {
+      if (!Float.isFinite(f)) {
         return LITERAL_NULL;
       }
       return floatValue(f);

core/src/test/java/org/opensearch/sql/data/model/ExprValueUtilsTest.java

@@ -9,6 +9,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.opensearch.sql.data.model.ExprValueUtils.integerValue;
 import static org.opensearch.sql.data.type.ExprCoreType.ARRAY;
 import static org.opensearch.sql.data.type.ExprCoreType.BOOLEAN;
@@ -243,6 +244,28 @@ public void constructDateAndTimeValue() {
         ExprValueUtils.fromObjectValue("2012-07-07 01:01:01", TIMESTAMP));
   }
 
+  @Test
+  public void fromObjectValue_double_infinity_returns_null() {
+    assertTrue(ExprValueUtils.fromObjectValue(Double.POSITIVE_INFINITY).isNull());
+    assertTrue(ExprValueUtils.fromObjectValue(Double.NEGATIVE_INFINITY).isNull());
+  }
+
+  @Test
+  public void fromObjectValue_float_infinity_returns_null() {
+    assertTrue(ExprValueUtils.fromObjectValue(Float.POSITIVE_INFINITY).isNull());
+    assertTrue(ExprValueUtils.fromObjectValue(Float.NEGATIVE_INFINITY).isNull());
+  }
+
+  @Test
+  public void fromObjectValue_double_nan_returns_null() {
+    assertTrue(ExprValueUtils.fromObjectValue(Double.NaN).isNull());
+  }
+
+  @Test
+  public void fromObjectValue_float_nan_returns_null() {
+    assertTrue(ExprValueUtils.fromObjectValue(Float.NaN).isNull());
+  }
+
   @Test
   public void hashCodeTest() {
     assertEquals(new ExprByteValue(1).hashCode(), new ExprByteValue(1).hashCode());

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/5163.yml

@@ -0,0 +1,49 @@
+setup:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled: true
+  - do:
+      indices.create:
+        index: bounty-types
+        body:
+          mappings:
+            properties:
+              "int_field":
+                type: integer
+              "double_field":
+                type: double
+  - do:
+      bulk:
+        index: bounty-types
+        refresh: true
+        body:
+          - '{"index": {"_id": "1"}}'
+          - '{"int_field": 2147483647, "double_field": 1.7976931348623157E308}'
+
+---
+teardown:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled: false
+
+---
+"Double overflow to Infinity returns null instead of crashing":
+  - skip:
+      features:
+        - headers
+        - allowed_warnings
+  - do:
+      allowed_warnings:
+        - 'Loading the fielddata on the _id field is deprecated and will be removed in future versions. If you require sorting or aggregating on this field you should also include the id in the body of your documents, and map this field as a keyword field that has [doc_values] enabled'
+      headers:
+        Content-Type: 'application/json'
+      ppl:
+        body:
+          query: source=bounty-types | where int_field = 2147483647 | eval double_mul = double_field * 2 | fields double_field, double_mul
+
+  - match: { total: 1 }
+  - match: { "datarows": [[1.7976931348623157E308, null]] }