cleanup $submit_file_environment calculation

always map key=val -> key='val', and don't do it in a big loop.

the $sq variable is used for single quotes, to avoid quoting weirdness
inside of the env_array substitution lines.

Author: edquist

src/scripts/condor_submit.sh

@@ -204,24 +204,10 @@ if [ "x$environment" != "x" ] ; then
 # new condor format to avoid errors  when things like LS_COLORS (which 
 # has semicolons in it) get captured
     eval "env_array=($environment)"
-    submit_file_environment=""
-    for  env_var in "${env_array[@]}"; do
-        if [ "x$submit_file_environment" == "x" ] ; then
-            submit_file_environment="environment = \" ${env_var}"
-        else
-            # check for spaces in env_var
-            pattern=" "
-            if [[ $env_var =~ $pattern ]]; then
-              fixed_env_var="${env_var}'"
-              fixed_env_var=`echo ${fixed_env_var} | sed -e "s|=|='|"`
-              echo "12 -- ${fixed_env_var}" >> ~/foo
-              submit_file_environment="${submit_file_environment} ${fixed_env_var} "
-            else
-              submit_file_environment="${submit_file_environment} ${env_var} "
-            fi
-        fi
-    done
-    submit_file_environment="${submit_file_environment}\""
+    sq="'"  # map key=val -> key='val'
+    env_array=("${env_array[@]/=/=$sq}")
+    env_array=("${env_array[@]/%/$sq}")
+    submit_file_environment="environment = \"${env_array[*]}\""
 else
     if [ "x$envir" != "x" ] ; then
 # Old Condor format (no double quotes in submit file)