Skip to content

Commit 38ecc2b

Browse files
committed
Remove outdated Gitpod notes from KNOWLEDGE.md and clarify upgrade steps in Maintenance.md; adjust POSTGRES_DEV_PORT in example.env
1 parent 1533681 commit 38ecc2b

3 files changed

Lines changed: 1 addition & 9 deletions

File tree

KNOWLEDGE.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,6 @@ strange errors during acceptance testing.
6666
See also <https://docs.docker.com/network/proxy/#configure-the-docker-client>
6767
and <https://forums.docker.com/t/docker-swarm-mode-not-picking-up-proxy-configuration/132233/8?u=medihack>
6868

69-
## Gitpod
70-
71-
- It is not possible to set an ENV variable using the Gitpod Dockerfile
72-
- In Gitpod ENV variables can only be set using the Gitpod settings
73-
- The PYTHONPATH environment variable can't be set in the Gitpod settings (it is always overwritten with a blank value)
74-
- What is ALLOWED_HOSTS? <https://www.divio.com/blog/django-allowed-hosts-explained/>
75-
7669
## Commands
7770

7871
### Testing and coverage commands

docs/Maintenance.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,5 @@ There are different things that can be upgraded:
1515
- After an upgrade make sure the files in `static/vendor` still link to the correct files in `node_modules`1
1616
- Python and uv in `Dockerfile` that builds the container where ADIT runs in
1717
- Dependent services in `docker-compose.base.yml`, like PostgreSQL or Vespa database
18-
- Gitpod development container dependencies in `.gitpod.Dockerfile`
1918
- Github Codespaces development container dependencies in `.devcontainer/devcontainer.json` and `.devcontainer/Dockerfile`
2019
- Github actions `.github/workflows/ci.yml` dependencies

example.env

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
ENVIRONMENT=development
44

55
# Ports that will be mapped to the host during development.
6-
POSTGRES_DEV_PORT=5432
76
WEB_DEV_PORT=8000
7+
POSTGRES_DEV_PORT=5432
88

99
# Ports that will be mapped to the host during production.
1010
WEB_HTTP_PORT=80

0 commit comments

Comments
 (0)