make HTTPClient.cache compulsory

Author: geetu040

openml/_api/clients/http.py

@@ -19,7 +19,6 @@
 from openml.__version__ import __version__
 from openml.enums import RetryPolicy
 from openml.exceptions import (
-    OpenMLCacheRequiredError,
     OpenMLHashException,
     OpenMLNotAuthorizedError,
     OpenMLServerError,
@@ -231,7 +230,7 @@ def __init__(  # noqa: PLR0913
         api_key: str,
         retries: int,
         retry_policy: RetryPolicy,
-        cache: HTTPCache | None = None,
+        cache: HTTPCache,
     ) -> None:
         self.server = server
         self.base_url = base_url
@@ -608,7 +607,7 @@ def request(  # noqa: PLR0913, C901
 
         files = request_kwargs.pop("files", None)
 
-        if use_cache and not reset_cache and self.cache is not None:
+        if use_cache and not reset_cache:
             cache_key = self.cache.get_key(url, params)
             try:
                 return self.cache.load(cache_key)
@@ -647,7 +646,7 @@ def request(  # noqa: PLR0913, C901
         if md5_checksum is not None:
             self._verify_checksum(response, md5_checksum)
 
-        if use_cache and self.cache is not None:
+        if use_cache:
             cache_key = self.cache.get_key(url, params)
             self.cache.save(cache_key, response)
 
@@ -812,15 +811,9 @@ def download(
 
         Raises
         ------
-        OpenMLCacheRequiredError
-            If no cache instance is configured.
         OpenMLHashException
             If checksum verification fails.
         """
-        if self.cache is None:
-            raise OpenMLCacheRequiredError(
-                "A cache object is required for download, but none was provided in the HTTPClient."
-            )
         base = self.cache.path
         file_path = base / "downloads" / urlparse(url).path.lstrip("/") / file_name
         file_path = file_path.expanduser()

tests/test_api/test_http.py

@@ -8,7 +8,6 @@
 from urllib.parse import urljoin
 from openml.enums import APIVersion
 from openml._api import HTTPClient
-from openml.exceptions import OpenMLCacheRequiredError
 
 
 class TestHTTPClient(TestAPIBase):
@@ -149,19 +148,6 @@ def test_post_and_delete(self):
         response = self.http_client.delete(f"task/{task_id}")
         self.assertEqual(response.status_code, 200)
 
-    def test_download_requires_cache(self):
-        client = HTTPClient(
-            server=self.http_client.server,
-            base_url=self.http_client.base_url,
-            api_key=self.http_client.api_key,
-            retries=1,
-            retry_policy=self.http_client.retry_policy,
-            cache=None,
-        )
-
-        with pytest.raises(OpenMLCacheRequiredError):
-            client.download("https://www.openml.org")
-
     @pytest.mark.uses_test_server()
     def test_download_creates_file(self):
         # small stable resource