remove old api calls from OpenMLRun classes

Author: Omswastik-11

openml/_api/resources/base/resources.py

@@ -114,6 +114,21 @@ def list(  # type: ignore[valid-type]  # noqa: PLR0913
         task_type: TaskType | int | None = None,
     ) -> pd.DataFrame: ...
 
+    @abstractmethod
+    def download_text_file(
+        self,
+        source: str,
+        *,
+        md5_checksum: str | None = None,
+    ) -> str: ...
+
+    @abstractmethod
+    def file_id_to_url(
+        self,
+        file_id: int,
+        filename: str | None = None,
+    ) -> str: ...
+
 
 class SetupAPI(ResourceAPI):
     """Abstract API interface for setup resources."""

openml/_api/resources/run.py

@@ -194,6 +194,30 @@ def _parse_list_xml(self, xml_string: str) -> pd.DataFrame:
         }
         return pd.DataFrame.from_dict(runs, orient="index")
 
+    def download_text_file(
+        self,
+        source: str,
+        *,
+        md5_checksum: str | None = None,
+    ) -> str:
+        response = self._http.get(
+            source,
+            use_api_key=False,
+            md5_checksum=md5_checksum,
+        )
+        return response.text
+
+    def file_id_to_url(
+        self,
+        file_id: int,
+        filename: str | None = None,
+    ) -> str:
+        server_base = self._http.server.split("/api/", 1)[0].rstrip("/")
+        url = f"{server_base}/data/download/{file_id}"
+        if filename is not None:
+            url += f"/{filename}"
+        return url
+
 
 class RunV2API(ResourceV2API, RunAPI):
     """V2 API resource for runs. Currently read-only until V2 server supports POST."""
@@ -248,3 +272,18 @@ def list(  # type: ignore[valid-type]  # noqa: PLR0913
             V2 server API not yet available for this operation.
         """
         self._not_supported(method="list")
+
+    def download_text_file(
+        self,
+        source: str,  # noqa: ARG002
+        *,
+        md5_checksum: str | None = None,  # noqa: ARG002
+    ) -> str:
+        self._not_supported(method="download_text_file")
+
+    def file_id_to_url(
+        self,
+        file_id: int,  # noqa: ARG002
+        filename: str | None = None,  # noqa: ARG002
+    ) -> str:
+        self._not_supported(method="file_id_to_url")

openml/runs/run.py

@@ -16,7 +16,6 @@
 import pandas as pd
 
 import openml
-import openml._api_calls
 from openml.base import OpenMLBase
 from openml.exceptions import PyOpenMLError
 from openml.flows import OpenMLFlow, get_flow
@@ -158,9 +157,7 @@ def predictions(self) -> pd.DataFrame:
             if self.data_content:
                 arff_dict = self._generate_arff_dict()
             elif self.predictions_url:
-                arff_text = openml._api_calls._download_text_file(self.predictions_url)
-                if arff_text is None:
-                    raise RuntimeError("Could not download predictions ARFF content.")
+                arff_text = openml._backend.run.download_text_file(self.predictions_url)
                 arff_dict = arff.loads(arff_text)
             else:
                 raise RuntimeError("Run has no predictions.")
@@ -532,14 +529,12 @@ def get_metric_fn(self, sklearn_fn: Callable, kwargs: dict | None = None) -> np.
         if self.data_content is not None and self.task_id is not None:
             predictions_arff = self._generate_arff_dict()
         elif (self.output_files is not None) and ("predictions" in self.output_files):
-            predictions_file_url = openml._api_calls._file_id_to_url(
+            predictions_file_url = openml._backend.run.file_id_to_url(
                 self.output_files["predictions"],
                 "predictions.arff",
             )
-            response = openml._api_calls._download_text_file(predictions_file_url)
-            if response is None:
-                raise ValueError("Could not download predictions ARFF content.")
-            predictions_arff = arff.loads(response)
+            predictions_text = openml._backend.run.download_text_file(predictions_file_url)
+            predictions_arff = arff.loads(predictions_text)
             # TODO: make this a stream reader
         else:
             raise ValueError(