Skip to content

Commit b8ced46

Browse files
committed
finalized instantiate setup check
1 parent 6fdba65 commit b8ced46

1 file changed

Lines changed: 7 additions & 17 deletions

File tree

tests/test_runs/test_run_functions.py

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import openml
44
import openml.exceptions
5-
import json
65

76
from openml.testing import TestBase
87
from openml.runs.functions import _run_task_get_arffcontent
@@ -39,22 +38,13 @@ def _perform_run(self, task_id, num_instances, clf, check_setup=True):
3938

4039
if check_setup:
4140
run_id = run_.run_id
42-
run_prime = openml.runs.get_run(run_id)
43-
clf_prime = openml.setups.initialize_model(run_prime.setup_id)
44-
45-
params_orig = clf.get_params()
46-
params_serv = clf_prime.get_params()
47-
self.assertEqual(params_orig.keys(), params_serv.keys())
48-
49-
for param in params_orig:
50-
print("%s : %s" %(param, str(params_serv[param])))
51-
try:
52-
value_orig = json.dumps(params_orig[param])
53-
value_serv = json.dumps(params_serv[param])
54-
self.assertEqual(value_orig, value_serv)
55-
except TypeError:
56-
# TODO: think of a different check
57-
print('Object not json serializable')
41+
run_server = openml.runs.get_run(run_id)
42+
clf_server = openml.setups.initialize_model(run_server.setup_id)
43+
44+
flow_local = openml.flows.sklearn_to_flow(clf)
45+
flow_server = openml.flows.sklearn_to_flow(clf_server)
46+
47+
openml.flows.assert_flows_equal(flow_local, flow_server)
5848

5949
#self.assertEquals(clf.get_params(), clf_prime.get_params())
6050
# self.assertEquals(clf, clf_prime)

0 commit comments

Comments
 (0)