Skip to content

Commit af8810d

Browse files
committed
update test_get_dataset_force_refresh_cache
1 parent 140830e commit af8810d

1 file changed

Lines changed: 11 additions & 8 deletions

File tree

tests/test_datasets/test_dataset_functions.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ def _check_datasets(self, datasets):
108108
for did in datasets:
109109
self._check_dataset(datasets[did])
110110

111+
def _get_cache_filename(self, id):
112+
return self.http_client.cache_path_from_url(f"data/{id}")
113+
111114
@pytest.mark.test_server()
112115
def test_tag_untag_dataset(self):
113116
tag = "test_tag_%d" % random.randint(1, 1000000)
@@ -462,26 +465,26 @@ def test__get_dataset_qualities(self):
462465

463466
@pytest.mark.test_server()
464467
def test_get_dataset_force_refresh_cache(self):
465-
cache_dir = openml.config.get_cache_directory()
466-
467468
openml.datasets.get_dataset(2)
468-
change_time = os.stat(cache_dir).st_mtime
469+
did_cache_file = self._get_cache_filename(2)
470+
change_time = os.stat(did_cache_file).st_mtime
469471

470472
# Test default
471473
openml.datasets.get_dataset(2)
472-
assert change_time == os.stat(cache_dir).st_mtime
474+
assert change_time == os.stat(did_cache_file).st_mtime
473475

474476
# Test refresh
475477
openml.datasets.get_dataset(2, force_refresh_cache=True)
476-
assert change_time != os.stat(cache_dir).st_mtime
478+
assert change_time != os.stat(did_cache_file).st_mtime
477479

478480
@pytest.mark.test_server()
479481
def test_get_dataset_force_refresh_cache_clean_start(self):
480-
did_cache_dir = os.path.join(openml.config.get_cache_directory(),"api","v1","xml","data","2","body.xml")
482+
with pytest.raises(FileNotFoundError):
483+
self._get_cache_filename(2)
481484

482-
# Test clean start
483485
openml.datasets.get_dataset(2, force_refresh_cache=True)
484-
assert os.path.exists(did_cache_dir)
486+
487+
assert self._get_cache_filename(2).exists()
485488

486489
def test_deletion_of_cache_dir(self):
487490
# Simple removal

0 commit comments

Comments
 (0)