update: cache_path_from_response -> cache_path_from_url

Author: geetu040

openml/_api/clients/http.py

@@ -842,10 +842,8 @@ def write_to_file(response: Response, path: Path, encoding: str) -> None:
         handler(response, file_path, encoding)
         return file_path
 
-    def cache_path_from_response(self, response: Response) -> Path:
-        url = response.url
-        url = urljoin(self.server, url)
-
-        key = self.cache.get_key(url, params={})
+    def cache_path_from_url(self, url: str) -> Path:
+        full_url = urljoin(self.server, url)
+        key = self.cache.get_key(full_url, params={})
         path = self.cache._key_to_path(key)
         return path / self.cache._get_body_filename_from_path(path)

openml/_api/resources/dataset.py

@@ -669,8 +669,8 @@ def _download_file(self, url_ext: str) -> Path:
         -------
         Path
         """
-        response = self._http.get(url_ext, enable_cache=True)
-        return self._http.cache_path_from_response(response)
+        self._http.get(url_ext, enable_cache=True)
+        return self._http.cache_path_from_url(url_ext)
 
     def download_features_file(self, dataset_id: int) -> Path:
         """Download features file.
@@ -776,8 +776,9 @@ def download_dataset_arff(
             raise TypeError("`description` should be either OpenMLDataset or Dict.")
 
         try:
-            response = self._http.get(url, enable_cache=True, md5_checksum=md5_checksum_fixture)
-            output_file_path = self._http.cache_path_from_response(response)
+            # save the file in cache and get it's path
+            self._http.get(url, enable_cache=True, md5_checksum=md5_checksum_fixture)
+            output_file_path = self._http.cache_path_from_url(url)
         except OpenMLHashException as e:
             additional_info = f" Raised when downloading dataset {did}."
             e.args = (e.args[0] + additional_info,)
@@ -1368,8 +1369,8 @@ def _download_file(self, url_ext: str) -> Path:
         -------
         Path
         """
-        response = self._http.get(url_ext, enable_cache=True)
-        return self._http.cache_path_from_response(response)
+        self._http.get(url_ext, enable_cache=True)
+        return self._http.cache_path_from_url(url_ext)
 
     def download_features_file(self, dataset_id: int) -> Path:
         """Download features file.
@@ -1471,8 +1472,9 @@ def download_dataset_arff(
             raise TypeError("`description` should be either OpenMLDataset or Dict.")
 
         try:
-            response = self._http.get(url, enable_cache=True)
-            output_file_path = self._http.cache_path_from_response(response)
+            # save the file in cache and get it's path
+            self._http.get(url, enable_cache=True)
+            output_file_path = self._http.cache_path_from_url(url)
         except OpenMLHashException as e:
             additional_info = f" Raised when downloading dataset {did}."
             e.args = (e.args[0] + additional_info,)