Skip to content

Commit 7b66677

Browse files
committed
remove "timeout_seconds" entirely
- removing this since it was not part of the sdk previously - some tests fail because of the timeout in stacked PRs - this option can easily be added if needed in future
1 parent 39bf86a commit 7b66677

5 files changed

Lines changed: 0 additions & 17 deletions

File tree

openml/_api/clients/http.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,15 +116,13 @@ def __init__( # noqa: PLR0913
116116
server: str,
117117
base_url: str,
118118
api_key: str,
119-
timeout_seconds: int,
120119
retries: int,
121120
retry_policy: RetryPolicy,
122121
cache: HTTPCache | None = None,
123122
) -> None:
124123
self.server = server
125124
self.base_url = base_url
126125
self.api_key = api_key
127-
self.timeout_seconds = timeout_seconds
128126
self.retries = retries
129127
self.retry_policy = retry_policy
130128
self.cache = cache
@@ -284,7 +282,6 @@ def _request( # noqa: PLR0913
284282
params: Mapping[str, Any],
285283
data: Mapping[str, Any],
286284
headers: Mapping[str, str],
287-
timeout: float | int,
288285
files: Mapping[str, Any] | None,
289286
**request_kwargs: Any,
290287
) -> tuple[Response | None, Exception | None]:
@@ -298,7 +295,6 @@ def _request( # noqa: PLR0913
298295
params=params,
299296
data=data,
300297
headers=headers,
301-
timeout=timeout,
302298
files=files,
303299
**request_kwargs,
304300
)
@@ -346,7 +342,6 @@ def request(
346342
headers = request_kwargs.pop("headers", {}).copy()
347343
headers.update(self.headers)
348344

349-
timeout = request_kwargs.pop("timeout", self.timeout_seconds)
350345
files = request_kwargs.pop("files", None)
351346

352347
if use_cache and not reset_cache and self.cache is not None:
@@ -367,7 +362,6 @@ def request(
367362
params=params,
368363
data=data,
369364
headers=headers,
370-
timeout=timeout,
371365
files=files,
372366
**request_kwargs,
373367
)

openml/_api/setup/builder.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ def build(cls, config: Config) -> APIBackendBuilder:
3939
server=primary_api_config.server,
4040
base_url=primary_api_config.base_url,
4141
api_key=primary_api_config.api_key,
42-
timeout_seconds=config.connection.timeout_seconds,
4342
retries=config.connection.retries,
4443
retry_policy=config.connection.retry_policy,
4544
cache=http_cache,
@@ -57,7 +56,6 @@ def build(cls, config: Config) -> APIBackendBuilder:
5756
server=fallback_api_config.server,
5857
base_url=fallback_api_config.base_url,
5958
api_key=fallback_api_config.api_key,
60-
timeout_seconds=config.connection.timeout_seconds,
6159
retries=config.connection.retries,
6260
retry_policy=config.connection.retry_policy,
6361
cache=http_cache,

openml/_api/setup/config.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ class APIConfig:
1919
class ConnectionConfig:
2020
retries: int
2121
retry_policy: RetryPolicy
22-
timeout_seconds: int
2322

2423

2524
@dataclass
@@ -52,7 +51,6 @@ class Config:
5251
default_factory=lambda: ConnectionConfig(
5352
retries=5,
5453
retry_policy=RetryPolicy.HUMAN,
55-
timeout_seconds=10,
5654
)
5755
)
5856

openml/testing.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ class TestAPIBase(unittest.TestCase):
286286
server: str
287287
base_url: str
288288
api_key: str
289-
timeout_seconds: int
290289
retries: int
291290
retry_policy: RetryPolicy
292291
dir: str
@@ -298,7 +297,6 @@ def setUp(self) -> None:
298297
self.server = "https://test.openml.org/"
299298
self.base_url = "api/v1/xml"
300299
self.api_key = "normaluser"
301-
self.timeout_seconds = 10
302300
self.retries = 3
303301
self.retry_policy = RetryPolicy.HUMAN
304302
self.dir = "test_cache"
@@ -312,7 +310,6 @@ def setUp(self) -> None:
312310
server=self.server,
313311
base_url=self.base_url,
314312
api_key=self.api_key,
315-
timeout_seconds=self.timeout_seconds,
316313
retries=self.retries,
317314
retry_policy=self.retry_policy,
318315
cache=self.cache,
@@ -341,7 +338,6 @@ def _get_http_client( # noqa: PLR0913
341338
server: str,
342339
base_url: str,
343340
api_key: str,
344-
timeout_seconds: int,
345341
retries: int,
346342
retry_policy: RetryPolicy,
347343
cache: HTTPCache | None = None,
@@ -350,7 +346,6 @@ def _get_http_client( # noqa: PLR0913
350346
server=server,
351347
base_url=base_url,
352348
api_key=api_key,
353-
timeout_seconds=timeout_seconds,
354349
retries=retries,
355350
retry_policy=retry_policy,
356351
cache=cache,

tests/test_api/test_versions.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ def setUp(self):
6565
server=self.server,
6666
base_url=self.base_url,
6767
api_key=self.api_key,
68-
timeout_seconds=self.timeout_seconds,
6968
retries=self.retries,
7069
retry_policy=self.retry_policy,
7170
cache=self.cache,
@@ -92,7 +91,6 @@ def setUp(self):
9291
server="",
9392
base_url="",
9493
api_key="",
95-
timeout_seconds=self.timeout_seconds,
9694
retries=self.retries,
9795
retry_policy=self.retry_policy,
9896
cache=self.cache,

0 commit comments

Comments
 (0)