Skip to content

Commit 419edcb

Browse files
committed
move _HEADERS to confing
1 parent 76b92bb commit 419edcb

4 files changed

Lines changed: 7 additions & 18 deletions

File tree

openml/_api/clients/http.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
from requests import Response
1818

1919
import openml
20-
from openml.__version__ import __version__
2120
from openml.enums import APIVersion, RetryPolicy
2221
from openml.exceptions import (
2322
OpenMLAuthenticationError,
@@ -27,8 +26,6 @@
2726
OpenMLServerNoResult,
2827
)
2928

30-
_HEADERS: dict[str, str] = {"user-agent": f"openml-python/{__version__}"}
31-
3229

3330
class HTTPCache:
3431
"""
@@ -236,10 +233,6 @@ def retry_policy(self) -> RetryPolicy:
236233
def retry_func(self) -> Callable:
237234
return self._human_delay if self.retry_policy == RetryPolicy.HUMAN else self._robot_delay
238235

239-
@property
240-
def headers(self) -> dict[str, str]:
241-
return _HEADERS
242-
243236
def _robot_delay(self, n: int) -> float:
244237
"""
245238
Compute delay for automated retry policy.
@@ -594,7 +587,7 @@ def _request( # noqa: PLR0913, C901
594587

595588
# prepare headers
596589
headers = request_kwargs.pop("headers", {}).copy()
597-
headers.update(_HEADERS)
590+
headers.update(openml.config._HEADERS)
598591

599592
files = request_kwargs.pop("files", None)
600593

openml/_api/clients/minio.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
from pathlib import Path
44

55
import openml
6-
from openml.__version__ import __version__
7-
8-
_HEADERS: dict[str, str] = {"user-agent": f"openml-python/{__version__}"}
96

107

118
class MinIOClient:
@@ -29,7 +26,3 @@ class MinIOClient:
2926
@property
3027
def path(self) -> Path:
3128
return Path(openml.config.get_cache_directory())
32-
33-
@property
34-
def headers(self) -> dict[str, str]:
35-
return _HEADERS

openml/_config.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121

2222
from openml.enums import APIVersion
2323

24+
from .__version__ import __version__
25+
2426
logger = logging.getLogger(__name__)
2527
openml_logger = logging.getLogger("openml")
2628

@@ -141,6 +143,7 @@ def __init__(self) -> None:
141143
self.OPENML_CACHE_DIR_ENV_VAR = "OPENML_CACHE_DIR"
142144
self.OPENML_SKIP_PARQUET_ENV_VAR = "OPENML_SKIP_PARQUET"
143145
self._TEST_SERVER_NORMAL_USER_KEY = server_test_v1_apikey
146+
self._HEADERS: dict[str, str] = {"user-agent": f"openml-python/{__version__}"}
144147
self.OPENML_TEST_SERVER_ADMIN_KEY_ENV_VAR = "OPENML_TEST_SERVER_ADMIN_KEY"
145148
self.TEST_SERVER_URL = cast("str", server_test_v1_server).split("/api/v1/xml")[0]
146149

@@ -176,6 +179,7 @@ def __setattr__(self, name: str, value: Any) -> None:
176179
"OPENML_CACHE_DIR_ENV_VAR",
177180
"OPENML_SKIP_PARQUET_ENV_VAR",
178181
"_TEST_SERVER_NORMAL_USER_KEY",
182+
"_HEADERS",
179183
}:
180184
return object.__setattr__(self, name, value)
181185

tests/test_api/test_http.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from requests import Response, Request, Session
22
from unittest.mock import patch
33
import pytest
4-
from openml.testing import TestBase
54
import os
65
from pathlib import Path
76
from urllib.parse import urljoin, urlparse
@@ -209,7 +208,7 @@ def test_post(http_client):
209208
url=urljoin(openml.config.server, resource_name),
210209
params={},
211210
data={"api_key": openml.config.apikey},
212-
headers=http_client.headers,
211+
headers=openml.config._HEADERS,
213212
files=resource_files,
214213
)
215214

@@ -234,6 +233,6 @@ def test_delete(http_client):
234233
),
235234
params={"api_key": openml.config.apikey},
236235
data={},
237-
headers=http_client.headers,
236+
headers=openml.config._HEADERS,
238237
files=None,
239238
)

0 commit comments

Comments
 (0)