remove cache.ttl

Author: geetu040

openml/_api/clients/http.py

@@ -44,19 +44,15 @@ class HTTPCache:
     ----------
     path : pathlib.Path
         Base directory where cache entries are stored.
-    ttl : int
-        Time-to-live in seconds. Cached entries older than this value are treated
-        as expired.
 
     Notes
     -----
     The cache key is derived from the URL (domain and path components) and query
     parameters, excluding the ``api_key`` parameter.
     """
 
-    def __init__(self, *, path: Path, ttl: int) -> None:
+    def __init__(self, *, path: Path) -> None:
         self.path = path
-        self.ttl = ttl
 
     def get_key(self, url: str, params: dict[str, Any]) -> str:
         """
@@ -144,9 +140,6 @@ def load(self, key: str) -> Response:
         if created_at is None:
             raise ValueError("Cache metadata missing 'created_at'")
 
-        if time.time() - created_at > self.ttl:
-            raise TimeoutError(f"Cache expired for {path}")
-
         with headers_path.open("r", encoding="utf-8") as f:
             headers = json.load(f)
 

openml/_api/setup/builder.py

@@ -84,7 +84,7 @@ def build(cls, config: Config) -> APIBackendBuilder:
         """
         cache_dir = Path(config.cache.dir).expanduser()
 
-        http_cache = HTTPCache(path=cache_dir, ttl=config.cache.ttl)
+        http_cache = HTTPCache(path=cache_dir)
         minio_client = MinIOClient(path=cache_dir)
 
         primary_api_config = config.api_configs[config.api_version]

openml/_api/setup/config.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 from dataclasses import dataclass, field
-from datetime import timedelta
 
 from openml.enums import APIVersion, RetryPolicy
 
@@ -54,12 +53,9 @@ class CacheConfig:
     ----------
     dir : str
         Path to the directory where cached files will be stored.
-    ttl : int
-        Time-to-live for cached entries, in seconds.
     """
 
     dir: str
-    ttl: int
 
 
 @dataclass
@@ -111,6 +107,5 @@ class Config:
     cache: CacheConfig = field(
         default_factory=lambda: CacheConfig(
             dir=str(_resolve_default_cache_dir()),
-            ttl=int(timedelta(weeks=1).total_seconds()),
         )
     )

openml/testing.py

@@ -291,12 +291,10 @@ def setUp(self, n_levels: int = 1, tmpdir_suffix: str = "") -> None:
 
         retries = self.connection_n_retries
         retry_policy = RetryPolicy.HUMAN if self.retry_policy == "human" else RetryPolicy.ROBOT
-        ttl = openml._backend.get_config_value("cache.ttl")
         cache_dir = self.static_cache_dir
 
         self.cache = HTTPCache(
             path=cache_dir,
-            ttl=ttl,
         )
         self.http_clients = {
             APIVersion.V1: HTTPClient(

tests/test_api/test_http.py

@@ -105,29 +105,6 @@ def test_get_uses_cached_response(self):
         self.assertEqual(response1.content, response2.content)
         self.assertEqual(response1.status_code, response2.status_code)
 
-    @pytest.mark.uses_test_server()
-    def test_get_cache_expires(self):
-        # force short TTL
-        self.cache.ttl = 1
-        path = "task/1"
-
-        url = self._prepare_url(path=path)
-        key = self.cache.get_key(url, {})
-        cache_path = self.cache._key_to_path(key) / "meta.json"
-
-        response1 = self.http_client.get(path, use_cache=True)
-        response1_cache_time_stamp = cache_path.stat().st_ctime
-
-        time.sleep(2)
-
-        response2 = self.http_client.get(path, use_cache=True)
-        response2_cache_time_stamp = cache_path.stat().st_ctime
-
-        # cache expired -> new request
-        self.assertNotEqual(response1_cache_time_stamp, response2_cache_time_stamp)
-        self.assertEqual(response2.status_code, 200)
-        self.assertEqual(response1.content, response2.content)
-
     @pytest.mark.uses_test_server()
     def test_get_reset_cache(self):
         path = "task/1"