tiny updates to study PR (#628)

Author: janvanrijn

tests/test_runs/test_run_functions.py

@@ -456,8 +456,7 @@ def determine_grid_size(param_grid):
             # suboptimal (slow), and not guaranteed to work if evaluation
             # engine is behind.
             # TODO: mock this? We have the arff already on the server
-            print(run.run_id)
-            self._wait_for_processed_run(run.run_id, 10)
+            self._wait_for_processed_run(run.run_id, 200)
             try:
                 model_prime = openml.runs.initialize_model_from_trace(
                     run.run_id, 0, 0)

tests/test_study/test_study_functions.py

@@ -131,3 +131,31 @@ def test_publish_study(self):
 
         res = openml.study.delete_study(study_id)
         self.assertTrue(res)
+
+    def test_study_attach_illegal(self):
+        run_list = openml.runs.list_runs(size=10)
+        self.assertEqual(len(run_list), 10)
+        run_list_more = openml.runs.list_runs(size=20)
+        self.assertEqual(len(run_list_more), 20)
+
+        study = openml.study.create_study(
+            alias=None,
+            benchmark_suite=None,
+            name='study with illegal runs',
+            description='none',
+            run_ids=list(run_list.keys())
+        )
+        study_id = study.publish()
+        study_original = openml.study.get_study(study_id)
+
+        with self.assertRaisesRegex(openml.exceptions.OpenMLServerException, 
+                                    'Problem attaching entities.'):
+            # run id does not exists
+            openml.study.attach_to_study(study_id, [0])
+
+        with self.assertRaisesRegex(openml.exceptions.OpenMLServerException, 
+                                    'Problem attaching entities.'):
+            # some runs already attached
+            openml.study.attach_to_study(study_id, list(run_list_more.keys()))
+        study_downloaded = openml.study.get_study(study_id)
+        self.assertListEqual(study_original.runs, study_downloaded.runs)

tests/test_utils/test_utils.py

@@ -46,7 +46,9 @@ def test_list_datasets_with_high_size_parameter(self):
         datasets_a = openml.datasets.list_datasets()
         datasets_b = openml.datasets.list_datasets(size=np.inf)
 
-        self.assertEqual(len(datasets_a), len(datasets_b))
+        # note that in the meantime the number of datasets could have increased
+        # due to tests that run in parralel. 
+        self.assertGreaterEqual(len(datasets_b), len(datasets_a))
 
     def test_list_all_for_tasks(self):
         required_size = 1068  # default test server reset value