reviews updated

Author: JATAYU000

openml/_api/resources/base/resources.py

@@ -6,15 +6,15 @@
 from pathlib import Path
 from typing import TYPE_CHECKING, Any, Literal
 
-if TYPE_CHECKING:
-    import pandas as pd
-
-    from openml.datasets.dataset import OpenMLDataFeature, OpenMLDataset
 from openml.enums import ResourceType
 
 from .base import ResourceAPI
 
 if TYPE_CHECKING:
+    import pandas as pd
+
+    from openml.datasets.data_feature import OpenMLDataFeature
+    from openml.datasets.dataset import OpenMLDataset
     from openml.estimation_procedures import OpenMLEstimationProcedure
     from openml.evaluations import OpenMLEvaluation
     from openml.flows.flow import OpenMLFlow
@@ -88,12 +88,12 @@ def get_qualities(self, dataset_id: int) -> dict[str, float] | None: ...
 
     @abstractmethod
     def parse_features_file(
-        self, features_file: Path, features_pickle_file: Path
+        self, features_file: Path, features_pickle_file: Path | None = None
     ) -> dict[int, OpenMLDataFeature]: ...
 
     @abstractmethod
     def parse_qualities_file(
-        self, qualities_file: Path, qualities_pickle_file: Path
+        self, qualities_file: Path, qualities_pickle_file: Path | None = None
     ) -> dict[str, float]: ...
 
     @abstractmethod

openml/_api/resources/dataset.py

@@ -1505,7 +1505,7 @@ def get_online_dataset_format(self, dataset_id: int) -> str:
         """
         dataset_json = self._http.get(f"datasets/{dataset_id}").json()
         # build a dict from the json and get the format from the dataset description
-        return dataset_json["data_set_description"]["format"].lower()  # type: ignore
+        return dataset_json["format"].lower()  # type: ignore
 
     def get_online_dataset_arff(self, dataset_id: int) -> str | None:
         """Download the ARFF file for a given dataset id

tests/test_runs/test_run_functions.py

@@ -1969,7 +1969,7 @@ def test__run_task_get_arffcontent_2(parallel_mock):
     ]
 )
 @pytest.mark.test_server()
-def test_joblib_backends(parallel_mock, n_jobs, backend, call_count, tmp_path):
+def test_joblib_backends(parallel_mock, n_jobs, backend, call_count):
     """Tests evaluation of a run using various joblib backends and n_jobs."""
 
     if backend is None: