Merge pull request #1304 from Arnei/prefer-const

Activate eslint prefer-const

Author: Arnei

eslint.config.js

@@ -16,7 +16,9 @@ export default [
             "max-len": "off",
             "no-tabs": "off",
             "no-unused-expressions": "off",
-            "prefer-const": "off",
+            "object-curly-spacing": "off",
+            "quotes": "off",
+            "semi": "off",
             "spaced-comment": "off",
             "@typescript-eslint/await-thenable": "off",
             "@typescript-eslint/no-explicit-any": "off",

src/components/configuration/Themes.tsx

@@ -51,7 +51,7 @@ const Themes = () => {
 		loadThemes();
 
 		// Fetch themes every minute
-		let fetchThemesInterval = setInterval(loadThemes, 5000);
+		const fetchThemesInterval = setInterval(loadThemes, 5000);
 
 		return () => {
 			allowLoadIntoTable = false;

src/components/events/Events.tsx

@@ -61,7 +61,7 @@ const Events = () => {
 	const events = useAppSelector(state => getTotalEvents(state));
 	const isFetchingAssetUploadOptions = useAppSelector(state => getIsFetchingAssetUploadOptions(state));
 
-	let location = useLocation();
+	const location = useLocation();
 
 	useEffect(() => {
 		// State variable for interrupting the load function
@@ -92,7 +92,7 @@ const Events = () => {
 		loadEvents();
 
 		// Fetch events every five seconds
-		let fetchEventsInterval = setInterval(() => loadEvents(), 5000);
+		const fetchEventsInterval = setInterval(() => loadEvents(), 5000);
 
 		return () => {
 			allowLoadIntoTable = false;

src/components/events/Series.tsx

@@ -39,7 +39,7 @@ const Series = () => {
 	const newSeriesModalRef = useRef<ModalHandle>(null);
 	const deleteModalRef = useRef<ModalHandle>(null);
 
-	let location = useLocation();
+	const location = useLocation();
 
 	const series = useAppSelector(state => getTotalSeries(state));
 	const showActions = useAppSelector(state => isShowActions(state));
@@ -72,7 +72,7 @@ const Series = () => {
 		loadSeries();
 
 		// Fetch series every minute
-		let fetchSeriesInterval = setInterval(() => loadSeries(), 5000);
+		const fetchSeriesInterval = setInterval(() => loadSeries(), 5000);
 
 		return () => {
 			allowLoadIntoTable = false;

src/components/events/partials/EventsDateCell.tsx

@@ -24,13 +24,13 @@ const EventsDateCell = ({
 
 	// Filter with value of current cell
 	const addFilter = async (date: string) => {
-		let filter = filterMap.find(({ name }) => name === "startDate");
+		const filter = filterMap.find(({ name }) => name === "startDate");
 		if (filter) {
-			let startDate = new Date(date);
+			const startDate = new Date(date);
 			startDate.setHours(0);
 			startDate.setMinutes(0);
 			startDate.setSeconds(0);
-			let endDate = new Date(date);
+			const endDate = new Date(date);
 			endDate.setHours(23);
 			endDate.setMinutes(59);
 			endDate.setSeconds(59);

src/components/events/partials/EventsLocationCell.tsx

@@ -21,9 +21,9 @@ const EventsLocationCell = ({
 
 	// Filter with value of current cell
 	const addFilter = (location: string) => {
-		let filter = filterMap.find(({ name }) => name === "location");
+		const filter = filterMap.find(({ name }) => name === "location");
 		if (filter) {
-			dispatch(editFilterValue({ filterName: filter.name, value: location }));
+			dispatch(editFilterValue({filterName: filter.name, value: location}));
 			dispatch(fetchEvents());
 			dispatch(loadEventsIntoTable());
 		}

src/components/events/partials/EventsPresentersCell.tsx

@@ -21,7 +21,7 @@ const EventsPresentersCell = ({
 
 	// Filter with value of current cell
 	const addFilter = async (presenter: string) => {
-		let filter = filterMap.find(
+		const filter = filterMap.find(
 			({ name }) => name === "presentersBibliographic",
 		);
 		if (filter) {

src/components/events/partials/EventsSeriesCell.tsx

@@ -21,9 +21,9 @@ const EventsSeriesCell = ({
 
 	// Filter with value of current cell
 	const addFilter = async (seriesId: string) => {
-		let filter = filterMap.find(({ name }) => name === "series");
+		const filter = filterMap.find(({ name }) => name === "series");
 		if (filter) {
-			await dispatch(editFilterValue({ filterName: filter.name, value: seriesId }));
+			await dispatch(editFilterValue({filterName: filter.name, value: seriesId}));
 			await dispatch(fetchEvents());
 			dispatch(loadEventsIntoTable());
 		}

src/components/events/partials/EventsTechnicalDateCell.tsx

@@ -24,9 +24,9 @@ const EventsTechnicalDateCell = ({
 
 	// Filter with value of current cell
 	const addFilter = async (date: string) => {
-		let filter = filterMap.find(({ name }) => name === "technicalStart");
+		const filter = filterMap.find(({ name }) => name === "technicalStart");
 		if (filter) {
-			await dispatch(editFilterValue({ filterName: filter.name, value: date + "/" + date }));
+			await dispatch(editFilterValue({filterName: filter.name, value: date + "/" + date}));
 			await dispatch(fetchEvents());
 			dispatch(loadEventsIntoTable());
 		}

src/components/events/partials/ModalTabsAndPages/DetailsMetadataTab.tsx

@@ -56,7 +56,7 @@ const DetailsMetadataTab = ({
 
 	// set current values of metadata fields as initial values
 	const getInitialValues = (metadataCatalog: MetadataCatalog) => {
-		let initialValues: { [key: string]: any } = {};
+		const initialValues: { [key: string]: any } = {};
 
 		// Transform metadata fields and their values provided by backend (saved in redux)
 		metadataCatalog.fields.forEach(field => {