Merge pull request #1303 from Arnei/no-unused-expressions

Activate eslint no-unused-expressions

Author: Arnei

eslint.config.js

@@ -15,7 +15,6 @@ export default [
             "indent": "off",
             "max-len": "off",
             "no-tabs": "off",
-            "no-unused-expressions": "off",
             "object-curly-spacing": "off",
             "quotes": "off",
             "semi": "off",
@@ -29,8 +28,7 @@ export default [
             "@typescript-eslint/no-unsafe-assignment": "off",
             "@typescript-eslint/no-unsafe-call": "off",
             "@typescript-eslint/no-unsafe-member-access": "off",
-            "@typescript-eslint/no-unused-expressions": "off",
-            // "@typescript-eslint/no-unused-vars": "off",
+            "@typescript-eslint/no-unused-vars": "off",
             "@typescript-eslint/no-unsafe-return": "off",
             "@typescript-eslint/require-await": "off",
             "@typescript-eslint/unbound-method": "off",

src/components/NavBar.tsx

@@ -52,13 +52,11 @@ const NavBar = ({
 	const newResourceModalRef = useRef<ModalHandle>(null);
 
 	const showNewResourceModal = async () => {
-		create && create.onShowModal && await create.onShowModal();
-		newResourceModalRef.current?.open();
+		newResourceModalRef.current?.open()
 	};
 
 	const hideNewResourceModal = () => {
-		create && create.onHideModal && create.onHideModal();
-		newResourceModalRef.current?.close?.();
+		newResourceModalRef.current?.close?.()
 	};
 
 	const toggleNavigation = () => {

src/components/events/partials/ModalTabsAndPages/EditScheduledEventsEditPage.tsx

@@ -157,7 +157,7 @@ const EditScheduledEventsEditPage = <T extends RequiredFormProps>({
 				{/* Repeat table for each selected event */}
 				{!loading && (
 					<FieldArray name="editedEvents">
-						{/* eslint-disable-next-line @typescript-eslint/no-unused-vars */}
+						{ }
 						{({ insert, remove, push }) => (
 							<>
 							{hasAccess(

src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx

@@ -261,7 +261,7 @@ const Upload = <T extends RequiredFormPropsUpload>({
 						<tbody>
 							<FieldArray name="uploadAssetsTrack">
 								{/*File upload button for each upload asset*/}
-								{/* eslint-disable-next-line @typescript-eslint/no-unused-vars */}
+								{ }
 								{({ insert, remove, push }) =>
 									formik.values.uploadAssetsTrack &&
 									formik.values.uploadAssetsTrack.length > 0 &&
@@ -404,17 +404,21 @@ const Schedule = <T extends {
 									selected={typeof formik.values.scheduleStartDate === "string" ? parseISO(formik.values.scheduleStartDate) : formik.values.scheduleStartDate}
 									onChange={value => {
 										if (formik.values.sourceMode === "SCHEDULE_MULTIPLE") {
-											value && changeStartDateMultiple(
-												value,
-												formik.values,
-												formik.setFieldValue,
-											);
+											if (value) {
+												changeStartDateMultiple(
+													value,
+													formik.values,
+													formik.setFieldValue,
+												);
+											}
 										} else {
-											value && changeStartDate(
-												value,
-												formik.values,
-												formik.setFieldValue,
-											);
+											if (value) {
+												changeStartDate(
+													value,
+													formik.values,
+													formik.setFieldValue,
+												);
+											}
 										}
 									}}
 									showYearDropdown

src/components/shared/NavigationButtons.tsx

@@ -39,7 +39,9 @@ const NavigationButtons = ({
 					className={cn(submitClassName, submitActiveClassName)}
 					disabled={disabled}
 					onClick={() => {
-						nextPage?.();
+						if (nextPage) {
+							nextPage()
+						}
 					}}
 					tabIndex={100}
 				>
@@ -51,7 +53,9 @@ const NavigationButtons = ({
 					className={cn(submitClassName, submitActiveClassName)}
 					disabled={disabled}
 					onClick={() => {
-						nextPage?.();
+						if (nextPage) {
+							nextPage();
+						}
 					}}
 					tabIndex={100}
 				>
@@ -62,7 +66,9 @@ const NavigationButtons = ({
 				<button
 					className="cancel"
 					onClick={() => {
-						previousPage?.();
+						if (previousPage) {
+							previousPage()
+						}
 					}}
 					tabIndex={101}
 				>

src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx

@@ -122,10 +122,12 @@ const ResourceDetailsAccessPolicyTab = ({
 			await dispatch(fetchAccessPolicies(resourceId));
 			fetchRolesWithTarget("ACL").then(roles => setRoles(roles));
 			if (fetchHasActiveTransactions) {
-				const fetchTransactionResult = await dispatch(fetchHasActiveTransactions(resourceId)).then(unwrapResult);
-				fetchTransactionResult.active !== undefined
-					? setTransactions({ read_only: fetchTransactionResult.active })
-					: setTransactions({ read_only: true });
+				const fetchTransactionResult = await dispatch(fetchHasActiveTransactions(resourceId)).then(unwrapResult)
+				if (fetchTransactionResult.active !== undefined) {
+					setTransactions({ read_only: fetchTransactionResult.active })
+				} else {
+					setTransactions({ read_only: true });
+				}
 				if (
 					fetchTransactionResult.active === undefined ||
 					fetchTransactionResult.active

src/components/shared/wizard/RenderField.tsx

@@ -39,8 +39,12 @@ const RenderField = ({
 		<div
 			onClick={() => {
 				if (editableRef.current) {
-					editableRef.current.focus && editableRef.current.focus();
-					editableRef.current.setFocus && editableRef.current.setFocus(); // For DatePicker
+					if (editableRef.current.focus) {
+						editableRef.current.focus()
+					}
+					if (editableRef.current.setFocus) {
+						editableRef.current.setFocus() // For DatePicker
+					}
 				}
 			}}
 			onFocus={onFocus}

src/components/shared/wizard/WizardNavigationButtons.tsx

@@ -39,11 +39,25 @@ const WizardNavigationButtons = <T, >({
 			isSubmitDisabled={disabled}
 			nextPage={
 				isLast
-				? () => { submitPage ? submitPage() : formik.handleSubmit(); }
-				: () => { !!nextPage && nextPage(formik.values); }
+				? () => {
+					if (submitPage) {
+						submitPage()
+					 } else {
+						formik.handleSubmit();
+					 }
+				}
+				: () => {
+					if (nextPage) {
+						nextPage(formik.values);
+					}
+				}
 			}
 			previousPage={
-				() => { !!previousPage && previousPage(formik.values); }
+				() => {
+					if (previousPage) {
+						previousPage(formik.values)
+					}
+				}
 			}
 			nextTranslationString={
 				isLast

src/slices/eventDetailsSlice.ts

@@ -1337,7 +1337,9 @@ export const performWorkflowAction = createAppAsyncThunk("eventDetails/performWo
 					context: NOTIFICATION_CONTEXT,
 				}),
 			);
-			close && close();
+			if (close) {
+				close();
+			}
 		})
 		.catch(response => {
 			dispatch(

src/utils/resourceUtils.ts

@@ -88,10 +88,18 @@ export const buildUserBody = (values: NewUser | UpdateUser) => {
 	const data = new URLSearchParams();
 	// fill form data with user inputs
 	data.append("username", values.username);
-	values.name && data.append("name", values.name);
-	values.email && data.append("email", values.email);
-	values.password && data.append("password", values.password);
-	values.roles && data.append("roles", JSON.stringify(values.roles));
+	if (values.name) {
+		data.append("name", values.name);
+	}
+	if (values.email) {
+		data.append("email", values.email);
+	}
+	if (values.password) {
+		data.append("password", values.password);
+	}
+	if (values.roles) {
+		data.append("roles", JSON.stringify(values.roles));
+	}
 
 	return data;
 };