Activate eslint no-extra-boolean-cast

Arnei · Arnei · commit bb765c00d6e0 · 2025-05-23T11:41:41.000+02:00
Enables the eslint rule no-extra-boolean-cast.
diff --git a/eslint.config.js b/eslint.config.js
@@ -17,7 +17,6 @@ export default [
             "indent": "off",
             "keyword-spacing": "off",
             "max-len": "off",
-            "no-extra-boolean-cast": "off",
             "no-tabs": "off",
             "no-unused-expressions": "off",
             "object-curly-spacing": "off",
diff --git a/src/components/events/partials/EventActionCell.tsx b/src/components/events/partials/EventActionCell.tsx
@@ -52,7 +52,7 @@ const EventActionCell = ({
 	};
 
 	const onClickSeriesDetails = async () => {
-		if (!!row.series) {
+		if (row.series) {
 			await dispatch(fetchSeriesDetailsMetadata(row.series.id));
 			await dispatch(fetchSeriesDetailsAcls(row.series.id));
 			await dispatch(fetchSeriesDetailsTheme(row.series.id));
diff --git a/src/components/events/partials/EventsDateCell.tsx b/src/components/events/partials/EventsDateCell.tsx
@@ -25,7 +25,7 @@ const EventsDateCell = ({
 	// Filter with value of current cell
 	const addFilter = async (date: string) => {
 		let filter = filterMap.find(({ name }) => name === "startDate");
-		if (!!filter) {
+		if (filter) {
 			let startDate = new Date(date);
 			startDate.setHours(0);
 			startDate.setMinutes(0);
diff --git a/src/components/events/partials/EventsLocationCell.tsx b/src/components/events/partials/EventsLocationCell.tsx
@@ -22,7 +22,7 @@ const EventsLocationCell = ({
 	// Filter with value of current cell
 	const addFilter = (location: string) => {
 		let filter = filterMap.find(({ name }) => name === "location");
-		if (!!filter) {
+		if (filter) {
 			dispatch(editFilterValue({filterName: filter.name, value: location}));
 			dispatch(fetchEvents());
 			dispatch(loadEventsIntoTable());
diff --git a/src/components/events/partials/EventsPresentersCell.tsx b/src/components/events/partials/EventsPresentersCell.tsx
@@ -24,7 +24,7 @@ const EventsPresentersCell = ({
 		let filter = filterMap.find(
 			({ name }) => name === "presentersBibliographic"
 		);
-		if (!!filter) {
+		if (filter) {
 			await dispatch(editFilterValue({filterName: filter.name, value: presenter}));
 			await dispatch(fetchEvents());
 			dispatch(loadEventsIntoTable());
diff --git a/src/components/events/partials/EventsSeriesCell.tsx b/src/components/events/partials/EventsSeriesCell.tsx
@@ -22,15 +22,15 @@ const EventsSeriesCell = ({
 	// Filter with value of current cell
 	const addFilter = async (seriesId: string) => {
 		let filter = filterMap.find(({ name }) => name === "series");
-		if (!!filter) {
+		if (filter) {
 			await dispatch(editFilterValue({filterName: filter.name, value: seriesId}));
 			await dispatch(fetchEvents());
 			dispatch(loadEventsIntoTable());
 		}
 	};
 
 	return (
-		!!row.series ? (
+		row.series ? (
 			// Link template for series of event
 			<IconButton
 				callback={() => row.series
diff --git a/src/components/events/partials/EventsTechnicalDateCell.tsx b/src/components/events/partials/EventsTechnicalDateCell.tsx
@@ -25,7 +25,7 @@ const EventsTechnicalDateCell = ({
 	// Filter with value of current cell
 	const addFilter = async (date: string) => {
 		let filter = filterMap.find(({ name }) => name === "technicalStart");
-		if (!!filter) {
+		if (filter) {
 			await dispatch(editFilterValue({filterName: filter.name, value: date + "/" + date}));
 			await dispatch(fetchEvents());
 			dispatch(loadEventsIntoTable());
diff --git a/src/components/events/partials/ModalTabsAndPages/DetailsTobiraTab.tsx b/src/components/events/partials/ModalTabsAndPages/DetailsTobiraTab.tsx
@@ -115,7 +115,7 @@ const DetailsTobiraTab = ({ kind, id }: DetailsTobiraTabProps) => {
 	}
 
 	const openSubTab = async (tabType: TobiraTabHierarchy, currentPage?: TobiraPage) => {
-		if (!!currentPage) {
+		if (currentPage) {
 			const breadcrumbs = getBreadcrumbs(currentPage);
 			// Breadcrumbs always include at least the homepage, so the length is at least 1.
 			const hostPage = breadcrumbs[breadcrumbs.length - 1];
diff --git a/src/components/events/partials/ModalTabsAndPages/EventDetailsAssetMediaDetails.tsx b/src/components/events/partials/ModalTabsAndPages/EventDetailsAssetMediaDetails.tsx
@@ -101,7 +101,7 @@ const EventDetailsAssetMediaDetails = () => {
 										}
 									</td>
 									<td>
-										{!!media.duration
+										{media.duration
 											? formatDuration(media.duration)
 											: null}
 									</td>
diff --git a/src/components/events/partials/ModalTabsAndPages/EventDetailsPublicationTab.tsx b/src/components/events/partials/ModalTabsAndPages/EventDetailsPublicationTab.tsx
@@ -49,7 +49,7 @@ const EventDetailsPublicationTab = ({
 										<li key={key}>
 											<div className="v-container">
 												<span className="icon-container">
-													{!!publication.icon ? (
+													{publication.icon ? (
 														<i
 															className="custom-icon"
 															style={{
diff --git a/src/components/events/partials/ModalTabsAndPages/EventDetailsSchedulingTab.tsx b/src/components/events/partials/ModalTabsAndPages/EventDetailsSchedulingTab.tsx
@@ -125,11 +125,11 @@ const EventDetailsSchedulingTab = ({
 	// finds the inputs to be displayed in the formik
 	const getInputs = (deviceId: Recording["id"]) => {
 		if (deviceId === source.device.id) {
-			return !!source.device.inputs ? source.device.inputs : [];
+			return source.device.inputs ? source.device.inputs : [];
 		} else {
 			for (const agent of filterDevicesForAccess(user, captureAgents)) {
 				if (agent.id === deviceId) {
-					return !!agent.inputs ? agent.inputs : [];
+					return agent.inputs ? agent.inputs : [];
 				}
 			}
 			return [];
@@ -213,7 +213,7 @@ const EventDetailsSchedulingTab = ({
 		const startDate = new Date(source.start.date);
 		const endDate = new Date(source.end.date);
 
-		const inputs = !!source.device.inputMethods
+		const inputs = source.device.inputMethods
 			? Array.from(source.device.inputMethods)
 			: [];
 
diff --git a/src/components/events/partials/ModalTabsAndPages/NewMetadataPage.tsx b/src/components/events/partials/ModalTabsAndPages/NewMetadataPage.tsx
@@ -48,7 +48,7 @@ const NewMetadataPage = ({
 												</td>
 												{field.readOnly ? (
 													// non-editable field if readOnly is set or user doesn't have edit access rights
-													!!field.collection ? (
+													field.collection ? (
 														<td>{getMetadataCollectionFieldName(field, field, t)}</td>
 													) : (
 														<td>{field.value}</td>
diff --git a/src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx b/src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx
@@ -367,7 +367,7 @@ const Schedule = <T extends {
 	const currentLanguage = getCurrentLanguageInformation();
 
 	const renderInputDeviceOptions = () => {
-		if (!!formik.values.location) {
+		if (formik.values.location) {
 			let inputDevice = inputDevices.find(
 				({ name }) => name === formik.values.location
 			);
diff --git a/src/components/events/partials/ModalTabsAndPages/NewTobiraPage.tsx b/src/components/events/partials/ModalTabsAndPages/NewTobiraPage.tsx
@@ -268,7 +268,7 @@ const NewTobiraPage = <T extends TobiraFormProps>({
 											</td>
 										</Tooltip>
 										<td>
-											{!!page.new
+											{page.new
 												? <input
 													placeholder={t('EVENTS.SERIES.NEW.TOBIRA.PAGE_TITLE')}
 													disabled={checkboxActive(page, key)}
@@ -295,7 +295,7 @@ const NewTobiraPage = <T extends TobiraFormProps>({
 										</td>
 										<td>
 											<code className="tobira-path">
-												{!!page.new
+												{page.new
 													? <input
 														placeholder={t('EVENTS.SERIES.NEW.TOBIRA.PATH_SEGMENT')}
 														value={page.segment ?? ""}
diff --git a/src/components/events/partials/wizards/NewEventSummary.tsx b/src/components/events/partials/wizards/NewEventSummary.tsx
@@ -74,11 +74,11 @@ const NewEventSummary = <T extends RequiredFormProps>({
 		}[] = [];
 		for (let i = 0; uploadAssetOptions.length > i; i++) {
 			let fieldValue = formik.values[uploadAssetOptions[i].id];
-			if (!!fieldValue) {
+			if (fieldValue) {
 				const displayOverride = uploadAssetOptions[i].displayOverride as ParseKeys
 				setUploadAssetsNonTrack(uploadAssetsNonTrack.concat({
 					name: uploadAssetOptions[i].id,
-					translate: !!displayOverride
+					translate: displayOverride
 						? t(displayOverride)
 						: translateOverrideFallback(uploadAssetOptions[i], t),
 					value: fieldValue,
@@ -157,7 +157,7 @@ const NewEventSummary = <T extends RequiredFormProps>({
 									{/*Insert row for each upload asset of type track user has provided*/}
 {/* @ts-expect-error TS(7006): Parameter 'asset' implicitly has an 'any' type. */}
 									{formik.values.uploadAssetsTrack.map((asset, key) =>
-										!!asset.file ? (
+										asset.file ? (
 											<tr key={key}>
 												<td>
 													{translateOverrideFallback(asset, t, "SHORT")}
@@ -279,7 +279,7 @@ const NewEventSummary = <T extends RequiredFormProps>({
 							<tr>
 								<td>{t("EVENTS.EVENTS.NEW.PROCESSING.WORKFLOW")}</td>
 								<td>
-									{!!workflowDefinition ? workflowDefinition.title : ""}
+									{workflowDefinition ? workflowDefinition.title : ""}
 								</td>
 							</tr>
 							{/* Repeat entry for each configuration key/value pair */}
diff --git a/src/components/events/partials/wizards/NewEventWizard.tsx b/src/components/events/partials/wizards/NewEventWizard.tsx
@@ -285,24 +285,24 @@ const getInitialValues = (
 	}
 
 	// Transform additional metadata for source (provided by constant in newEventConfig)
-	if (!!sourceMetadata.UPLOAD) {
+	if (sourceMetadata.UPLOAD) {
 		sourceMetadata.UPLOAD.metadata.forEach((field) => {
 			initialValues[field.id] = field.value;
 		});
 	}
-	if (!!sourceMetadata.SCHEDULE_SINGLE) {
+	if (sourceMetadata.SCHEDULE_SINGLE) {
 		sourceMetadata.SCHEDULE_SINGLE.metadata.forEach((field) => {
 			initialValues[field.id] = field.value;
 		});
 	}
-	if (!!sourceMetadata.SCHEDULE_MULTIPLE) {
+	if (sourceMetadata.SCHEDULE_MULTIPLE) {
 		sourceMetadata.SCHEDULE_MULTIPLE.metadata.forEach((field) => {
 			initialValues[field.id] = field.value;
 		});
 	}
 
 	// Add possible files that can be uploaded in source step
-	if (!!uploadSourceOptions) {
+	if (uploadSourceOptions) {
 		initialValues.uploadAssetsTrack = [];
 		// Sort by displayOrder
 		uploadSourceOptions = uploadSourceOptions.slice().sort((a, b) => a.displayOrder - b.displayOrder)
diff --git a/src/components/events/partials/wizards/RenderWorkflowConfig.tsx b/src/components/events/partials/wizards/RenderWorkflowConfig.tsx
@@ -158,7 +158,7 @@ const RenderField = <T extends RequiredFormProps>({
 }) => {
 	// id used for Field and label
 	const uuid = uuidv4();
-	const disabled = !!field.disabled ? field.disabled : false;
+	const disabled = field.disabled ? field.disabled : false;
 
 	const renderField = () => {
 			return(
diff --git a/src/components/shared/Stats.tsx b/src/components/shared/Stats.tsx
@@ -37,7 +37,7 @@ const Stats = () => {
 			}
 			let filter = filterMap.find(({ name }) => name === f.name);
 			filterValue = f.value;
-			if (!!filter) {
+			if (filter) {
 				dispatch(editFilterValue({filterName: filter.name, value: filterValue}));
 			}
 		});
@@ -70,7 +70,7 @@ const Stats = () => {
 							<h1>{st.count}</h1>
 							{/* Show the description of the status, if defined,
 								else show name of filter and its value*/}
-							{!!st.description ? (
+							{st.description ? (
 								<span>{t(st.description as ParseKeys)}</span>
 							) : (
 								st.filters.map((filter, key) => (
diff --git a/src/components/shared/TableFilters.tsx b/src/components/shared/TableFilters.tsx
@@ -115,7 +115,7 @@ const TableFilters = ({
 		// and the filter selections are cleared
 		if (name === "secondFilter") {
 			let filter = filterMap.find(({ name }) => name === selectedFilter);
-			if (!!filter) {
+			if (filter) {
 				dispatch(editFilterValue({filterName: filter.name, value: value}));
 				setFilterSelector(false);
 				dispatch(removeSelectedFilter());
diff --git a/src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx b/src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx
@@ -787,7 +787,7 @@ export const TemplateSelector = <T extends TemplateSelectorProps>({
 											aclTemplates,
 											formik.values.aclTemplate
 										)}
-										options={!!aclTemplates ? formatAclTemplatesForDropdown(aclTemplates) : []}
+										options={aclTemplates ? formatAclTemplatesForDropdown(aclTemplates) : []}
 										required={true}
 										handleChange={(element) => {
 											if (element) {
diff --git a/src/components/shared/wizard/WizardNavigationButtons.tsx b/src/components/shared/wizard/WizardNavigationButtons.tsx
@@ -40,7 +40,7 @@ const WizardNavigationButtons = <T, >({
 			isSubmitDisabled={disabled}
 			nextPage={
 				isLast
-				? () => { !!submitPage ? submitPage() : formik.handleSubmit(); }
+				? () => { submitPage ? submitPage() : formik.handleSubmit(); }
 				: () => { !!nextPage && nextPage(formik.values); }
 			}
 			previousPage={
diff --git a/src/slices/eventDetailsSlice.ts b/src/slices/eventDetailsSlice.ts
@@ -1008,7 +1008,7 @@ export const fetchSchedulingInfo = createAppAsyncThunk('eventDetails/fetchSchedu
 		const agent = captureAgents.find(
 			(agent) => agent.id === schedulingResponse.agentId
 		);
-		if (!!agent) {
+		if (agent) {
 			let inputMethods = [];
 
 			if (
@@ -1083,7 +1083,7 @@ export const saveSchedulingInfo = createAppAsyncThunk('eventDetails/saveScheduli
 	};
 
 	const agent = captureAgents.find((agent) => agent.id === values.captureAgent);
-	if (!!agent) {
+	if (agent) {
 		device = {
 			...agent,
 			inputMethods: values.inputs,
@@ -1263,7 +1263,7 @@ export const fetchWorkflows = createAppAsyncThunk('eventDetails/fetchWorkflows',
 	const workflowsData = await data.data;
 	let workflows: Workflow;
 
-	if (!!workflowsData.results) {
+	if (workflowsData.results) {
 		workflows = {
 			entries: workflowsData.results,
 			scheduling: false,
@@ -1381,7 +1381,7 @@ export const deleteWorkflow = createAppAsyncThunk('eventDetails/deleteWorkflow',
 			const state = getState();
 			const workflows = getWorkflows(state);
 
-			if (!!workflows.entries) {
+			if (workflows.entries) {
 				return workflows.entries.filter((wf) => wf.id !== workflowId)
 			} else {
 				return workflows.entries;
@@ -1616,7 +1616,7 @@ export const updateAssets = createAppAsyncThunk('eventDetails/updateAssets', asy
 	let assetFlavors = "";
 
 	uploadAssetOptions.forEach((option) => {
-		if (!!values[option.id]) {
+		if (values[option.id]) {
 			formData.append(option.id + ".0", values[option.id]);
 			assets.options = assets.options.concat(option);
 			const uploadAssetFlavor = [option.flavorType, option.flavorSubType].join("/");
diff --git a/src/slices/eventSlice.ts b/src/slices/eventSlice.ts
@@ -527,7 +527,7 @@ export const postNewEvent = createAppAsyncThunk('events/postNewEvent', async (pa
 			metadata: {
 				start: startDate,
 				device: values.location,
-				inputs: !!values.deviceInputs ? values.deviceInputs.join(",") : "",
+				inputs: values.deviceInputs ? values.deviceInputs.join(",") : "",
 				end: endDate,
 				duration: duration.toString(),
 			},
@@ -735,10 +735,10 @@ export const fetchScheduling = createAppAsyncThunk('events/fetchScheduling', asy
 				eventId: d.eventId,
 				title: d.agentConfiguration["event.title"],
 				changedTitle: d.agentConfiguration["event.title"],
-				series: !!d.agentConfiguration["event.series"]
+				series: d.agentConfiguration["event.series"]
 					? d.agentConfiguration["event.series"]
 					: "",
-				changedSeries: !!d.agentConfiguration["event.series"]
+				changedSeries: d.agentConfiguration["event.series"]
 					? d.agentConfiguration["event.series"]
 					: "",
 				location: d.agentConfiguration["event.location"],
@@ -973,7 +973,7 @@ export const checkForConflicts = async (
 	device: string,
 	repeatOn: string[] | undefined = undefined
 ) => {
-	let metadata = !!repeatOn
+	let metadata = repeatOn
 		? {
 				start: startDate,
 				device: device,
diff --git a/src/slices/recordingSlice.ts b/src/slices/recordingSlice.ts
@@ -78,10 +78,10 @@ export const fetchRecordings = createAppAsyncThunk('recordings/fetchRecordings',
 			name: agent.Name,
 			status: agent.Status,
 			updated: agent.Update,
-			inputs: !!agent.inputs ? [...agent.inputs] : [],
-			roomId: !!agent.roomId ? agent.roomId : "",
+			inputs: agent.inputs ? [...agent.inputs] : [],
+			roomId: agent.roomId ? agent.roomId : "",
 			type: "LOCATION",
-			url: !!agent.url ? agent.url : "",
+			url: agent.url ? agent.url : "",
 			removable:
 				"AGENTS.STATUS.OFFLINE" === agent.Status ||
 				"AGENTS.STATUS.UNKNOWN" === agent.Status,
diff --git a/src/slices/seriesDetailsSlice.ts b/src/slices/seriesDetailsSlice.ts
@@ -126,7 +126,7 @@ export const fetchSeriesDetailsAcls = createAppAsyncThunk('seriesDetails/fetchSe
 	const res = await axios.get(`/admin-ng/series/${id}/access.json`);
 	const response = res.data;
 
-	if (!!response.series_access.locked) {
+	if (response.series_access.locked) {
 		dispatch(
 			addNotification({
 				type: "warning",
diff --git a/src/slices/tableFilterSlice.ts b/src/slices/tableFilterSlice.ts
@@ -171,7 +171,7 @@ export const setSpecificEventFilter = createAppAsyncThunk('tableFilters/setSpeci
 		await dispatch(fetchFilters("events"));
 	}
 
-	if (!!filterToChange) {
+	if (filterToChange) {
 		await dispatch(editFilterValue({
 			filterName: filterToChange.name,
 			value: filterValue
@@ -192,7 +192,7 @@ export const setSpecificServiceFilter = createAppAsyncThunk('tableFilters/setSpe
 		filterToChange = fetchedFilters.payload.filtersList.find(({ name }: { name: string }) => name === filter);
 	}
 
-	if (!!filterToChange) {
+	if (filterToChange) {
 		await dispatch(editFilterValue({
 			filterName: filterToChange.name,
 			value: filterValue
diff --git a/src/slices/userDetailsSlice.ts b/src/slices/userDetailsSlice.ts
@@ -95,7 +95,7 @@ const userDetailsSlice = createSlice({
 				state.roles = userDetails.roles;
 				state.name = userDetails.name;
 				state.username = userDetails.username;
-				state.email = !!userDetails.email ? userDetails.email : "";
+				state.email = userDetails.email ? userDetails.email : "";
 				state.manageable = userDetails.manageable;
 			})
 			.addCase(fetchUserDetails.rejected, (state, action) => {
diff --git a/src/utils/aclUtils.ts b/src/utils/aclUtils.ts
diff --git a/src/utils/resourceUtils.ts b/src/utils/resourceUtils.ts
diff --git a/src/utils/utils.ts b/src/utils/utils.ts

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ const DetailsTobiraTab = ({ kind, id }: DetailsTobiraTabProps) => {`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`const openSubTab = async (tabType: TobiraTabHierarchy, currentPage?: TobiraPage) => {`
`118`		`- if (!!currentPage) {`
	`118`	`+ if (currentPage) {`
`119`	`119`	`const breadcrumbs = getBreadcrumbs(currentPage);`
`120`	`120`	`// Breadcrumbs always include at least the homepage, so the length is at least 1.`
`121`	`121`	`const hostPage = breadcrumbs[breadcrumbs.length - 1];`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ const EventDetailsAssetMediaDetails = () => {`
`101`	`101`	`}`
`102`	`102`	`</td>`
`103`	`103`	`<td>`
`104`		`- {!!media.duration`
	`104`	`+ {media.duration`
`105`	`105`	`? formatDuration(media.duration)`
`106`	`106`	`: null}`
`107`	`107`	`</td>`