Merge pull request #1372 from Arnei/eslint-require-await

Activate eslint require-await

Author: Arnei

eslint.config.js

@@ -17,7 +17,6 @@ export default [
             "@typescript-eslint/no-explicit-any": "off",
             "@typescript-eslint/no-floating-promises": "off",
             "@typescript-eslint/no-misused-promises": "off",
-            "@typescript-eslint/require-await": "off",
         },
     },
 ];

src/components/events/partials/EventsStatusCell.tsx

@@ -28,7 +28,7 @@ const EventsStatusCell = ({
 		}
 
 		dispatch(fetchWorkflows(row.id)).unwrap()
-			.then(async workflows => {
+			.then(workflows => {
 				// Open workflow overview modal if no workflows available
 				if (!workflows.entries.length) {
 					return dispatch(openModal(EventDetailsPage.Workflow, row));

src/components/events/partials/ModalTabsAndPages/EditScheduledEventsEditPage.tsx

@@ -399,10 +399,10 @@ const EditScheduledEventsEditPage = <T extends RequiredFormProps>({
 			<WizardNavigationButtons
 				formik={formik}
 				nextPage={
-					async () => {
+					() => {
 						dispatch(removeNotificationWizardForm());
 						if (
-							await checkSchedulingConflicts(
+							checkSchedulingConflicts(
 								formik.values,
 								setConflicts,
 								dispatch,

src/components/events/partials/ModalTabsAndPages/EventDetailsSchedulingTab.tsx

@@ -179,7 +179,7 @@ const EventDetailsSchedulingTab = ({
 	};
 
 	// submits the formik form
-	const submitForm = async (values: SchedulingInfo) => {
+	const submitForm = (values: SchedulingInfo) => {
 		dispatch(removeNotificationWizardForm());
 		const startDate = makeDate(
 			values.scheduleStartDate,
@@ -250,7 +250,7 @@ const EventDetailsSchedulingTab = ({
 					<Formik<InitialValues>
 						enableReinitialize
 						initialValues={getInitialValues()}
-						onSubmit={values => submitForm(values).then(() => {})}
+						onSubmit={values => submitForm(values)}
 						innerRef={formikRef}
 					>
 						{formik => (

src/components/events/partials/ModalTabsAndPages/EventDetailsWorkflowDetails.tsx

@@ -331,7 +331,7 @@ const OperationsPreview = ({
 		workflowDone = !(workflowStatus === "SUCCEEDED" || workflowStatus === "FAILED" || workflowStatus === "STOPPED");
 	}
 
-	const loadWorkflowOperations = async () => {
+	const loadWorkflowOperations = () => {
 		// Fetching workflow operations from server
 		if (workflowId) {
 			dispatch(fetchWorkflowOperations({ eventId, workflowId }));
@@ -340,7 +340,7 @@ const OperationsPreview = ({
 
 	useEffect(() => {
 		// Fetch workflow operations initially
-		loadWorkflowOperations().then();
+		loadWorkflowOperations();
 
 		// Fetch workflow operations every 5 seconds
 		const fetchWorkflowOperationsInterval = setInterval(loadWorkflowOperations, 5000);

src/components/events/partials/ModalTabsAndPages/EventDetailsWorkflowOperations.tsx

@@ -31,14 +31,14 @@ const EventDetailsWorkflowOperations = ({
 	const workflowId = useAppSelector(state => getModalWorkflowId(state));
 	const operations = useAppSelector(state => getWorkflowOperations(state));
 
-  const loadWorkflowOperations = async () => {
+  const loadWorkflowOperations = () => {
 		// Fetching workflow operations from server
 		dispatch(fetchWorkflowOperations({ eventId, workflowId }));
 	};
 
   useEffect(() => {
 		// Fetch workflow operations initially
-		loadWorkflowOperations().then();
+		loadWorkflowOperations();
 
 		// Fetch workflow operations every 5 seconds
 		const fetchWorkflowOperationsInterval = setInterval(loadWorkflowOperations, 5000);

src/components/events/partials/ModalTabsAndPages/NewAccessPage.tsx

@@ -184,8 +184,8 @@ const NewAccessPage = <T extends RequiredFormProps>({
 			{/* Button for navigation to next page and previous page */}
 			<WizardNavigationButtons
 				formik={formik}
-				nextPage={async () => {
-					if (await dispatch(checkAcls(formik.values.policies))) {
+				nextPage={() => {
+					if (dispatch(checkAcls(formik.values.policies))) {
 						nextPage(formik.values);
 					}
 				}}

src/components/events/partials/modals/EditScheduledEventsModal.tsx

@@ -89,16 +89,15 @@ const EditScheduledEventsModal = ({
 			errors.events = "Not all events editable!";
 		}
 		if (steps[page].name !== "general") {
-			return checkSchedulingConflicts(
+			const isConflict = checkSchedulingConflicts(
 				values,
 				setConflicts,
 				dispatch,
-			).then(result => {
-				if (!result) {
-					errors.editedEvents = "Scheduling conflicts exist!";
-				}
-				return errors;
-			});
+			);
+			if (!isConflict) {
+				errors.editedEvents = "Scheduling conflicts exist!";
+			}
+			return errors;
 		} else {
 			return errors;
 		}

src/components/shared/RegistrationModal.tsx

@@ -76,7 +76,7 @@ const RegistrationModalContent = () => {
 		// eslint-disable-next-line react-hooks/exhaustive-deps
 	}, []);
 
-	const onClickContinue = async () => {
+	const onClickContinue = () => {
 		// if state is deleteSubmit then delete infos about adaptor else show next state
 		if (state === "deleteSubmit") {
 			resetRegistrationData();

src/components/shared/Stats.tsx

@@ -13,7 +13,6 @@ import { loadEventsIntoTable } from "../../thunks/tableThunks";
 import { useAppDispatch, useAppSelector } from "../../store";
 import { fetchEvents } from "../../slices/eventSlice";
 import { ParseKeys } from "i18next";
-import { Tooltip } from "./Tooltip";
 import BaseButton from "./BaseButton";
 
 /**