Skip to content

Commit a657014

Browse files
ArneiArnei
authored
Merge pull request #1323 from JulianKniephoff/redundant-notification-parameter
Remove redundant `parameter: undefined` from calls to `addNotification`
2 parents d0d528c + fe0da44 commit a657014

11 files changed

Lines changed: 0 additions & 35 deletions

File tree

‎src/components/events/partials/ModalTabsAndPages/DetailsTobiraTab.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,15 +79,13 @@ const DetailsTobiraTab = ({ kind, id }: DetailsTobiraTabProps) => {
7979
type: "info",
8080
key: "TOBIRA_COPIED_DIRECT_LINK",
8181
duration: 3,
82-
parameter: undefined,
8382
context: NOTIFICATION_CONTEXT_TOBIRA,
8483
}));
8584
}, function () {
8685
dispatch(addNotification({
8786
type: "error",
8887
key: "TOBIRA_FAILED_COPYING_DIRECT_LINK",
8988
duration: 3,
90-
parameter: undefined,
9189
context: NOTIFICATION_CONTEXT_TOBIRA,
9290
}));
9391
});

‎src/components/events/partials/ModalTabsAndPages/EventDetailsSchedulingTab.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@ const EventDetailsSchedulingTab = ({
200200
type: "error",
201201
key: "EVENTS_NOT_UPDATED",
202202
duration: -1,
203-
parameter: undefined,
204203
context: NOTIFICATION_CONTEXT
205204
}));
206205
}

‎src/components/events/partials/ModalTabsAndPages/NewTobiraPage.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ const NewTobiraPage = <T extends TobiraFormProps>({
6060
type: type,
6161
key: key,
6262
duration: -1,
63-
parameter: undefined,
6463
context: context,
6564
noDuplicates: true,
6665
}));

‎src/components/events/partials/modals/EventDetails.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ const EventDetails = ({
100100
type: "warning",
101101
key: "ACTIVE_TRANSACTION",
102102
duration: -1,
103-
parameter: undefined,
104103
context: NOTIFICATION_CONTEXT,
105104
noDuplicates: true
106105
})

‎src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ const ResourceDetailsAccessPolicyTab = ({
134134
type: "warning",
135135
key: "ACTIVE_TRANSACTION",
136136
duration: -1,
137-
parameter: undefined,
138137
context: NOTIFICATION_CONTEXT,
139138
noDuplicates: true,
140139
}));
@@ -167,7 +166,6 @@ const ResourceDetailsAccessPolicyTab = ({
167166
type: "warning",
168167
key: "INVALID_ACL_RULES",
169168
duration: -1,
170-
parameter: undefined,
171169
context: NOTIFICATION_CONTEXT
172170
}));
173171
}
@@ -177,7 +175,6 @@ const ResourceDetailsAccessPolicyTab = ({
177175
type: "warning",
178176
key: "MISSING_ACL_RULES",
179177
duration: -1,
180-
parameter: undefined,
181178
context: NOTIFICATION_CONTEXT
182179
}));
183180
}

‎src/components/shared/wizard/FileUpload.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ const FileUpload = <T extends RequiredFormProps>({
9090
type: "error",
9191
key: "NOTIFICATIONS.BUMPER_UPLOAD_ERROR",
9292
duration: -1,
93-
parameter: undefined,
9493
context: NOTIFICATION_CONTEXT
9594
}));
9695
});

‎src/slices/aclSlice.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,6 @@ export const checkAcls = (acls: TransformedAcl[]) => async (dispatch: AppDispatc
208208
type: "warning",
209209
key: "INVALID_ACL_RULES",
210210
duration: -1,
211-
parameter: undefined,
212211
context: NOTIFICATION_CONTEXT_ACCESS
213212
})
214213
);
@@ -220,7 +219,6 @@ export const checkAcls = (acls: TransformedAcl[]) => async (dispatch: AppDispatc
220219
type: "warning",
221220
key: "MISSING_ACL_RULES",
222221
duration: -1,
223-
parameter: undefined,
224222
context: NOTIFICATION_CONTEXT_ACCESS
225223
})
226224
);

‎src/slices/eventDetailsSlice.ts‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,6 @@ export const fetchAssets = createAppAsyncThunk('eventDetails/fetchAssets', async
673673
type: "warning",
674674
key: "ACTIVE_TRANSACTION",
675675
duration: -1,
676-
parameter: undefined,
677676
context: NOTIFICATION_CONTEXT
678677
})
679678
);
@@ -1142,7 +1141,6 @@ export const saveSchedulingInfo = createAppAsyncThunk('eventDetails/saveScheduli
11421141
addNotification({
11431142
type: "error",
11441143
key: "EVENTS_NOT_UPDATED",
1145-
parameter: undefined,
11461144
context: NOTIFICATION_CONTEXT
11471145
})
11481146
);
@@ -1172,7 +1170,6 @@ if (endDate < now) {
11721170
type: "error",
11731171
key: "CONFLICT_IN_THE_PAST",
11741172
duration: -1,
1175-
parameter: undefined,
11761173
context: NOTIFICATION_CONTEXT
11771174
})
11781175
);
@@ -1203,7 +1200,6 @@ if (endDate < now) {
12031200
type: "error",
12041201
key: "CONFLICT_DETECTED",
12051202
duration: -1,
1206-
parameter: undefined,
12071203
context: NOTIFICATION_CONTEXT
12081204
})
12091205
);
@@ -1234,7 +1230,6 @@ if (endDate < now) {
12341230
type: "error",
12351231
key: "CONFLICT_DETECTED",
12361232
duration: -1,
1237-
parameter: undefined,
12381233
context: NOTIFICATION_CONTEXT
12391234
})
12401235
);
@@ -1339,7 +1334,6 @@ export const performWorkflowAction = createAppAsyncThunk('eventDetails/performWo
13391334
type: "success",
13401335
key: "EVENTS_PROCESSING_ACTION_" + action,
13411336
duration: -1,
1342-
parameter: undefined,
13431337
context: NOTIFICATION_CONTEXT
13441338
})
13451339
);
@@ -1351,7 +1345,6 @@ export const performWorkflowAction = createAppAsyncThunk('eventDetails/performWo
13511345
type: "error",
13521346
key: "EVENTS_PROCESSING_ACTION_NOT_" + action,
13531347
duration: -1,
1354-
parameter: undefined,
13551348
context: NOTIFICATION_CONTEXT
13561349
})
13571350
);
@@ -1373,7 +1366,6 @@ export const deleteWorkflow = createAppAsyncThunk('eventDetails/deleteWorkflow',
13731366
type: "success",
13741367
key: "EVENTS_PROCESSING_DELETE_WORKFLOW",
13751368
duration: -1,
1376-
parameter: undefined,
13771369
context: NOTIFICATION_CONTEXT
13781370
})
13791371
);
@@ -1393,7 +1385,6 @@ export const deleteWorkflow = createAppAsyncThunk('eventDetails/deleteWorkflow',
13931385
type: "error",
13941386
key: "EVENTS_PROCESSING_DELETE_WORKFLOW_FAILED",
13951387
duration: -1,
1396-
parameter: undefined,
13971388
context: NOTIFICATION_CONTEXT
13981389
})
13991390
);
@@ -1664,7 +1655,6 @@ export const updateAssets = createAppAsyncThunk('eventDetails/updateAssets', asy
16641655
addNotification({
16651656
type: "success",
16661657
key: "EVENTS_UPDATED",
1667-
parameter: undefined,
16681658
context: NOTIFICATION_CONTEXT
16691659
})
16701660
);
@@ -1675,7 +1665,6 @@ export const updateAssets = createAppAsyncThunk('eventDetails/updateAssets', asy
16751665
addNotification({
16761666
type: "error",
16771667
key: "EVENTS_NOT_UPDATED",
1678-
parameter: undefined,
16791668
context: NOTIFICATION_CONTEXT
16801669
})
16811670
);
@@ -1703,7 +1692,6 @@ export const saveAccessPolicies = createAppAsyncThunk('eventDetails/saveAccessPo
17031692
type: "info",
17041693
key: "SAVED_ACL_RULES",
17051694
duration: -1,
1706-
parameter: undefined,
17071695
context: NOTIFICATION_CONTEXT
17081696
})
17091697
);
@@ -1716,7 +1704,6 @@ export const saveAccessPolicies = createAppAsyncThunk('eventDetails/saveAccessPo
17161704
type: "error",
17171705
key: "ACL_NOT_SAVED",
17181706
duration: -1,
1719-
parameter: undefined,
17201707
context: NOTIFICATION_CONTEXT
17211708
})
17221709
);
@@ -1804,7 +1791,6 @@ export const saveWorkflowConfig = createAppAsyncThunk('eventDetails/saveWorkflow
18041791
type: "error",
18051792
key: "EVENTS_NOT_UPDATED",
18061793
duration: -1,
1807-
parameter: undefined,
18081794
context: NOTIFICATION_CONTEXT
18091795
})
18101796
);

‎src/slices/eventSlice.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,6 @@ export const checkConflicts = (values: {
905905
type: "error",
906906
key: "CONFLICT_ALREADY_ENDED",
907907
duration: -1,
908-
parameter: undefined,
909908
context: NOTIFICATION_CONTEXT
910909
})
911910
);
@@ -923,7 +922,6 @@ export const checkConflicts = (values: {
923922
type: "error",
924923
key: "CONFLICT_END_BEFORE_START",
925924
duration: -1,
926-
parameter: undefined,
927925
context: NOTIFICATION_CONTEXT
928926
})
929927
);
@@ -954,7 +952,6 @@ export const checkConflicts = (values: {
954952
type: "error",
955953
key: "CONFLICT_DETECTED",
956954
duration: -1,
957-
parameter: undefined,
958955
context: NOTIFICATION_CONTEXT
959956
})
960957
);
@@ -1070,7 +1067,6 @@ export const checkForSchedulingConflicts = (events: EditedEvents[]) => async (di
10701067
type: "error",
10711068
key: "CONFLICT_BULK_DETECTED",
10721069
duration: -1,
1073-
parameter: undefined,
10741070
context: NOTIFICATION_CONTEXT
10751071
})
10761072
);

‎src/slices/seriesDetailsSlice.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ export const fetchSeriesDetailsAcls = createAppAsyncThunk('seriesDetails/fetchSe
132132
type: "warning",
133133
key: "SERIES_ACL_LOCKED",
134134
duration: -1,
135-
parameter: undefined,
136135
context: NOTIFICATION_CONTEXT,
137136
noDuplicates: true
138137
})
@@ -260,7 +259,6 @@ export const updateSeriesAccess = createAppAsyncThunk('seriesDetails/updateSerie
260259
type: "info",
261260
key: "SAVED_ACL_RULES",
262261
duration: -1,
263-
parameter: undefined,
264262
context: NOTIFICATION_CONTEXT
265263
})
266264
);
@@ -273,7 +271,6 @@ export const updateSeriesAccess = createAppAsyncThunk('seriesDetails/updateSerie
273271
type: "error",
274272
key: "ACL_NOT_SAVED",
275273
duration: -1,
276-
parameter: undefined,
277274
context: NOTIFICATION_CONTEXT
278275
})
279276
);
@@ -299,7 +296,6 @@ export const updateSeriesTheme = createAppAsyncThunk('seriesDetails/updateSeries
299296
type: "warning",
300297
key: "SERIES_THEME_REPROCESS_EXISTING_EVENTS",
301298
duration: 10,
302-
parameter: undefined,
303299
context: NOTIFICATION_CONTEXT
304300
})
305301
);
@@ -324,7 +320,6 @@ export const updateSeriesTheme = createAppAsyncThunk('seriesDetails/updateSeries
324320
type: "warning",
325321
key: "SERIES_THEME_REPROCESS_EXISTING_EVENTS",
326322
duration: 10,
327-
parameter: undefined,
328323
context: NOTIFICATION_CONTEXT
329324
})
330325
);

0 commit comments

Comments
 (0)