Skip to content

Commit 75ddd63

Browse files
authored
Remove btm spacer, fix scroll bars in modals (#1053)
Since we decided that our modals should be scrollable, some of them always have a scrollbar showing, due to an absolutely positioned white box at the very bottom of the modal. I am not sure what the original purpose of this "btm-spacer" component was supposed to be, but it seems superfluous to me and so I am removing it. This should stop the scrollbars from appearing unnecessarily.
1 parent edbcbec commit 75ddd63

17 files changed

Lines changed: 1 addition & 68 deletions

src/components/configuration/partials/wizard/ThemeDetails.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@ const ThemeDetails = ({
121121
createTranslationString={"SUBMIT"}
122122
cancelTranslationString={"CANCEL"}
123123
/>
124-
125-
<div className="btm-spacer" />
126124
</div>
127125
)}
128126
</Formik>

src/components/events/partials/ModalTabsAndPages/DetailsMetadataTab.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ const DetailsMetadataTab = ({
157157
isLast
158158
/>
159159

160-
<div className="btm-spacer" />
161160
</>
162161
)}
163162
</div>

src/components/events/partials/ModalTabsAndPages/EditScheduledEventsEditPage.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,8 +427,6 @@ const EditScheduledEventsEditPage = <T extends RequiredFormProps>({
427427
}
428428
}
429429
/>
430-
431-
<div className="btm-spacer" />
432430
</>
433431
);
434432
};

src/components/events/partials/ModalTabsAndPages/EditScheduledEventsGeneralPage.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,6 @@ const EditScheduledEventsGeneralPage = <T extends RequiredFormProps>({
142142
}
143143
isFirst
144144
/>
145-
146-
<div className="btm-spacer" />
147145
</>
148146
);
149147
};

src/components/events/partials/ModalTabsAndPages/EventDetailsSchedulingTab.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -522,8 +522,6 @@ const EventDetailsSchedulingTab = ({
522522
cancelTranslationString="CANCEL"
523523
isLast
524524
/>
525-
526-
<div className="btm-spacer" />
527525
</>
528526
)}
529527
</div>

src/components/events/partials/ModalTabsAndPages/NewAccessPage.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,8 +360,6 @@ const NewAccessPage = <T extends RequiredFormProps>({
360360
}}
361361
previousPage={previousPage}
362362
/>
363-
364-
<div className="btm-spacer" />
365363
</>
366364
);
367365
};

src/components/events/partials/ModalTabsAndPages/NewProcessingPage.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,6 @@ const NewProcessingPage = <T extends RequiredFormProps>({
133133
nextPage={nextPage}
134134
previousPage={() => previous()}
135135
/>
136-
137-
<div className="btm-spacer" />
138136
</>
139137
);
140138
};

src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,8 +225,6 @@ const NewSourcePage = <T extends RequiredFormProps>({
225225
}}
226226
previousPage={previousPage}
227227
/>
228-
229-
<div className="btm-spacer" />
230228
</>
231229
);
232230
};

src/components/events/partials/ModalTabsAndPages/SeriesDetailsThemeTab.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ const SeriesDetailsThemeTab = ({
9696
cancelTranslationString="CANCEL"
9797
isLast
9898
/>
99-
100-
<div className="btm-spacer" />
10199
</>
102100
)}
103101
</div>

src/components/events/partials/ModalTabsAndPages/StartTaskGeneralPage.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,6 @@ const StartTaskGeneralPage = <T extends RequiredFormProps>({
134134
customValidation={!checkValidityStartTaskEventSelection(formik.values)}
135135
isFirst
136136
/>
137-
138-
<div className="btm-spacer" />
139137
</>
140138
);
141139
};

0 commit comments

Comments
 (0)