Skip to content

Commit 6192e09

Browse files
committed
Merge branch 'role-gets-unselected-when-changing-access-rights' of Arnei/opencast-admin-interface into r/19.x
Pull request #1523 Fixes #1507 Fix role getting unselected when changing write
2 parents a05b3d7 + f64541f commit 6192e09

1 file changed

Lines changed: 7 additions & 14 deletions

File tree

src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -547,11 +547,11 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
547547
handleChange={element => {
548548
if (element) {
549549
const matchingRole = roles.find(role => role.name === element.value);
550-
arrayHelpers.replace(formik.values.policies.findIndex(p => p === policy), {
551-
...policy,
552-
role: element.value,
553-
user: matchingRole ? matchingRole.user : undefined,
554-
});
550+
formik.setFieldValue(`policies.${index}.role`, element.value);
551+
formik.setFieldValue(
552+
`policies.${index}.user`,
553+
matchingRole ? matchingRole.user : undefined,
554+
);
555555
}
556556
}}
557557
placeholder={
@@ -591,10 +591,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
591591
: "false"
592592
}`}
593593
onChange={(read: React.ChangeEvent<HTMLInputElement>) =>
594-
arrayHelpers.replace(formik.values.policies.findIndex(p => p === policy), {
595-
...policy,
596-
read: read.target.checked,
597-
})
594+
formik.setFieldValue(`policies.${index}.read`, read.target.checked)
598595
}
599596
/>
600597
</td>
@@ -618,11 +615,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
618615
: "false"
619616
}`}
620617
onChange={(write: React.ChangeEvent<HTMLInputElement>) =>
621-
arrayHelpers.replace(formik.values.policies.findIndex(p => p === policy), {
622-
...policy,
623-
write:
624-
write.target.checked,
625-
})
618+
formik.setFieldValue(`policies.${index}.write`, write.target.checked)
626619
}
627620
/>
628621
</td>

0 commit comments

Comments
 (0)