Merge branch 'unbound-method' of Arnei/opencast-admin-interface into develop

Pull request #1353

  Activate eslint unbound-method

Author: gregorydlogan

eslint.config.js

@@ -29,7 +29,6 @@ export default [
             "@typescript-eslint/no-unused-vars": "off",
             "@typescript-eslint/no-unsafe-return": "off",
             "@typescript-eslint/require-await": "off",
-            "@typescript-eslint/unbound-method": "off",
         },
     },
 ];

src/components/events/partials/ModalTabsAndPages/EditScheduledEventsEditPage.tsx

@@ -156,9 +156,9 @@ const EditScheduledEventsEditPage = <T extends RequiredFormProps>({
 
 				{/* Repeat table for each selected event */}
 				{!loading && (
-					<FieldArray name="editedEvents">
-						{ }
-						{({ insert, remove, push }) => (
+					<FieldArray
+						name="editedEvents"
+						render={arrayHelpers => (
 							<>
 							{hasAccess(
 								"ROLE_UI_EVENTS_DETAILS_METADATA_EDIT",
@@ -391,7 +391,7 @@ const EditScheduledEventsEditPage = <T extends RequiredFormProps>({
 								}
 							</>
 						)}
-					</FieldArray>
+					/>
 				)}
 			</ModalContentTable>
 

src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx

@@ -259,10 +259,10 @@ const Upload = <T extends RequiredFormPropsUpload>({
 				<div className="obj-container">
 					<table className="main-tbl">
 						<tbody>
-							<FieldArray name="uploadAssetsTrack">
-								{/*File upload button for each upload asset*/}
-								{ }
-								{({ insert, remove, push }) =>
+							{/*File upload button for each upload asset*/}
+							<FieldArray
+								name="uploadAssetsTrack"
+								render={arrayHelpers => (
 									formik.values.uploadAssetsTrack &&
 									formik.values.uploadAssetsTrack.length > 0 &&
 									formik.values.uploadAssetsTrack.map((asset, key) => (
@@ -306,8 +306,8 @@ const Upload = <T extends RequiredFormPropsUpload>({
 											</td>
 										</tr>
 									))
-								}
-							</FieldArray>
+								)}
+							/>
 						</tbody>
 					</table>
 				</div>

src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx

@@ -525,8 +525,9 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
 
 							<tbody>
 								{/* list of policies */}
-								<FieldArray name={"policies"}>
-									{({ replace, remove, push }) => (
+								<FieldArray
+									name={"policies"}
+									render={arrayHelpers => (
 										<>
 											{formik.values.policies.length > 0 &&
 												policiesFiltered.map(
@@ -548,7 +549,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
 																		handleChange={element => {
 																			if (element) {
 																				const matchingRole = roles.find(role => role.name === element.value);
-																				replace(formik.values.policies.findIndex(p => p === policy), {
+																				arrayHelpers.replace(formik.values.policies.findIndex(p => p === policy), {
 																					...policy,
 																					role: element.value,
 																					user: matchingRole ? matchingRole.user : undefined,
@@ -589,7 +590,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
 																			: "false"
 																	}`}
 																	onChange={(read: React.ChangeEvent<HTMLInputElement>) =>
-																		replace(formik.values.policies.findIndex(p => p === policy), {
+																		arrayHelpers.replace(formik.values.policies.findIndex(p => p === policy), {
 																			...policy,
 																			read: read.target.checked,
 																		})
@@ -616,7 +617,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
 																			: "false"
 																	}`}
 																	onChange={(write: React.ChangeEvent<HTMLInputElement>) =>
-																		replace(formik.values.policies.findIndex(p => p === policy), {
+																		arrayHelpers.replace(formik.values.policies.findIndex(p => p === policy), {
 																			...policy,
 																			write:
 																				write.target.checked,
@@ -675,7 +676,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
 																	{!transactions.readOnly && (
 																		<ButtonLikeAnchor
 																			onClick={() =>
-																				remove(formik.values.policies.findIndex(p => p === policy))
+																				arrayHelpers.remove(formik.values.policies.findIndex(p => p === policy))
 																			}
 																			extraClassName="remove"
 																		/>
@@ -693,7 +694,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
 														<td colSpan={5}>
 															<ButtonLikeAnchor
 																onClick={() =>
-																	push(createPolicy("", isUserTable))
+																	arrayHelpers.push(createPolicy("", isUserTable))
 																}
 															>
 																+{" "}
@@ -704,7 +705,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
 												)}
 										</>
 									)}
-								</FieldArray>
+								/>
 							</tbody>
 						</table>
 					</div>