Skip to content

Commit 2371ace

Browse files
committed
Activate esling no-unused-vars
Enables the eslint rule "@typescript-eslint/no-unused-vars": "off". Since React 17, we can finally get rid of all those unused "import React from react" statements that were necessary if there was any JSX in the file.
1 parent 7efaffa commit 2371ace

145 files changed

Lines changed: 107 additions & 191 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

eslint.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export default [
3535
"@typescript-eslint/no-unsafe-call": "off",
3636
"@typescript-eslint/no-unsafe-member-access": "off",
3737
"@typescript-eslint/no-unused-expressions": "off",
38-
"@typescript-eslint/no-unused-vars": "off",
38+
// "@typescript-eslint/no-unused-vars": "off",
3939
"@typescript-eslint/no-unsafe-return": "off",
4040
"@typescript-eslint/require-await": "off",
4141
"@typescript-eslint/unbound-method": "off",

src/App.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useEffect } from "react";
1+
import { useEffect } from "react";
22
import { HashRouter, Navigate, Route, Routes } from "react-router";
33
import "./App.scss";
44
import Events from "./components/events/Events";
@@ -29,7 +29,7 @@ function App() {
2929
subscribeToAuthEvents();
3030

3131
// Add event listener for back button to check if we are still logged in
32-
window.addEventListener("popstate", function (event) {
32+
window.addEventListener("popstate", function () {
3333
dispatch(fetchUserInfo());
3434
});
3535

src/components/About.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useEffect, useState } from "react";
1+
import { useEffect, useState } from "react";
22
import Header from "./Header";
33
import NavBar from "./NavBar";
44
import Footer from "./Footer";
@@ -24,7 +24,7 @@ const About = () => {
2424
.then(response => {
2525
setAboutContent(response.data);
2626
})
27-
.catch(error => {
27+
.catch(() => {
2828
axios.get(getURL(typeof i18n.options.fallbackLng === 'string' ? i18n.options.fallbackLng : 'en-US'))
2929
.then(response => {
3030
setAboutContent(response.data);

src/components/configuration/Themes.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useEffect, useState } from "react";
1+
import { useEffect, useState } from "react";
22
import { useTranslation } from "react-i18next";
33
import TableFilters from "../shared/TableFilters";
44
import Table from "../shared/Table";

src/components/configuration/partials/ThemesActionsCell.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useRef } from "react";
1+
import { useRef } from "react";
22
import {
33
fetchThemeDetails,
44
fetchUsage,

src/components/configuration/partials/ThemesDateTimeCell.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import React from "react";
21
import { useTranslation } from "react-i18next";
32
import { renderValidDate } from "../../../utils/dateUtils";
43
import { ThemeDetailsType } from "../../../slices/themeSlice";

src/components/configuration/partials/wizard/BumperPage.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import React from "react";
21
import { useTranslation } from "react-i18next";
32
import WizardNavigationButtons from "../../../shared/wizard/WizardNavigationButtons";
43
import FileUpload from "../../../shared/wizard/FileUpload";

src/components/configuration/partials/wizard/GeneralPage.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import React from "react";
21
import { useTranslation } from "react-i18next";
32
import Notifications from "../../../shared/Notifications";
43
import { FormikProps } from "formik";

src/components/configuration/partials/wizard/NewThemeWizard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useEffect } from "react";
1+
import { useEffect } from "react";
22
import { Formik } from "formik";
33
import GeneralPage from "./GeneralPage";
44
import BumperPage from "./BumperPage";

src/components/configuration/partials/wizard/ThemeDetails.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useState } from "react";
1+
import { useState } from "react";
22
import { Formik } from "formik";
33
import GeneralPage from "./GeneralPage";
44
import BumperPage from "./BumperPage";

0 commit comments

Comments
 (0)