OBPIH-7694 refactor putaway page tests to use consistent test IDs and improve readability (#74)

Author: alannadolny

src/pages/putaway/CreatePutawayPage.ts

@@ -43,10 +43,7 @@ class CreatePutawayPage extends BasePageModel {
   }
 
   get linesInPendingPutawayFilter() {
-    return this.page
-      .locator('#select-id_1 div')
-      .filter({ hasText: 'Exclude' })
-      .nth(1);
+    return this.page.getByTestId('custom-select-element');
   }
 
   get includeLinesInPendingPutawayFilter() {

src/pages/putaway/components/CompletePutawayTable.ts

@@ -28,8 +28,8 @@ class Row extends BasePageModel {
     this.row = row;
   }
 
-  getputawayBin(rowIndex: number) {
-    return this.row.getByTestId(`cell-${rowIndex}-undefined`).nth(9);
+  get putawayBin() {
+    return this.row.getByTestId('table-cell').nth(10);
   }
 }
 

src/pages/putaway/components/CreatePutawayTable.ts

@@ -34,12 +34,12 @@ class Row extends BasePageModel {
 
   getExpandBinLocation(binLocation: string) {
     return this.row
-      .getByTestId('cell-undefined-undefined')
+      .getByTestId('table-cell')
       .getByText(binLocation);
   }
 
   get receivingBin() {
-    return this.row.getByTestId('cell-undefined-undefined');
+    return this.row.getByTestId('table-cell');
   }
 
   getProductName(name: string) {

src/pages/putaway/components/SplitModal.ts

@@ -13,7 +13,7 @@ class SplitModal extends BasePageModel {
   }
 
   get modal() {
-    return this.page.locator('.ReactModal__Content');
+    return this.page.getByTestId('split-line-modal');
   }
 
   async isLoaded() {

src/pages/putaway/components/StartPutawayTable.ts

@@ -56,19 +56,23 @@ class Row extends BasePageModel {
   }
 
   getCurrentBin(currentBin: string) {
-    return this.row.getByTestId('cell-0-currentBin').getByText(currentBin);
+    return this.row.getByTestId('table-cell').getByText(currentBin);
   }
 
-  getPreferredBin(rowIndex: number) {
-    return this.row.getByTestId(`cell-${rowIndex}-preferredBin`);
+  get preferredBin() {
+    return this.row.getByTestId('table-cell').nth(8);
   }
 
   get quantityField() {
-    return this.row.getByTestId('cell-0-quantity').getByRole('spinbutton');
+    return this.row.getByTestId('table-cell').nth(7);
   }
 
-  get splitLineinPutawayBin() {
-    return this.row.getByTestId('cell-0-putawayBin');
+  get quantityInput() {
+    return this.row.getByTestId('quantity-input')
+  }
+
+  get splitLineInPutawayBin() {
+    return this.row.getByTestId('open-modal');
   }
 }
 

src/pages/putaway/list/PutawayListPage.ts

@@ -26,30 +26,26 @@ class PutawayListPage extends BasePageModel {
   }
 
   get filters() {
-    return this.page.locator('.box');
+    return this.page.getByTestId('filters')
   }
 
   get searchField() {
     return this.filters
-      .locator('.filter-list-item')
       .getByTestId('search-input');
   }
 
   get orderTypeFilter() {
     return this.filters
-      .locator('.filter-list-item')
       .getByTestId('order-type-select');
   }
 
   get statusFilter() {
     return this.filters
-      .locator('.filter-list-item')
       .getByTestId('status.select');
   }
 
   get destinationFilter() {
     return this.filters
-      .locator('.filter-list-item')
       .getByTestId('destination-select');
   }
 
@@ -62,9 +58,7 @@ class PutawayListPage extends BasePageModel {
   }
 
   get emptyPutawayList() {
-    return this.page
-      .locator('.empty fade center')
-      .getByText('No orders match the given criteria');
+    return this.page.getByTestId('empty-table');
   }
 }
 

src/pages/putaway/list/PutawayListTable.ts

@@ -15,27 +15,9 @@ class PutawayListTable extends BasePageModel {
     return new Row(this.page, this.rows.nth(index));
   }
 
-  get viewOrderDetailsButton() {
-    return this.page
-      .locator('.action-menu-item')
-      .getByRole('link', { name: 'View order details' });
-  }
-
-  get deleteOrderButton() {
-    return this.page
-      .locator('.action-menu-item')
-      .getByRole('link', { name: 'Delete Order' });
-  }
-
-  async clickDeleteOrderButton() {
+  async clickDeleteOrderButton(index: number) {
     this.page.once('dialog', (dialog) => dialog.accept());
-    await this.deleteOrderButton.click();
-  }
-
-  get emptyPutawayList() {
-    return this.table
-      .locator('.empty')
-      .getByText('No orders match the given criteria');
+    await this.row(index).deleteOrder.click();
   }
 }
 
@@ -48,15 +30,23 @@ class Row extends BasePageModel {
   }
 
   get actionsButton() {
-    return this.row.getByTestId('action-menu-0');
+    return this.row.getByTestId('action-menu');
   }
 
   get statusTag() {
-    return this.row.getByTestId('status-0');
+    return this.row.getByTestId('status');
   }
 
   get orderNumber() {
-    return this.row.getByTestId('order-number-0');
+    return this.row.getByTestId('order-number');
+  }
+
+  get viewOrderDetails() {
+    return this.row.getByTestId('view-details-item');
+  }
+
+  get deleteOrder() {
+    return this.row.getByTestId('delete-order-item');
   }
 }
 export default PutawayListTable;

src/pages/putaway/putawayDetails/PutawayDetailsPage.ts

@@ -31,37 +31,27 @@ class PutawayDetailsPage extends BasePageModel {
   }
 
   get actionsViewOrderDetailsButton() {
-    return this.page
-      .locator('.action-menu-item')
-      .getByRole('link', { name: 'View order details' });
+    return this.page.getByTestId('view-details-item');
   }
 
   get actionsAddCommentButton() {
-    return this.page
-      .locator('.action-menu-item')
-      .getByRole('link', { name: 'Add comment' });
+    return this.page.getByTestId('add-comment-item');
   }
 
   get actionsAddDocumentsButton() {
-    return this.page
-      .locator('.action-menu-item')
-      .getByRole('link', { name: 'Add document' });
+    return this.page.getByTestId('add-document-item');
   }
 
   get actionsGeneratePutawayListButton() {
-    return this.page
-      .locator('.action-menu-item')
-      .getByRole('link', { name: 'Generate Putaway List' });
+    return this.page.getByTestId('generate-pdf-item');
   }
 
   get actionsDeleteButton() {
-    return this.page
-      .locator('.action-menu-item')
-      .getByRole('link', { name: 'Delete Order' });
+    return this.page.getByTestId('delete-order-item');
   }
 
   get statusTag() {
-    return this.summary.locator('.tag-alert');
+    return this.summary.getByTestId('status');
   }
 
   // TABS

src/tests/putaway/assertAttemptToEditCompletedPutaway.test.ts

@@ -189,7 +189,7 @@ test.describe('Assert attempt to edit completed putaway', () => {
       ).toBeVisible();
       await createPutawayPage.startStep.closeDisplayedError();
       await createPutawayPage.startStep.table.row(0).editButton.click();
-      await createPutawayPage.startStep.table.row(0).quantityField.fill('20');
+      await createPutawayPage.startStep.table.row(0).quantityInput.fill('20');
       await expect(createPutawayPage.startStep.nextButton).toBeDisabled();
       await expect(createPutawayPage.startStep.saveButton).toBeDisabled();
     });

src/tests/putaway/assertPutawayDetailsPage.test.ts

@@ -140,8 +140,9 @@ test.describe('Assert putaway details page', () => {
     });
 
     await test.step('Go to putaway view page and assert page elements', async () => {
-      await putawayListPage.table.row(1).actionsButton.click();
-      await putawayListPage.table.viewOrderDetailsButton.click();
+      const row = putawayListPage.table.row(1)
+      await row.actionsButton.click();
+      await row.viewOrderDetails.click();
       await putawayDetailsPage.isLoaded();
       await expect(putawayDetailsPage.listOrdersButton).toBeVisible();
       await expect(putawayDetailsPage.createOrderButton).toBeVisible();