Use long-lived connection for StatsCollector

Author: LEDfan

src/main/java/eu/openanalytics/containerproxy/stat/impl/JDBCCollector.java

@@ -34,52 +34,53 @@
 
 /**
  * 
- * # MonetDB, Postgresql, MySQL/MariaDB
- * usage-stats-url: jdbc:monetdb://localhost:50000/usage_stats
- * usage-stats-url: jdbc:postgresql://localhost/postgres
- * usage-stats-url: jdbc:mysql://localhost/shinyproxy
+ * # MonetDB, Postgresql, MySQL/MariaDB usage-stats-url:
+ * jdbc:monetdb://localhost:50000/usage_stats usage-stats-url:
+ * jdbc:postgresql://localhost/postgres usage-stats-url:
+ * jdbc:mysql://localhost/shinyproxy
  * 
  * Assumed table layout:
  * 
- * create table event(
- *  event_time timestamp,
- *  username varchar(128),
- *  type varchar(128),
- *  data text
- * ); 
+ * create table event( event_time timestamp, username varchar(128), type
+ * varchar(128), data text );
  * 
  * 
- * # MS SQL Server
- * usage-stats-url: jdbc:sqlserver://localhost;databaseName=shinyproxy
+ * # MS SQL Server usage-stats-url:
+ * jdbc:sqlserver://localhost;databaseName=shinyproxy
  * 
  * Assumed table layout:
  * 
- * create table event(
- *   event_time datetime,
- *   username varchar(128),
- *   type varchar(128),
- *   data text
- * );
+ * create table event( event_time datetime, username varchar(128), type
+ * varchar(128), data text );
  * 
  */
 public class JDBCCollector implements IStatCollector {
 
+	private Connection conn;
+
 	@Override
 	public void accept(Event event, Environment env) throws IOException {
-		String username = env.getProperty("proxy.usage-stats-username", "monetdb");
-		String password = env.getProperty("proxy.usage-stats-password", "monetdb");
-		String baseURL = env.getProperty("proxy.usage-stats-url");
-		try (Connection conn = DriverManager.getConnection(baseURL, username, password)) {
-			String sql = "INSERT INTO event(event_time, username, type, data) VALUES (?,?,?,?)";
-			try (PreparedStatement stmt = conn.prepareStatement(sql)) {
-				stmt.setTimestamp(1, new Timestamp(System.currentTimeMillis()));
-				stmt.setString(2, event.user);
-				stmt.setString(3, event.type);
-				stmt.setString(4, event.data);
-				stmt.executeUpdate();
+		synchronized (this) {
+			String baseURL = env.getProperty("proxy.usage-stats-url");
+			String username = env.getProperty("proxy.usage-stats-username", "monetdb");
+			String password = env.getProperty("proxy.usage-stats-password", "monetdb");
+			try {
+				if (conn == null || conn.isClosed()) {
+					conn = DriverManager.getConnection(baseURL, username, password);
+				}
+			} catch (SQLException e) {
+				throw new IOException("Failed to connect to " + baseURL, e);
 			}
+		}
+		String sql = "INSERT INTO event(event_time, username, type, data) VALUES (?,?,?,?)";
+		try (PreparedStatement stmt = conn.prepareStatement(sql)) {
+			stmt.setTimestamp(1, new Timestamp(System.currentTimeMillis()));
+			stmt.setString(2, event.user);
+			stmt.setString(3, event.type);
+			stmt.setString(4, event.data);
+			stmt.executeUpdate();
 		} catch (SQLException e) {
-			throw new IOException("Failed to connect to " + baseURL, e);
+			throw new IOException("Exception while loggin stats", e);
 		}
 	}
 }