Skip to content

Commit e5be53a

Browse files
committed
Fix #28255: add labels to additional manifests
1 parent f480111 commit e5be53a

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

src/main/java/eu/openanalytics/containerproxy/backend/kubernetes/KubernetesBackend.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,14 @@
5353
import io.fabric8.kubernetes.api.model.ObjectReferenceBuilder;
5454
import io.fabric8.kubernetes.api.model.Pod;
5555
import io.fabric8.kubernetes.api.model.PodBuilder;
56-
import io.fabric8.kubernetes.api.model.ServiceBuilder;
5756
import io.fabric8.kubernetes.api.model.PodSpec;
5857
import io.fabric8.kubernetes.api.model.Quantity;
5958
import io.fabric8.kubernetes.api.model.ResourceRequirementsBuilder;
6059
import io.fabric8.kubernetes.api.model.SecretKeySelectorBuilder;
6160
import io.fabric8.kubernetes.api.model.SecurityContext;
6261
import io.fabric8.kubernetes.api.model.SecurityContextBuilder;
6362
import io.fabric8.kubernetes.api.model.Service;
63+
import io.fabric8.kubernetes.api.model.ServiceBuilder;
6464
import io.fabric8.kubernetes.api.model.ServicePort;
6565
import io.fabric8.kubernetes.api.model.ServicePortBuilder;
6666
import io.fabric8.kubernetes.api.model.Volume;
@@ -472,14 +472,14 @@ private void createAdditionalManifests(Proxy proxy, String namespace) throws Jso
472472
private List<GenericKubernetesResource> getAdditionManifestsAsObjects(Proxy proxy, String namespace) throws JsonProcessingException {
473473
SpecExpressionContext context = SpecExpressionContext.create(
474474
proxy, proxy.getSpec());
475-
return parseAdditionalManifests(context, namespace, proxy.getSpec().getKubernetesAdditionalManifests());
475+
return parseAdditionalManifests(proxy.getSpec().getId(), context, namespace, proxy.getSpec().getKubernetesAdditionalManifests());
476476
}
477477

478478
private List<GenericKubernetesResource> getAdditionPersistentManifestsAsObjects(Proxy proxy, String namespace) throws JsonProcessingException {
479479
SpecExpressionContext context = SpecExpressionContext.create(
480480
proxy, proxy.getSpec(),
481481
userService.getCurrentAuth().getPrincipal(), userService.getCurrentAuth().getCredentials());
482-
return parseAdditionalManifests(context, namespace, proxy.getSpec().getKubernetesAdditionalPersistentManifests());
482+
return parseAdditionalManifests(proxy.getSpec().getId(), context, namespace, proxy.getSpec().getKubernetesAdditionalPersistentManifests());
483483
}
484484

485485
private void applyAdditionalManifest(GenericKubernetesResource resource) {
@@ -520,7 +520,7 @@ private void applyAdditionalManifest(GenericKubernetesResource resource) {
520520
* When the resource has no namespace definition, the provided namespace
521521
* parameter will be used.
522522
*/
523-
private List<GenericKubernetesResource> parseAdditionalManifests(SpecExpressionContext context, String namespace, List<String> manifests) throws JsonProcessingException {
523+
private List<GenericKubernetesResource> parseAdditionalManifests(String specId, SpecExpressionContext context, String namespace, List<String> manifests) throws JsonProcessingException {
524524
ArrayList<GenericKubernetesResource> result = new ArrayList<>();
525525
for (String manifest : manifests) {
526526
String expressionManifest = expressionResolver.evaluateToString(manifest, context);
@@ -535,6 +535,9 @@ private List<GenericKubernetesResource> parseAdditionalManifests(SpecExpressionC
535535
// therefore we overwrite this namespace with the namespace of the pod.
536536
fullObject.getMetadata().setNamespace(namespace);
537537
}
538+
fullObject.getMetadata().getLabels().put("openanalytics.eu/sp-additional-manifest", "true");
539+
fullObject.getMetadata().getLabels().put("openanalytics.eu/sp-realm", identifierService.realmId); // TODO
540+
fullObject.getMetadata().getLabels().put("openanalytics.eu/sp-spec-id", specId);
538541
result.add(fullObject);
539542
}
540543
return result;

0 commit comments

Comments
 (0)