Ref #25533: throw error if parameters are expected but none are provided

Author: LEDfan

src/main/java/eu/openanalytics/containerproxy/service/ParametersService.java

@@ -123,6 +123,10 @@ public boolean validateRequest(ProxySpec resolvedSpec, ProvidedParameters provid
             return false;
         }
 
+        if (providedParameters == null) {
+            throw new InvalidParametersException("No parameters provided, but proxy spec expects parameters");
+        }
+
         // check if correct number of parameters is provided
         if (providedParameters.size() != parameters.getIds().size()) {
             throw new InvalidParametersException("Invalid number of parameters provided");

src/main/java/eu/openanalytics/containerproxy/service/ProxyService.java

@@ -259,10 +259,8 @@ public Proxy startProxy(ProxySpec spec, boolean ignoreAccessControl, List<Runtim
 		if (runtimeValues != null) {
 			proxy.addRuntimeValues(runtimeValues);
 		}
-        if (parameters != null) {
-            if (parametersService.validateRequest(spec, parameters)) {
-                proxy.addRuntimeValue(new RuntimeValue(ParametersKey.inst, parameters));
-            }
+        if (parametersService.validateRequest(spec, parameters)) {
+            proxy.addRuntimeValue(new RuntimeValue(ParametersKey.inst, parameters));
         }
 
 		activeProxies.add(proxy);