Skip to content

Commit 92e554f

Browse files
committed
Ref #31631: support proper array in scopes
1 parent eae87f4 commit 92e554f

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/main/java/eu/openanalytics/containerproxy/auth/impl/oidc/OpenIDConfiguration.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
package eu.openanalytics.containerproxy.auth.impl.oidc;
2222

2323
import eu.openanalytics.containerproxy.auth.impl.oidc.redis.RedisOAuth2AuthorizedClientService;
24+
import eu.openanalytics.containerproxy.util.EnvironmentUtils;
2425
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
2526
import org.springframework.context.annotation.Bean;
2627
import org.springframework.context.annotation.Configuration;
@@ -42,6 +43,8 @@
4243
import javax.inject.Inject;
4344
import java.util.Collections;
4445
import java.util.HashSet;
46+
import java.util.List;
47+
import java.util.Optional;
4548
import java.util.Set;
4649

4750
@Configuration
@@ -69,11 +72,8 @@ public ClientRegistrationRepository clientRegistrationRepository() {
6972
scopes.add("openid");
7073
scopes.add("email");
7174

72-
for (int i = 0; ; i++) {
73-
String scope = environment.getProperty(String.format("proxy.openid.scopes[%d]", i));
74-
if (scope == null) break;
75-
else scopes.add(scope);
76-
}
75+
Optional.ofNullable(EnvironmentUtils.readList(environment, "proxy.openid.scopes"))
76+
.ifPresent(scopes::addAll);
7777

7878
ClientRegistration client = ClientRegistration
7979
.withRegistrationId(REG_ID)

0 commit comments

Comments
 (0)