Fix #32587: implement container-dns for k8s

Author: LEDfan

src/main/java/eu/openanalytics/containerproxy/backend/kubernetes/KubernetesBackend.java

@@ -59,6 +59,7 @@
 import io.fabric8.kubernetes.api.model.ObjectReferenceBuilder;
 import io.fabric8.kubernetes.api.model.Pod;
 import io.fabric8.kubernetes.api.model.PodBuilder;
+import io.fabric8.kubernetes.api.model.PodDNSConfigBuilder;
 import io.fabric8.kubernetes.api.model.PodSpec;
 import io.fabric8.kubernetes.api.model.Quantity;
 import io.fabric8.kubernetes.api.model.ResourceRequirementsBuilder;
@@ -310,6 +311,11 @@ public Proxy startContainer(Authentication user, Container initialContainer, Con
 
             PodSpec podSpec = new PodSpec();
             podSpec.setContainers(Collections.singletonList(containerBuilder.build()));
+            if (spec.getDns().isPresent()) {
+                podSpec.setDnsConfig(new PodDNSConfigBuilder()
+                    .addToNameservers(spec.getDns().getValue().toArray(new String[0]))
+                    .build());
+            }
             podSpec.setVolumes(volumes);
             podSpec.setImagePullSecrets(imagePullSecrets);
 

src/test/java/eu/openanalytics/containerproxy/test/proxy/TestIntegrationOnKube.java

@@ -1503,6 +1503,35 @@ public void launchProxyWithAuthorizedAdditionalManifests() {
         }
     }
 
+    @Test
+    public void launchProxyWithDns() {
+        try (ContainerSetup k8s = new ContainerSetup("kubernetes")) {
+            String id = inst.client.startProxy("01_hello_dns");
+            Proxy proxy = inst.proxyService.getProxy(id);
+
+            PodList podList = k8s.client.pods().inNamespace(k8s.namespace).list();
+            Assertions.assertEquals(1, podList.getItems().size());
+            Pod pod = podList.getItems().get(0);
+            Assertions.assertEquals("Running", pod.getStatus().getPhase());
+            Assertions.assertEquals(k8s.namespace, pod.getMetadata().getNamespace());
+            Assertions.assertEquals("sp-pod-" + proxy.getId() + "-0", pod.getMetadata().getName());
+            Assertions.assertEquals(1, pod.getStatus().getContainerStatuses().size());
+            ContainerStatus container = pod.getStatus().getContainerStatuses().get(0);
+            Assertions.assertEquals(true, container.getReady());
+            Assertions.assertTrue(container.getImage().endsWith("openanalytics/shinyproxy-integration-test-app:latest"));
+            Assertions.assertFalse(pod.getSpec().getContainers().get(0).getSecurityContext().getPrivileged());
+            Assertions.assertEquals(List.of("9.9.9.9"), pod.getSpec().getDnsConfig().getNameservers());
+
+            inst.proxyService.stopProxy(null, proxy, true).run();
+
+            // all pods should be deleted
+            assertNoPods(k8s);
+            // all services should be deleted
+            assertNoServices(k8s);
+        }
+    }
+
+
     private void assertNoPods(ContainerSetup k8s) {
         boolean cleanedUp = Retrying.retry((c, m) -> {
             List<Pod> pods1 = k8s.client.pods().inNamespace(k8s.namespace).list().getItems();

src/test/resources/application-test-kubernetes.yml

@@ -837,6 +837,15 @@ proxy:
                resources:
                  requests:
                    storage: 5Gi
+    - id: 01_hello_dns
+      container-specs:
+        - image: "openanalytics/shinyproxy-integration-test-app"
+          cmd: [ "R", "-e", "shinyproxy::run_01_hello()" ]
+          dns:
+            - 9.9.9.9
+          port-mapping:
+            - name: default
+              port: 3838
 
 appNamespaces:
   - itest-overridden