Fix or remove TODOs

Author: LEDfan

src/main/java/eu/openanalytics/containerproxy/backend/IContainerBackend.java

@@ -96,7 +96,6 @@ default Proxy resumeProxy(Authentication user, Proxy proxy, ProxySpec proxySpec)
      */
     Map<String, URI> setupPortMappingExistingProxy(Proxy proxy, Container container, Map<Integer, Integer> portBindings) throws Exception;
 
-    // TODO move implementation to abstract class
     default Boolean supportsPause() {
         return false;
     }

src/main/java/eu/openanalytics/containerproxy/backend/dispatcher/proxysharing/ProxySharingDispatcher.java

@@ -200,12 +200,12 @@ public void stopProxy(Proxy proxy, ProxyStopReason proxyStopReason) throws Conta
 
     @Override
     public void pauseProxy(Proxy proxy) {
-        throw new IllegalStateException("Not available"); // TODO
+        throw new IllegalStateException("ProxySharingDispatcher does not support pauseProxy.");
     }
 
     @Override
     public Proxy resumeProxy(Authentication user, Proxy proxy, ProxySpec proxySpec) throws ProxyFailedToStartException {
-        throw new IllegalStateException("Not available"); // TODO
+        throw new IllegalStateException("ProxySharingDispatcher does not support resumeProxy.");
     }
 
     @Override
@@ -215,7 +215,7 @@ public boolean supportsPause() {
 
     @Override
     public Proxy addRuntimeValuesBeforeSpel(Authentication user, ProxySpec spec, Proxy proxy) {
-        return proxy; // TODO
+        return proxy;
     }
 
     @EventListener

src/main/java/eu/openanalytics/containerproxy/backend/dispatcher/proxysharing/ProxySharingScaler.java

@@ -125,6 +125,10 @@ public ProxySharingScaler(ISeatStore seatStore, ProxySpec proxySpec, IDelegatePr
         // remove httpHeaders from spec, since it's not used for DelegateProxies and may contain SpEL which cannot be resolved here
         this.proxySpec = proxySpec.toBuilder().httpHeaders(new SpelField.StringMap()).build();
         proxySpecHash = getProxySpecHash(proxySpec);
+
+        if (!specExtension.allowContainerReUse && specExtension.seatsPerContainer != 1) {
+            throw new IllegalStateException(String.format("Spec %s is invalid: when allow-container-re-use is disabled, seatsPerContainer must be exactly 1", proxySpec.getId()));
+        }
     }
 
     public static void setPublicPathPrefix(String publicPathPrefix) {
@@ -227,7 +231,6 @@ private void processReleasedSeat(SeatReleasedEvent seatReleasedEvent) {
             markDelegateProxyForRemoval(delegateProxy.getProxy().getId());
             globalEventLoop.schedule(this::reconcile);
         } else if (!specExtension.allowContainerReUse) {
-            // TODO allow only one seat if container is not allowed to be re-used
             // container cannot be re-used -> mark delegateProxy as ToRemove
             log(delegateProxy, "DelegateProxy cannot be re-used, marking for removal");
             removeSeat(delegateProxy, seatId);
@@ -335,7 +338,6 @@ private Runnable createDelegateProxyJob(DelegateProxy originalDelegateProxy) {
                 proxyBuilder.specId(proxySpec.getId());
                 long createdTimestamp = System.currentTimeMillis();
                 proxyBuilder.createdTimestamp(createdTimestamp);
-                // TODO add minimal set of runtimevalues
                 proxyBuilder.addRuntimeValue(new RuntimeValue(DelegateProxyKey.inst, true), false);
                 proxyBuilder.addRuntimeValue(new RuntimeValue(PublicPathKey.inst, getPublicPath(id)), false);
                 proxyBuilder.addRuntimeValue(new RuntimeValue(InstanceIdKey.inst, identifierService.instanceId), false);
@@ -364,7 +366,6 @@ private Runnable createDelegateProxyJob(DelegateProxy originalDelegateProxy) {
                     proxyBuilder.addContainer(container);
                 }
                 proxy = proxyBuilder.build();
-                // TODO use startupLog ?
                 log(delegateProxy, "Starting DelegateProxy");
                 proxy = containerBackend.startProxy(null, proxy, resolvedSpec, new ProxyStartupLog.ProxyStartupLogBuilder());
                 delegateProxy = originalDelegateProxy.toBuilder().proxy(proxy).build();

src/main/java/eu/openanalytics/containerproxy/backend/kubernetes/PodPatcher.java

@@ -68,7 +68,6 @@ public Pod patch(Pod pod, JsonPatch patch) {
         JsonStructure patchedPodAsJsonValue = patch.apply(podAsJsonValue);
         // 3. convert back to a pod
         return mapper.convertValue(patchedPodAsJsonValue, Pod.class);
-        // TODO catch exceptions
     }
 
     /**

src/main/java/eu/openanalytics/containerproxy/model/runtime/runtimevalues/DisplayNameKey.java

@@ -29,7 +29,6 @@ private DisplayNameKey() {
             "SHINYPROXY_DISPLAY_NAME",
             false,
             true,
-            // TODO
             false,
             true,
             true,