Skip to content

Commit 5827437

Browse files
committed
Rename Docker registry properties
1 parent 0494737 commit 5827437

4 files changed

Lines changed: 36 additions & 38 deletions

File tree

src/main/java/eu/openanalytics/containerproxy/backend/docker/DockerEngineBackend.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
import com.spotify.docker.client.DockerClient.ListContainersParam;
2424
import com.spotify.docker.client.DockerClient.RemoveContainerParam;
25-
import com.spotify.docker.client.ProgressHandler;
2625
import com.spotify.docker.client.exceptions.DockerException;
2726
import com.spotify.docker.client.exceptions.NotFoundException;
2827
import com.spotify.docker.client.messages.Container.PortMapping;
@@ -32,7 +31,6 @@
3231
import com.spotify.docker.client.messages.HostConfig;
3332
import com.spotify.docker.client.messages.HostConfig.Builder;
3433
import com.spotify.docker.client.messages.PortBinding;
35-
import com.spotify.docker.client.messages.ProgressMessage;
3634
import com.spotify.docker.client.messages.RegistryAuth;
3735
import eu.openanalytics.containerproxy.model.runtime.Container;
3836
import eu.openanalytics.containerproxy.model.runtime.ExistingContainerInfo;
@@ -238,14 +236,14 @@ private boolean isImagePresent(ContainerSpec spec) throws DockerException, Inter
238236
}
239237

240238
private void pullImage(ContainerSpec spec) throws DockerException, InterruptedException {
241-
if (spec.getDockerSwarmRegistryDomain() != null
242-
&& spec.getDockerSwarmRegistryUsername() != null
243-
&& spec.getDockerSwarmRegistryPassword() != null) {
239+
if (spec.getDockerRegistryDomain() != null
240+
&& spec.getDockerRegistryUsername() != null
241+
&& spec.getDockerRegistryPassword() != null) {
244242

245243
RegistryAuth registryAuth = RegistryAuth.builder()
246-
.serverAddress(spec.getDockerSwarmRegistryDomain())
247-
.username(spec.getDockerSwarmRegistryUsername())
248-
.password(spec.getDockerSwarmRegistryPassword())
244+
.serverAddress(spec.getDockerRegistryDomain())
245+
.username(spec.getDockerRegistryUsername())
246+
.password(spec.getDockerRegistryPassword())
249247
.build();
250248
dockerClient.pull(spec.getImage(), registryAuth, message -> {});
251249
} else {

src/main/java/eu/openanalytics/containerproxy/backend/docker/DockerSwarmBackend.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,14 @@ protected Container startContainer(ContainerSpec spec, Proxy proxy) throws Excep
137137
}
138138

139139
String serviceId;
140-
if (spec.getDockerSwarmRegistryDomain() != null
141-
&& spec.getDockerSwarmRegistryUsername() != null
142-
&& spec.getDockerSwarmRegistryPassword() != null) {
140+
if (spec.getDockerRegistryDomain() != null
141+
&& spec.getDockerRegistryUsername() != null
142+
&& spec.getDockerRegistryPassword() != null) {
143143

144144
RegistryAuth registryAuth = RegistryAuth.builder()
145-
.serverAddress(spec.getDockerSwarmRegistryDomain())
146-
.username(spec.getDockerSwarmRegistryUsername())
147-
.password(spec.getDockerSwarmRegistryPassword())
145+
.serverAddress(spec.getDockerRegistryDomain())
146+
.username(spec.getDockerRegistryUsername())
147+
.password(spec.getDockerRegistryPassword())
148148
.build();
149149
serviceId = dockerClient.createService(serviceSpecBuilder.build(), registryAuth).id();
150150
} else {

src/main/java/eu/openanalytics/containerproxy/model/spec/ContainerSpec.java

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ public class ContainerSpec {
4646
private Map<String, String> labels = new HashMap<>();
4747
private Map<String, String> settings = new HashMap<>();
4848
private List<DockerSwarmSecret> dockerSwarmSecrets = new ArrayList();
49-
private String dockerSwarmRegistryDomain;
50-
private String dockerSwarmRegistryUsername;
51-
private String dockerSwarmRegistryPassword;
49+
private String dockerRegistryDomain;
50+
private String dockerRegistryUsername;
51+
private String dockerRegistryPassword;
5252

5353
public String getImage() {
5454
return image;
@@ -167,28 +167,28 @@ public void setDockerSwarmSecrets(List<DockerSwarmSecret> dockerSwarmSecrets) {
167167
this.dockerSwarmSecrets = dockerSwarmSecrets;
168168
}
169169

170-
public String getDockerSwarmRegistryDomain() {
171-
return dockerSwarmRegistryDomain;
170+
public String getDockerRegistryDomain() {
171+
return dockerRegistryDomain;
172172
}
173173

174-
public void setDockerSwarmRegistryDomain(String dockerSwarmRegistryDomain) {
175-
this.dockerSwarmRegistryDomain = dockerSwarmRegistryDomain;
174+
public void setDockerRegistryDomain(String dockerRegistryDomain) {
175+
this.dockerRegistryDomain = dockerRegistryDomain;
176176
}
177177

178-
public String getDockerSwarmRegistryUsername() {
179-
return dockerSwarmRegistryUsername;
178+
public String getDockerRegistryUsername() {
179+
return dockerRegistryUsername;
180180
}
181181

182-
public void setDockerSwarmRegistryUsername(String dockerSwarmRegistryUsername) {
183-
this.dockerSwarmRegistryUsername = dockerSwarmRegistryUsername;
182+
public void setDockerRegistryUsername(String dockerRegistryUsername) {
183+
this.dockerRegistryUsername = dockerRegistryUsername;
184184
}
185185

186-
public String getDockerSwarmRegistryPassword() {
187-
return dockerSwarmRegistryPassword;
186+
public String getDockerRegistryPassword() {
187+
return dockerRegistryPassword;
188188
}
189189

190-
public void setDockerSwarmRegistryPassword(String dockerSwarmRegistryPassword) {
191-
this.dockerSwarmRegistryPassword = dockerSwarmRegistryPassword;
190+
public void setDockerRegistryPassword(String dockerRegistryPassword) {
191+
this.dockerRegistryPassword = dockerRegistryPassword;
192192
}
193193

194194
public void copy(ContainerSpec target) {
@@ -224,9 +224,9 @@ public void copy(ContainerSpec target) {
224224
if (target.getDockerSwarmSecrets() == null) target.setDockerSwarmSecrets(new ArrayList<>());
225225
target.getDockerSwarmSecrets().addAll(dockerSwarmSecrets);
226226
}
227-
target.setDockerSwarmRegistryDomain(dockerSwarmRegistryDomain);
228-
target.setDockerSwarmRegistryUsername(dockerSwarmRegistryUsername);
229-
target.setDockerSwarmRegistryPassword(dockerSwarmRegistryPassword);
227+
target.setDockerRegistryDomain(dockerRegistryDomain);
228+
target.setDockerRegistryUsername(dockerRegistryUsername);
229+
target.setDockerRegistryPassword(dockerRegistryPassword);
230230
target.setTargetPath(targetPath);
231231
}
232232
}

src/main/java/eu/openanalytics/containerproxy/spec/expression/ExpressionAwareContainerSpec.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -129,18 +129,18 @@ public List<DockerSwarmSecret> getDockerSwarmSecrets() {
129129
}
130130

131131
@Override
132-
public String getDockerSwarmRegistryDomain() {
133-
return source.getDockerSwarmRegistryDomain();
132+
public String getDockerRegistryDomain() {
133+
return source.getDockerRegistryDomain();
134134
}
135135

136136
@Override
137-
public String getDockerSwarmRegistryUsername() {
138-
return source.getDockerSwarmRegistryUsername();
137+
public String getDockerRegistryUsername() {
138+
return source.getDockerRegistryUsername();
139139
}
140140

141141
@Override
142-
public String getDockerSwarmRegistryPassword() {
143-
return source.getDockerSwarmRegistryPassword();
142+
public String getDockerRegistryPassword() {
143+
return source.getDockerRegistryPassword();
144144
}
145145

146146
@Override

0 commit comments

Comments
 (0)