Add more misconfiguration warnings

Author: LEDfan

src/main/java/eu/openanalytics/containerproxy/ContainerProxyApplication.java

@@ -76,6 +76,7 @@
 import java.util.Properties;
 import java.util.concurrent.Executor;
 
+import static eu.openanalytics.containerproxy.api.ApiSecurityService.PROP_API_SECURITY_HIDE_SPEC_DETAILS;
 import static eu.openanalytics.containerproxy.service.ProxyService.PROPERTY_STOP_PROXIES_ON_SHUTDOWN;
 
 @EnableScheduling
@@ -163,6 +164,13 @@ public void init() {
 			}
 		}
 
+		boolean hideSpecDetails = environment.getProperty(PROP_API_SECURITY_HIDE_SPEC_DETAILS, Boolean.class, true);
+		if (!hideSpecDetails) {
+			log.warn("WARNING: Insecure configuration detected: The API is configured to return the full spec of proxies, " +
+					"this may contain sensitive values such as the container image, secret environment variables etc. " +
+					"Remove the proxy.api-security.hide-spec-details property to enable API security.");
+		}
+
 	}
 
 	@Autowired(required = false)

src/main/java/eu/openanalytics/containerproxy/api/ApiSecurityService.java

@@ -21,30 +21,19 @@
 package eu.openanalytics.containerproxy.api;
 
 import eu.openanalytics.containerproxy.model.Views;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.springframework.core.env.Environment;
 import org.springframework.http.converter.json.MappingJacksonValue;
 import org.springframework.stereotype.Service;
 
 @Service
 public class ApiSecurityService {
 
-    private static final String PROP_API_SECURITY_HIDE_SPEC_DETAILS = "proxy.api-security.hide-spec-details";
+    public static final String PROP_API_SECURITY_HIDE_SPEC_DETAILS = "proxy.api-security.hide-spec-details";
 
     private final boolean hideSpecDetails;
 
-    private final Logger logger = LoggerFactory.getLogger(getClass());
-
     public ApiSecurityService(Environment environment) {
         hideSpecDetails = environment.getProperty(PROP_API_SECURITY_HIDE_SPEC_DETAILS, Boolean.class, true);
-        if (!hideSpecDetails) {
-            logger.warn("WARNING!");
-            logger.warn("WARNING! The API is configured to return the full spec of proxies, " +
-                    "this may contain sensitive values such as the container image, secret environment variables etc. " +
-                    "Remove the proxy.api-security.hide-spec-details property to enable API security.");
-            logger.warn("WARNING!");
-        }
     }
 
     public MappingJacksonValue protectSpecs(Object specs) {

src/main/java/eu/openanalytics/containerproxy/service/ProxyService.java

@@ -115,7 +115,7 @@ public class ProxyService {
 
 	private boolean stopAppsOnShutdown;
 
-	private static final String PROPERTY_STOP_PROXIES_ON_SHUTDOWN = "proxy.stop-proxies-on-shutdown";
+	public static final String PROPERTY_STOP_PROXIES_ON_SHUTDOWN = "proxy.stop-proxies-on-shutdown";
 
 	private final Set<String> actionsInProgress = new HashSet<>();
 	private Pair<String, Instant> lastStop = null;