Skip to content

Commit 19c5b23

Browse files
committed
Hide some runtimeValues from API
1 parent 54d54cf commit 19c5b23

14 files changed

Lines changed: 25 additions & 3 deletions

src/main/java/eu/openanalytics/containerproxy/model/runtime/Proxy.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,9 @@ public Map<String, String> getRuntimeValuesJson() {
129129
// only output key<->value in JSON
130130
Map<String, String> result = new HashMap<>();
131131
for (RuntimeValue value : runtimeValues.values()) {
132-
result.put(value.getKey().getKeyAsEnvVar(), value.getValue());
132+
if (value.getKey().getIncludeInApi()) {
133+
result.put(value.getKey().getKeyAsEnvVar(), value.getValue());
134+
}
133135
}
134136
return result;
135137
}

src/main/java/eu/openanalytics/containerproxy/model/runtime/runtimevalues/CreatedTimestampKey.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ private CreatedTimestampKey() {
2828
false,
2929
true,
3030
false,
31+
true,
3132
true, String.class);
3233
}
3334

src/main/java/eu/openanalytics/containerproxy/model/runtime/runtimevalues/HeartbeatTimeoutKey.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ private HeartbeatTimeoutKey() {
2828
false,
2929
true,
3030
false,
31+
true,
3132
true, Long.class);
3233
}
3334

src/main/java/eu/openanalytics/containerproxy/model/runtime/runtimevalues/InstanceIdKey.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ private InstanceIdKey() {
2828
true,
2929
false,
3030
false,
31+
true,
3132
true, String.class);
3233
}
3334

src/main/java/eu/openanalytics/containerproxy/model/runtime/runtimevalues/MaxLifetimeKey.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ private MaxLifetimeKey() {
2828
false,
2929
true,
3030
false,
31+
true,
3132
true, Long.class);
3233
}
3334

src/main/java/eu/openanalytics/containerproxy/model/runtime/runtimevalues/ParameterNamesKey.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,11 @@ public class ParameterNamesKey extends RuntimeValueKey<ParameterNames> {
2626

2727
public ParameterNamesKey() {
2828
super("openanalytics.eu/sp-parameters-names",
29-
"SHINYPROXY_PARAMETER_NAME",
29+
"SHINYPROXY_PARAMETER_NAMES",
3030
false,
3131
false,
3232
false,
33+
true, // IMPORTANT: only the names of the values may be exposed through the API
3334
false, ParameterNames.class);
3435
}
3536

src/main/java/eu/openanalytics/containerproxy/model/runtime/runtimevalues/ParameterValuesKey.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ public ParameterValuesKey() {
3030
false,
3131
false, // TODO
3232
false,
33+
false, // IMPORTANT: the actual values may not be exposed through the API
3334
false, ParameterValues.class);
3435
}
3536

src/main/java/eu/openanalytics/containerproxy/model/runtime/runtimevalues/ProxiedAppKey.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ private ProxiedAppKey() {
2828
true,
2929
false,
3030
false,
31+
false, // no need to expose in API
3132
true, String.class);
3233
}
3334

src/main/java/eu/openanalytics/containerproxy/model/runtime/runtimevalues/ProxyIdKey.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ private ProxyIdKey() {
2828
false,
2929
true,
3030
false,
31+
false, // no need to expose in API
3132
true, String.class);
3233
}
3334

src/main/java/eu/openanalytics/containerproxy/model/runtime/runtimevalues/ProxySpecIdKey.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ private ProxySpecIdKey() {
2828
false,
2929
true,
3030
false,
31+
false, // no need to expose in API
3132
true, String.class);
3233
}
3334

0 commit comments

Comments
 (0)