MINOR - Column name Length patch (#26530)

* chore(bulkEndpoint): create bulk bundle suite body object

* patch(columnName): remove maxLength for column name

* patch(columnName): remove files from commit

* patch(columnName): remove unused code

* fix unit tests

---------

Co-authored-by: ulixius9 <mayursingal9@gmail.com>

Author: TeddyCr

ingestion/src/metadata/ingestion/models/custom_basemodel_validation.py

@@ -22,7 +22,6 @@
 RESERVED_COLON_KEYWORD = "__reserved__colon__"
 RESERVED_ARROW_KEYWORD = "__reserved__arrow__"
 RESERVED_QUOTE_KEYWORD = "__reserved__quote__"
-COLUMN_NAME_MAX_LENGTH = 256
 
 
 class TransformDirection(Enum):
@@ -149,13 +148,6 @@ def get_transformer(model: Optional[Any]) -> Optional[Callable]:
     return None
 
 
-def _truncate_if_encoding(value: str, transformer) -> str:
-    """Truncate encoded value to COLUMN_NAME_MAX_LENGTH if encoding."""
-    if transformer == replace_separators and len(value) > COLUMN_NAME_MAX_LENGTH:
-        return value[:COLUMN_NAME_MAX_LENGTH]
-    return value
-
-
 def transform_all_names(obj, transformer):
     """Transform all name fields recursively"""
     if not obj:
@@ -164,9 +156,9 @@ def transform_all_names(obj, transformer):
     # Transform name field if it exists (supports both obj.name.root and obj.root)
     name = getattr(obj, "name", None)
     if name and hasattr(name, "root") and name.root is not None:
-        name.root = _truncate_if_encoding(transformer(name.root), transformer)
+        name.root = transformer(name.root)
     elif hasattr(obj, "root") and obj.root is not None:
-        obj.root = _truncate_if_encoding(transformer(obj.root), transformer)
+        obj.root = transformer(obj.root)
 
     # Transform nested collections in a single loop each
     for attr_name in ["columns", "children"]:
@@ -183,12 +175,11 @@ def transform_all_names(obj, transformer):
             for constraint in table_constraints:
                 if hasattr(constraint, "columns"):
                     constraint.columns = [
-                        _truncate_if_encoding(transformer(col), transformer)
-                        for col in constraint.columns
+                        transformer(col) for col in constraint.columns
                     ]
 
     if transformer == replace_separators and type(name) == str:
-        obj.name = _truncate_if_encoding(transformer(name), transformer)
+        obj.name = transformer(name)
 
 
 def transform_entity_names(entity: Any, model: Optional[Any]) -> Any:
@@ -201,15 +192,11 @@ def transform_entity_names(entity: Any, model: Optional[Any]) -> Any:
 
     # Root attribute handling
     if hasattr(entity, "root") and entity.root is not None:
-        if model_name.startswith("Create"):
-            encoded = replace_separators(entity.root)
-            entity.root = (
-                encoded[:COLUMN_NAME_MAX_LENGTH]
-                if len(encoded) > COLUMN_NAME_MAX_LENGTH
-                else encoded
-            )
-        else:
-            entity.root = revert_separators(entity.root)
+        entity.root = (
+            replace_separators(entity.root)
+            if model_name.startswith("Create")
+            else revert_separators(entity.root)
+        )
         return entity
 
     # Get model-specific transformer

ingestion/tests/unit/models/test_custom_basemodel_validation.py

@@ -992,131 +992,6 @@ def test_dashboard_datamodel_round_trip_validation(self):
                 self.assertEqual(fetch_result.columns[0].name.root, original_name)
 
 
-class TestColumnNameEncodingTruncation:
-    """
-    Test that column names expanded beyond 256 chars by replace_separators
-    are truncated to fit the ColumnName maxLength constraint.
-
-    Real-world scenario: PowerBI column names with double quotes (e.g. survey
-    questions) where each '"' expands to '__reserved__quote__' (+19 chars).
-    """
-
-    REAL_WORLD_COLUMN_NAME = (
-        "Q8 (Root Cause) - Was the communication clear and structured? "
-        'following the relevant stages of communication, a "what, why, how" '
-        "format for the answer, and any major grammar/language mistakes "
-        "affecting communication. | Human Support - 33%"
-    )
-
-    def test_replace_separators_expands_name_beyond_256(self):
-        encoded = replace_separators(self.REAL_WORLD_COLUMN_NAME)
-        assert len(self.REAL_WORLD_COLUMN_NAME) <= 256
-        assert len(encoded) > 256
-
-    def test_create_table_request_truncates_encoded_column_name(self):
-        from metadata.generated.schema.type.basic import (
-            EntityName,
-            FullyQualifiedEntityName,
-        )
-
-        req = CreateTableRequest(
-            name=EntityName("test_table"),
-            databaseSchema=FullyQualifiedEntityName("service.db.schema"),
-            columns=[
-                Column(
-                    name=ColumnName(self.REAL_WORLD_COLUMN_NAME),
-                    displayName=self.REAL_WORLD_COLUMN_NAME,
-                    dataType=DataType.STRING,
-                )
-            ],
-        )
-        encoded_root = req.columns[0].name.root
-        assert "__reserved__quote__" in encoded_root
-        assert len(encoded_root) <= 256
-
-    def test_create_dashboard_data_model_truncates_encoded_column_name(self):
-        from metadata.generated.schema.api.data.createDashboardDataModel import (
-            CreateDashboardDataModelRequest,
-        )
-        from metadata.generated.schema.entity.data.dashboardDataModel import (
-            DataModelType,
-        )
-        from metadata.generated.schema.type.basic import (
-            EntityName,
-            FullyQualifiedEntityName,
-        )
-
-        req = CreateDashboardDataModelRequest(
-            name=EntityName("test_model"),
-            displayName="Test Model",
-            dataModelType=DataModelType.PowerBIDataModel,
-            service=FullyQualifiedEntityName("service.test"),
-            columns=[
-                Column(
-                    name=ColumnName(self.REAL_WORLD_COLUMN_NAME),
-                    displayName=self.REAL_WORLD_COLUMN_NAME,
-                    dataType=DataType.STRING,
-                )
-            ],
-        )
-        encoded_root = req.columns[0].name.root
-        assert "__reserved__quote__" in encoded_root
-        assert len(encoded_root) <= 256
-
-    def test_short_names_with_special_chars_not_truncated(self):
-        short_name = 'column "with" quotes'
-        encoded = replace_separators(short_name)
-        assert len(encoded) <= 256
-
-        from metadata.generated.schema.type.basic import (
-            EntityName,
-            FullyQualifiedEntityName,
-        )
-
-        req = CreateTableRequest(
-            name=EntityName("test_table"),
-            databaseSchema=FullyQualifiedEntityName("service.db.schema"),
-            columns=[
-                Column(
-                    name=ColumnName(short_name),
-                    displayName=short_name,
-                    dataType=DataType.STRING,
-                )
-            ],
-        )
-        assert req.columns[0].name.root == encoded
-
-    def test_names_without_special_chars_unchanged(self):
-        plain_name = "a" * 200
-        from metadata.generated.schema.type.basic import (
-            EntityName,
-            FullyQualifiedEntityName,
-        )
-
-        req = CreateTableRequest(
-            name=EntityName("test_table"),
-            databaseSchema=FullyQualifiedEntityName("service.db.schema"),
-            columns=[
-                Column(
-                    name=ColumnName(plain_name),
-                    displayName=plain_name,
-                    dataType=DataType.STRING,
-                )
-            ],
-        )
-        assert req.columns[0].name.root == plain_name
-
-    def test_transform_entity_names_root_attribute_truncated(self):
-        long_name_with_quotes = "a" * 230 + '"' + "b" * 10 + '"'
-        assert len(long_name_with_quotes) <= 256
-        encoded = replace_separators(long_name_with_quotes)
-        assert len(encoded) > 256
-
-        cn = ColumnName(long_name_with_quotes)
-        result = transform_entity_names(cn, ColumnName)
-        assert len(result.root) <= 256
-
-
 if __name__ == "__main__":
     import unittest
 

openmetadata-spec/src/main/resources/json/schema/entity/data/table.json

@@ -243,7 +243,6 @@
       "description": "Local name (not fully qualified name) of the column. ColumnName is `-` when the column is not named in struct dataType. For example, BigQuery supports struct with unnamed fields.",
       "type": "string",
       "minLength": 1,
-      "maxLength": 256,
       "pattern": "^((?!::).)*$"
     },
     "partitionIntervalTypes": {