Fix: flaky domain rename data products count assertion (#26542)

* Fix: flaky domain rename data products count assertion

After a domain rename, the search index update for subdomain-level data
products can lag behind the DB update due to async reindexing by the
governance-bot. The `verifyDataProductsCount` helper was doing a one-shot
`textContent()` + `toBe()` assertion that failed when the search index
hadn't converged yet.

Changes:
- Update `verifyDataProductsCount` to accept optional `{ apiContext, domainFqn }`
  that uses `expect.poll()` to poll the data product search API until
  `hits.total.value` matches the expected count (following the same pattern
  used in glossary.ts, alert.ts, and other polling utilities)
- Switch from one-shot `toBe()` to auto-retrying `toHaveText()` for the UI check
- Pass polling options in the post-rename assertion in Domains.spec.ts

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add HTTP status check in search API poll

Check response.ok() before parsing JSON in the expect.poll callback
to avoid silently treating 4xx/5xx errors as count=0.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove custom timeout from toHaveText assertion

The expect.poll already ensures the search index has converged before
the UI check, so the default Playwright timeout is sufficient.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Siddhant <siddhant@MacBook-Pro-290.local>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
(cherry picked from commit 85ad580)

Author: 3 people

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Domains.spec.ts

@@ -2035,7 +2035,11 @@ test.describe('Domain Rename Comprehensive Tests', () => {
       );
 
       // Verify data products count is preserved after rename
-      await verifyDataProductsCount(page, 2);
+      // Poll search API first since index may lag after domain rename
+      await verifyDataProductsCount(page, 2, {
+        apiContext,
+        domainFqn: newDomainName,
+      });
 
       // Verify both data products are visible (scope to container)
       const dataProductsContainer = page.locator('.explore-search-card');

openmetadata-ui/src/main/resources/ui/playwright/utils/domain.ts

@@ -1338,22 +1338,69 @@ export const createDataProductForSubDomain = async (
 /**
  * Verifies the data products count displayed in the Data Products tab.
  * Clicks on the Data Products tab and checks if the count matches the expected value.
+ * If apiContext and domainFqn are provided, polls the search API first to wait for
+ * index convergence (e.g. after domain rename).
  */
 export const verifyDataProductsCount = async (
   page: Page,
-  expectedCount: number
+  expectedCount: number,
+  options?: { apiContext: APIRequestContext; domainFqn: string }
 ) => {
+  if (options) {
+    const { apiContext, domainFqn } = options;
+    const queryFilter = JSON.stringify({
+      query: {
+        bool: {
+          must: [
+            {
+              bool: {
+                should: [
+                  { term: { 'domains.fullyQualifiedName': domainFqn } },
+                  {
+                    prefix: {
+                      'domains.fullyQualifiedName': `${domainFqn}.`,
+                    },
+                  },
+                ],
+              },
+            },
+          ],
+        },
+      },
+    });
+    const searchUrl = `/api/v1/search/query?q=&index=data_product_search_index&from=0&size=0&deleted=false&query_filter=${encodeURIComponent(queryFilter)}`;
+
+    await expect
+      .poll(
+        async () => {
+          const response = await apiContext.get(searchUrl);
+
+          if (!response.ok()) {
+            return -1;
+          }
+
+          const data = await response.json();
+
+          return data.hits?.total?.value ?? 0;
+        },
+        {
+          message: `Wait for data product search index to show ${expectedCount} results for domain "${domainFqn}"`,
+          timeout: 30_000,
+          intervals: [2_000, 3_000, 5_000],
+        }
+      )
+      .toEqual(expectedCount);
+  }
+
   await page.getByTestId('data_products').click();
   await waitForAllLoadersToDisappear(page);
   await page.waitForLoadState('networkidle');
 
   const dataProductCountElement = page
     .getByTestId('data_products')
     .getByTestId('count');
-  const countText = await dataProductCountElement.textContent();
-  const displayedCount = parseInt(countText ?? '0', 10);
 
-  expect(displayedCount).toBe(expectedCount);
+  await expect(dataProductCountElement).toHaveText(String(expectedCount));
 };
 
 /**