Skip to content

Commit a68b342

Browse files
committed
address comments
1 parent 9345d90 commit a68b342

2 files changed

Lines changed: 24 additions & 8 deletions

File tree

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/DataQualityDashboard.spec.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,22 @@ test.beforeAll('setup pre-test', async ({ browser }) => {
158158
await afterAction();
159159
});
160160

161+
test.afterAll('cleanup', async ({ browser }) => {
162+
const { apiContext, afterAction } = await createNewPage(browser);
163+
164+
await table1.delete(apiContext);
165+
await table2.delete(apiContext);
166+
await table3.delete(apiContext);
167+
await user1.delete(apiContext);
168+
await glossaryTerm.delete(apiContext);
169+
await glossary.delete(apiContext);
170+
await tag.delete(apiContext);
171+
await tier.delete(apiContext);
172+
await classification.delete(apiContext);
173+
174+
await afterAction();
175+
});
176+
161177
const waitForDashboardApiResponses = (page: Page, key: string) => {
162178
const testCaseStatusResponse = page.waitForResponse(
163179
`/api/v1/dataQuality/testSuites/dataQualityReport?q=*${key}*&index=testCase&aggregationQuery=bucketName%3Dstatus%3AaggType%3Dterms%3Afield%3DtestCaseResult.testCaseStatus`

openmetadata-ui/src/main/resources/ui/src/components/DataQuality/DataQualityDashboard/DataQualityDashboard.component.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -706,23 +706,23 @@ const DataQualityDashboard = ({
706706
/>
707707
)}
708708

709-
{showDataProductsFilter && (
709+
{showGlossaryTermsFilter && (
710710
<SearchDropdown
711711
hideCounts
712-
label={t('label.data-product')}
713-
searchKey="dataProduct"
712+
label={t('label.glossary-term')}
713+
searchKey="glossaryTerms"
714714
triggerButtonSize="middle"
715-
{...dataProducts}
715+
{...glossaryTerms}
716716
/>
717717
)}
718718

719-
{showGlossaryTermsFilter && (
719+
{showDataProductsFilter && (
720720
<SearchDropdown
721721
hideCounts
722-
label={t('label.glossary-term')}
723-
searchKey="glossaryTerms"
722+
label={t('label.data-product')}
723+
searchKey="dataProduct"
724724
triggerButtonSize="middle"
725-
{...glossaryTerms}
725+
{...dataProducts}
726726
/>
727727
)}
728728
</div>

0 commit comments

Comments
 (0)