Fixes 25794: Global Domain Filter translation (#25982)

* Global Domain Filter translation

* remove repeated code for domainDisplayName

* memoize domainDisplayName

* add unit test for util function

* fix failing jest test

---------

Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
(cherry picked from commit db104e5)

Author: 2 people

openmetadata-ui/src/main/resources/ui/src/components/MyData/CustomizableComponents/CustomiseLandingPageHeader/CustomiseLandingPageHeader.tsx

@@ -39,7 +39,7 @@ import {
   CustomPrevArrow,
 } from '../../../../utils/CustomizableLandingPageUtils';
 import entityUtilClassBase from '../../../../utils/EntityUtilClassBase';
-import { getEntityName } from '../../../../utils/EntityUtils';
+import { getDomainDisplayName } from '../../../../utils/EntityUtils';
 import serviceUtilClassBase from '../../../../utils/ServiceUtilClassBase';
 import { showErrorToast } from '../../../../utils/ToastUtils';
 import DomainSelectableList from '../../../common/DomainSelectableList/DomainSelectableList.component';
@@ -138,6 +138,11 @@ const CustomiseLandingPageHeader = ({
     [updateActiveDomain, navigate]
   );
 
+  const domainDisplayName = useMemo(
+    () => getDomainDisplayName(activeDomainEntityRef, activeDomain),
+    [activeDomainEntityRef, activeDomain, t]
+  );
+
   const navigateToEntity = (data: {
     entityType: string;
     fullyQualifiedName: string;
@@ -221,9 +226,7 @@ const CustomiseLandingPageHeader = ({
                     width={22}
                   />
                   <Typography.Text className="text-sm font-medium domain-title">
-                    {activeDomainEntityRef
-                      ? getEntityName(activeDomainEntityRef)
-                      : activeDomain}
+                    {domainDisplayName}
                   </Typography.Text>
                   <DropdownIcon
                     className="dropdown-icon"

openmetadata-ui/src/main/resources/ui/src/components/NavBar/NavBar.test.tsx

@@ -174,6 +174,7 @@ jest.mock('../../utils/EntityUtilClassBase', () => ({
 
 jest.mock('../../utils/EntityUtils', () => ({
   getEntityName: jest.fn().mockReturnValue('MockedEntityName'),
+  getDomainDisplayName: jest.fn().mockReturnValue('All Domains'),
 }));
 
 jest.mock(

openmetadata-ui/src/main/resources/ui/src/components/NavBar/NavBar.tsx

@@ -66,7 +66,7 @@ import {
 } from '../../utils/BrowserNotificationUtils';
 import { getCustomPropertyEntityPathname } from '../../utils/CustomProperty.utils';
 import entityUtilClassBase from '../../utils/EntityUtilClassBase';
-import { getEntityName } from '../../utils/EntityUtils';
+import { getDomainDisplayName } from '../../utils/EntityUtils';
 import {
   getEntityFQN,
   getEntityType,
@@ -431,6 +431,11 @@ const NavBar = () => {
     []
   );
 
+  const domainDisplayName = useMemo(
+    () => getDomainDisplayName(activeDomainEntityRef, activeDomain),
+    [activeDomainEntityRef, activeDomain, t]
+  );
+
   const handleLanguageChange = useCallback(({ key }: MenuInfo) => {
     i18next.changeLanguage(key);
     setPreference({ language: key as SupportedLocales });
@@ -498,9 +503,7 @@ const NavBar = () => {
                       width={20}
                     />
                     <Typography.Text ellipsis className="domain-text">
-                      {activeDomainEntityRef
-                        ? getEntityName(activeDomainEntityRef)
-                        : activeDomain}
+                      {domainDisplayName}
                     </Typography.Text>
                     <DropDownIcon width={12} />
                   </Button>

openmetadata-ui/src/main/resources/ui/src/utils/EntityUtils.test.tsx

@@ -12,6 +12,7 @@
  */
 import { render } from '@testing-library/react';
 import { startCase } from 'lodash';
+import { DEFAULT_DOMAIN_VALUE } from '../constants/constants';
 import { EntityTabs, EntityType } from '../enums/entity.enum';
 import { ExplorePageTabs } from '../enums/Explore.enum';
 import { ServiceCategory } from '../enums/service.enum';
@@ -22,6 +23,7 @@ import {
   columnSorter,
   getBreadcrumbForTestSuite,
   getColumnSorter,
+  getDomainDisplayName,
   getEntityBreadcrumbs,
   getEntityLinkFromType,
   getEntityOverview,
@@ -56,6 +58,7 @@ import { getServiceRouteFromServiceType } from './ServiceUtils';
 import { getTierTags } from './TableUtils';
 
 jest.mock('../constants/constants', () => ({
+  DEFAULT_DOMAIN_VALUE: 'All Domains',
   getEntityDetailsPath: jest.fn(),
   getServiceDetailsPath: jest.fn(),
 }));
@@ -83,6 +86,16 @@ jest.mock('./ExportUtilClassBase', () => ({
   },
 }));
 
+jest.mock('i18next', () => ({
+  t: jest.fn((key) => {
+    const translations: Record<string, string> = {
+      'label.all-domain-plural': 'All Domains',
+    };
+
+    return translations[key] || key;
+  }),
+}));
+
 jest.mock('../components/Tag/TagsV1/TagsV1.component', () => ({
   __esModule: true,
   default: jest.fn(),
@@ -595,4 +608,64 @@ describe('EntityUtils unit tests', () => {
       });
     });
   });
+
+  describe('getDomainDisplayName', () => {
+    it('should return entity name when activeDomainEntityRef is provided', () => {
+      const mockEntityRef = {
+        id: '123',
+        name: 'Engineering',
+        displayName: 'Engineering Domain',
+        type: 'domain',
+      };
+
+      const result = getDomainDisplayName(mockEntityRef);
+
+      expect(result).toBe('Engineering Domain');
+    });
+
+    it('should return entity name without displayName when activeDomainEntityRef has only name', () => {
+      const mockEntityRef = {
+        id: '123',
+        name: 'Engineering',
+        type: 'domain',
+      };
+
+      const result = getDomainDisplayName(mockEntityRef);
+
+      expect(result).toBe('Engineering');
+    });
+
+    it('should return translated "All Domains" when activeDomain is DEFAULT_DOMAIN_VALUE', () => {
+      const result = getDomainDisplayName(undefined, DEFAULT_DOMAIN_VALUE);
+
+      expect(result).toBe('All Domains');
+    });
+
+    it('should return custom domain name when activeDomain is a custom value', () => {
+      const customDomain = 'custom-domain';
+
+      const result = getDomainDisplayName(undefined, customDomain);
+
+      expect(result).toBe(customDomain);
+    });
+
+    it('should return undefined when both parameters are undefined', () => {
+      const result = getDomainDisplayName();
+
+      expect(result).toBe(undefined);
+    });
+
+    it('should prioritize activeDomainEntityRef over activeDomain', () => {
+      const mockEntityRef = {
+        id: '123',
+        name: 'Engineering',
+        displayName: 'Engineering Domain',
+        type: 'domain',
+      };
+
+      const result = getDomainDisplayName(mockEntityRef, DEFAULT_DOMAIN_VALUE);
+
+      expect(result).toBe('Engineering Domain');
+    });
+  });
 });

openmetadata-ui/src/main/resources/ui/src/utils/EntityUtils.tsx

@@ -49,6 +49,7 @@ import {
 import TagsV1 from '../components/Tag/TagsV1/TagsV1.component';
 import { FQN_SEPARATOR_CHAR } from '../constants/char.constants';
 import {
+  DEFAULT_DOMAIN_VALUE,
   NO_DATA,
   PLACEHOLDER_ROUTE_ENTITY_TYPE,
   PLACEHOLDER_ROUTE_FQN,
@@ -176,6 +177,19 @@ export const getEntityName = (entity?: {
   return entity?.displayName || entity?.name || '';
 };
 
+export const getDomainDisplayName = (
+  activeDomainEntityRef?: EntityReference,
+  activeDomain?: string
+) => {
+  if (activeDomainEntityRef) {
+    return getEntityName(activeDomainEntityRef);
+  }
+
+  return activeDomain === DEFAULT_DOMAIN_VALUE
+    ? t('label.all-domain-plural')
+    : activeDomain;
+};
+
 export const getEntityLabel = (entity: {
   displayName?: string;
   name?: string;