Skip to content

Commit 8060733

Browse files
committed
fix: remove unused path parameter (#25825)
* fix: remove unused path parameter * fix: remove extra path parameter from feed resource * fix: remove extra path parameter in team resource * fix: remove duplicate resource * fix: remove duplicate resource * fix: test-container errror * fix: testContainer version * fix: remove unsued body (cherry picked from commit dfa632d)
1 parent bcd4500 commit 8060733

8 files changed

Lines changed: 20 additions & 21 deletions

File tree

openmetadata-integration-tests/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,25 +41,25 @@
4141
<dependency>
4242
<groupId>org.testcontainers</groupId>
4343
<artifactId>testcontainers</artifactId>
44-
<version>1.20.4</version>
44+
<version>1.21.4</version>
4545
<scope>test</scope>
4646
</dependency>
4747
<dependency>
4848
<groupId>org.testcontainers</groupId>
4949
<artifactId>postgresql</artifactId>
50-
<version>1.20.4</version>
50+
<version>1.21.4</version>
5151
<scope>test</scope>
5252
</dependency>
5353
<dependency>
5454
<groupId>org.testcontainers</groupId>
5555
<artifactId>mysql</artifactId>
56-
<version>1.20.4</version>
56+
<version>1.21.4</version>
5757
<scope>test</scope>
5858
</dependency>
5959
<dependency>
6060
<groupId>org.testcontainers</groupId>
6161
<artifactId>elasticsearch</artifactId>
62-
<version>1.20.4</version>
62+
<version>1.21.4</version>
6363
<scope>test</scope>
6464
</dependency>
6565
<dependency>
@@ -71,13 +71,13 @@
7171
<dependency>
7272
<groupId>org.testcontainers</groupId>
7373
<artifactId>k3s</artifactId>
74-
<version>1.20.4</version>
74+
<version>1.21.4</version>
7575
<scope>test</scope>
7676
</dependency>
7777
<dependency>
7878
<groupId>org.testcontainers</groupId>
7979
<artifactId>junit-jupiter</artifactId>
80-
<version>1.20.4</version>
80+
<version>1.21.4</version>
8181
<scope>test</scope>
8282
</dependency>
8383
<!-- Kubernetes client for K8s integration tests -->

openmetadata-mcp/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<assertj-core.version>3.27.7</assertj-core.version>
2020
<okhttp.version>4.12.0</okhttp.version>
2121
<awaitility.version>4.2.2</awaitility.version>
22-
<testcontainers.version>1.20.4</testcontainers.version>
22+
<testcontainers.version>1.21.4</testcontainers.version>
2323
<jetty.version>12.1.1</jetty.version>
2424
</properties>
2525

openmetadata-sdk/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<mockito.version>5.5.0</mockito.version>
2323
<slf4j.version>2.0.9</slf4j.version>
2424
<lombok.version>1.18.30</lombok.version>
25-
<testcontainers.version>1.19.3</testcontainers.version>
25+
<testcontainers.version>1.21.4</testcontainers.version>
2626
<jwt.version>4.4.0</jwt.version>
2727
<flyway.version>9.22.3</flyway.version>
2828
<json.version>20240303</json.version>

openmetadata-service/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
<sonar.junit.reportPaths>${project.basedir}/target/surefire-reports</sonar.junit.reportPaths>
1717
<sonar.coverage.jacoco.xmlReportPaths>${project.basedir}/target/site/jacoco-aggregate/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>
1818
<sonar.tests>${project.basedir}/src/test/java</sonar.tests>
19-
<org.testcontainers.version>1.20.4</org.testcontainers.version>
20-
<awssdk.version>2.31.7</awssdk.version>
19+
<org.testcontainers.version>1.21.4</org.testcontainers.version>
20+
<awssdk.version>2.30.19</awssdk.version>
2121
<azure-identity.version>1.14.0</azure-identity.version>
2222
<azure-kv.version>4.10.0</azure-kv.version>
2323
<azure-identity-extensions.version>1.0.0</azure-identity-extensions.version>

openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/DirectoryResource.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -475,8 +475,10 @@ public Response delete(
475475
public Response restoreDirectory(
476476
@Context UriInfo uriInfo,
477477
@Context SecurityContext securityContext,
478-
@Valid RestoreEntity restore) {
479-
return restoreEntity(uriInfo, securityContext, restore.getId());
478+
@Parameter(description = "Id of the directory", schema = @Schema(type = "UUID"))
479+
@PathParam("id")
480+
UUID id) {
481+
return restoreEntity(uriInfo, securityContext, id);
480482
}
481483

482484
@PUT

openmetadata-service/src/main/java/org/openmetadata/service/resources/drives/FileResource.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -470,7 +470,7 @@ public Response deleteByIdAsync(
470470
}
471471

472472
@PUT
473-
@Path("/{id}/restore")
473+
@Path("{id}/restore")
474474
@Operation(
475475
operationId = "restoreFile",
476476
summary = "Restore a soft deleted file",
@@ -487,8 +487,9 @@ public Response deleteByIdAsync(
487487
public Response restoreFile(
488488
@Context UriInfo uriInfo,
489489
@Context SecurityContext securityContext,
490-
@Valid RestoreEntity restore) {
491-
return restoreEntity(uriInfo, securityContext, restore.getId());
490+
@Parameter(description = "Id of the file", schema = @Schema(type = "UUID")) @PathParam("id")
491+
UUID id) {
492+
return restoreEntity(uriInfo, securityContext, id);
492493
}
493494

494495
@PUT

openmetadata-service/src/main/java/org/openmetadata/service/resources/feeds/FeedResource.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -251,10 +251,7 @@ public Thread get(
251251
@Context UriInfo uriInfo,
252252
@Parameter(description = "Id of the Thread", schema = @Schema(type = "string"))
253253
@PathParam("id")
254-
UUID id,
255-
@Parameter(description = "Type of the Entity", schema = @Schema(type = "string"))
256-
@PathParam("entityType")
257-
String entityType) {
254+
UUID id) {
258255
return addHref(uriInfo, dao.get(id));
259256
}
260257

openmetadata-service/src/main/java/org/openmetadata/service/resources/teams/TeamResource.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -705,8 +705,7 @@ public Response restoreTeam(
705705
@Operation(
706706
operationId = "getCsvDocumentation",
707707
summary = "Get CSV documentation for team import/export")
708-
public String getCsvDocumentation(
709-
@Context SecurityContext securityContext, @PathParam("name") String name) {
708+
public String getCsvDocumentation(@Context SecurityContext securityContext) {
710709
return JsonUtils.pojoToJson(TeamCsv.DOCUMENTATION);
711710
}
712711

0 commit comments

Comments
 (0)