Skip to content

Commit 74dd325

Browse files
Rohit0301anuj-kumary
authored andcommitted
Fix LineageFilter playwright
1 parent b60fd1e commit 74dd325

2 files changed

Lines changed: 40 additions & 8 deletions

File tree

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import {
4040
openImpactAnalysisTab,
4141
performZoomOut,
4242
rearrangeNodes,
43+
setLineageDepthAndVerify,
4344
visitLineageTab,
4445
} from '../../../utils/lineage';
4546
import { test } from '../../fixtures/pages';
@@ -133,6 +134,8 @@ test.describe('Lineage Filters', () => {
133134
await lineageEntity.visitEntityPage(page);
134135
await visitLineageTab(page);
135136
await waitForAllLoadersToDisappear(page);
137+
await setLineageDepthAndVerify(page, 2, 2);
138+
await waitForAllLoadersToDisappear(page);
136139
await rearrangeNodes(page);
137140
await performZoomOut(page);
138141
await expect(
@@ -279,6 +282,8 @@ test.describe('Lineage Filters', () => {
279282
await test.step('Verify filters working for Lineage tab', async () => {
280283
await page.reload();
281284
await waitForAllLoadersToDisappear(page);
285+
await setLineageDepthAndVerify(page, 2, 2);
286+
await waitForAllLoadersToDisappear(page);
282287

283288
await page.getByRole('button', { name: 'Filters' }).click();
284289
await page.getByTestId(`search-dropdown-${filterTestId}`).click();
@@ -962,7 +967,9 @@ test.describe('Lineage Filters', () => {
962967
for (const entity of depth2ndEntities) {
963968
await entity.visitEntityPage(page);
964969
await visitLineageTab(page);
965-
await openImpactAnalysisTab(page);
970+
await waitForAllLoadersToDisappear(page);
971+
await setLineageDepthAndVerify(page, 2, 2);
972+
await page.getByRole('tab', { name: 'Impact Analysis' }).click();
966973
await waitForAllLoadersToDisappear(page);
967974

968975
await expect(
@@ -1000,7 +1007,9 @@ test.describe('Lineage Filters', () => {
10001007
for (const entity of depth2ndEntities) {
10011008
await entity.visitEntityPage(page);
10021009
await visitLineageTab(page);
1003-
await openImpactAnalysisTab(page);
1010+
await waitForAllLoadersToDisappear(page);
1011+
await setLineageDepthAndVerify(page, 2, 2);
1012+
await page.getByRole('tab', { name: 'Impact Analysis' }).click();
10041013

10051014
// Verify Dashboard is visible in Impact Analysis for Upstream
10061015
await page.getByRole('button', { name: 'Upstream' }).click();

openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts

Lines changed: 29 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -869,9 +869,7 @@ export const verifyColumnLineageInCSV = async (
869869
export const verifyLineageConfig = async (page: Page) => {
870870
await page.getByTestId('lineage-config').click();
871871

872-
await page.locator('.ant-modal-content').first().waitFor({
873-
state: 'visible',
874-
});
872+
await page.getByTestId('field-upstream').waitFor({ state: 'visible' });
875873

876874
await page.getByTestId('field-upstream').fill('-1');
877875
await page.getByTestId('field-downstream').fill('-1');
@@ -941,9 +939,7 @@ export const updateLineageConfigFromModal = async (
941939
) => {
942940
await page.getByTestId('lineage-config').click();
943941

944-
await page.locator('.ant-modal-content').first().waitFor({
945-
state: 'visible',
946-
});
942+
await page.getByTestId('field-upstream').waitFor({ state: 'visible' });
947943

948944
await page
949945
.getByTestId('field-upstream')
@@ -956,6 +952,33 @@ export const updateLineageConfigFromModal = async (
956952
await page.getByRole('dialog').waitFor({ state: 'hidden' });
957953
};
958954

955+
export const setLineageDepthAndVerify = async (
956+
page: Page,
957+
upstreamDepth: number,
958+
downstreamDepth: number
959+
) => {
960+
await page.getByTestId('lineage-config').click();
961+
962+
await page.getByTestId('field-upstream').waitFor({ state: 'visible' });
963+
964+
await page.getByTestId('field-upstream').fill(upstreamDepth.toString());
965+
await page.getByTestId('field-downstream').fill(downstreamDepth.toString());
966+
967+
const lineageRes = page.waitForResponse((response) => {
968+
const url = response.url();
969+
970+
return (
971+
url.includes('/api/v1/lineage/getLineage') &&
972+
url.includes(`upstreamDepth=${upstreamDepth}`) &&
973+
url.includes(`downstreamDepth=${downstreamDepth}`)
974+
);
975+
});
976+
977+
await page.getByText('OK').click();
978+
await page.getByRole('dialog').waitFor({ state: 'hidden' });
979+
await lineageRes;
980+
};
981+
959982
export const verifyPlatformLineageForEntity = async (
960983
page: Page,
961984
fromFqn: string,

0 commit comments

Comments
 (0)