fix lineageFilters.spec.ts

Author: chirag-madlani

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts

@@ -31,7 +31,7 @@ import { WorksheetClass } from '../../../support/entity/WorksheetClass';
 import {
   getApiContext,
   getDefaultAdminAPIContext,
-  getEntityTypeSearchIndexMapping,
+  getEntityTypeMapping,
   redirectToHomePage,
 } from '../../../utils/common';
 import { waitForAllLoadersToDisappear } from '../../../utils/entity';
@@ -99,11 +99,11 @@ test.describe('Lineage Filters', () => {
       apiContext,
       {
         id: lineageEntity.entityResponseData.id,
-        type: getEntityTypeSearchIndexMapping(lineageEntity.type),
+        type: getEntityTypeMapping(lineageEntity.type),
       },
       {
         id: depth1Entity.entityResponseData.id,
-        type: getEntityTypeSearchIndexMapping(depth1Entity.type),
+        type: getEntityTypeMapping(depth1Entity.type),
       }
     );
 
@@ -112,11 +112,11 @@ test.describe('Lineage Filters', () => {
         apiContext,
         {
           id: depth1Entity.entityResponseData.id,
-          type: getEntityTypeSearchIndexMapping(lineageEntity.type),
+          type: getEntityTypeMapping(lineageEntity.type),
         },
         {
           id: entity.entityResponseData.id,
-          type: getEntityTypeSearchIndexMapping(entity.type),
+          type: getEntityTypeMapping(entity.type),
         }
       );
     }
@@ -309,14 +309,7 @@ test.describe('Lineage Filters', () => {
 
         await test.step('Verify filters working for Impact Analysis tab', async () => {
           // Navigate to Impact Analysis
-          const impactAnalysisTab = page.getByRole('tab', {
-            name: 'Impact Analysis',
-          });
-
-          await expect(impactAnalysisTab).toBeVisible();
-          await impactAnalysisTab.scrollIntoViewIfNeeded();
-          await impactAnalysisTab.click();
-          await waitForAllLoadersToDisappear(page);
+          await openImpactAnalysisTab(page);
 
           await page.getByRole('button', { name: 'Filters' }).click();
           await page.getByTestId(`search-dropdown-${filterTestId}`).click();
@@ -728,11 +721,11 @@ test.describe('Lineage Filters', () => {
           apiContext,
           {
             id: lineageEntity.entityResponseData.id,
-            type: getEntityTypeSearchIndexMapping(lineageEntity.type),
+            type: getEntityTypeMapping(lineageEntity.type),
           },
           {
             id: depth1Entity.entityResponseData.id,
-            type: getEntityTypeSearchIndexMapping(depth1Entity.type),
+            type: getEntityTypeMapping(depth1Entity.type),
           },
           [
             {
@@ -940,7 +933,7 @@ test.describe('Lineage Filters', () => {
 
   test.describe('Verify filters for Impact Analysis', () => {
     test.beforeEach('navigate to impact analysis', async ({ page }) => {
-      await page.getByRole('tab', { name: 'Impact Analysis' }).click();
+      await openImpactAnalysisTab(page);
       await waitForAllLoadersToDisappear(page);
     });
 
@@ -955,7 +948,7 @@ test.describe('Lineage Filters', () => {
 
       await depth1Entity.visitEntityPage(page);
       await visitLineageTab(page);
-      await page.getByRole('tab', { name: 'Impact Analysis' }).click();
+      await openImpactAnalysisTab(page);
       await waitForAllLoadersToDisappear(page);
 
       await expect(
@@ -965,7 +958,7 @@ test.describe('Lineage Filters', () => {
       for (const entity of depth2ndEntities) {
         await entity.visitEntityPage(page);
         await visitLineageTab(page);
-        await page.getByRole('tab', { name: 'Impact Analysis' }).click();
+        await openImpactAnalysisTab(page);
         await waitForAllLoadersToDisappear(page);
 
         await expect(
@@ -990,8 +983,7 @@ test.describe('Lineage Filters', () => {
 
       await depth1Entity.visitEntityPage(page);
       await visitLineageTab(page);
-      await page.getByRole('tab', { name: 'Impact Analysis' }).click();
-      await waitForAllLoadersToDisappear(page);
+      await openImpactAnalysisTab(page);
 
       // Verify Dashboard is visible in Impact Analysis for Upstream
       await page.getByRole('button', { name: 'Upstream' }).click();
@@ -1004,9 +996,8 @@ test.describe('Lineage Filters', () => {
       for (const entity of depth2ndEntities) {
         await entity.visitEntityPage(page);
         await visitLineageTab(page);
-        await page.getByRole('tab', { name: 'Impact Analysis' }).click();
+        await openImpactAnalysisTab(page);
 
-        await waitForAllLoadersToDisappear(page);
         // Verify Dashboard is visible in Impact Analysis for Upstream
         await page.getByRole('button', { name: 'Upstream' }).click();
         await waitForAllLoadersToDisappear(page);

openmetadata-ui/src/main/resources/ui/playwright/utils/common.ts

@@ -171,6 +171,28 @@ export const getEntityTypeSearchIndexMapping = (entityType: string) => {
   return entityMapping[entityType as keyof typeof entityMapping];
 };
 
+export const getEntityTypeMapping = (entityType: string) => {
+  const entityMapping = {
+    Table: 'table',
+    Topic: 'topic',
+    Dashboard: 'dashboard',
+    Pipeline: 'pipeline',
+    MlModel: 'mlmodel',
+    Container: 'container',
+    SearchIndex: 'searchIndex',
+    ApiEndpoint: 'apiEndpoint',
+    Metric: 'metric',
+    ['Store Procedure']: 'storedProcedure',
+    Directory: 'directory',
+    File: 'file',
+    Spreadsheet: 'spreadsheet',
+    Worksheet: 'worksheet',
+    [DASHBOARD_DATA_MODEL]: 'dashboardDataModel',
+  };
+
+  return entityMapping[entityType as keyof typeof entityMapping];
+};
+
 export const toastNotification = async (
   page: Page,
   message: string | RegExp,